)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"18f68604dbfd1c9ad85571589c1677450729f865","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from oslo_utils import uuidutils"},{"line_number":36,"context_line":"import osprofiler.sqlalchemy"},{"line_number":37,"context_line":"import six"},{"line_number":38,"context_line":"import sqlalchemy"},{"line_number":39,"context_line":"from sqlalchemy import MetaData"},{"line_number":40,"context_line":"from sqlalchemy import or_"},{"line_number":41,"context_line":"from sqlalchemy.orm import joinedload, joinedload_all"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_e8bb1973","line":38,"updated":"2015-02-09 14:59:40.000000000","message":"I think sqlalchemy.MetaData is a class rather than a module.","commit_id":"752c34f3f01f0d01b8349628cc70cdbc696ac14b"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"18f68604dbfd1c9ad85571589c1677450729f865","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import osprofiler.sqlalchemy"},{"line_number":37,"context_line":"import six"},{"line_number":38,"context_line":"import sqlalchemy"},{"line_number":39,"context_line":"from sqlalchemy import MetaData"},{"line_number":40,"context_line":"from sqlalchemy import or_"},{"line_number":41,"context_line":"from sqlalchemy.orm import joinedload, joinedload_all"},{"line_number":42,"context_line":"from sqlalchemy.orm import RelationshipProperty"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_084f8d93","line":39,"updated":"2015-02-09 14:59:40.000000000","message":"or_ is a function. Maybe \"import only modules\" for sqlalchemy is too strict?","commit_id":"752c34f3f01f0d01b8349628cc70cdbc696ac14b"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"18f68604dbfd1c9ad85571589c1677450729f865","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from sqlalchemy.orm import RelationshipProperty"},{"line_number":43,"context_line":"from sqlalchemy.schema import Table"},{"line_number":44,"context_line":"from sqlalchemy.sql.expression import literal_column"},{"line_number":45,"context_line":"from sqlalchemy.sql.expression import true"},{"line_number":46,"context_line":"from sqlalchemy.sql import func"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"from cinder.common import sqlalchemyutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_5c394ad7","line":45,"updated":"2015-02-09 14:59:40.000000000","message":"These sqlalchemy imports basically have the same problem as above.","commit_id":"752c34f3f01f0d01b8349628cc70cdbc696ac14b"}],"cinder/tests/scheduler/test_capacity_weigher.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"6577f3593c3d0f78e95314f449468283ee006a53","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _get_weighed_host(self, hosts, weight_properties\u003dNone):"},{"line_number":40,"context_line":"        if weight_properties is None:"},{"line_number":41,"context_line":"            weight_properties \u003d {\u0027size\u0027: 1}"},{"line_number":42,"context_line":"            weight_properties \u003d {}"},{"line_number":43,"context_line":"        return self.weight_handler.get_weighed_objects("},{"line_number":44,"context_line":"            [capacity.CapacityWeigher],"},{"line_number":45,"context_line":"            hosts,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_5668ecb9","line":42,"updated":"2015-02-18 06:20:49.000000000","message":"This doesn\u0027t seem right. Set weight properties to {\u0027size\u0027: 1}, then {} ?","commit_id":"57f91e67de5ea20db54fe5707a727e3245b24168"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2ebce173ee3be2c944c2420e53d92d3a11c68c47","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _get_weighed_host(self, hosts, weight_properties\u003dNone):"},{"line_number":40,"context_line":"        if weight_properties is None:"},{"line_number":41,"context_line":"            weight_properties \u003d {\u0027size\u0027: 1}"},{"line_number":42,"context_line":"            weight_properties \u003d {}"},{"line_number":43,"context_line":"        return self.weight_handler.get_weighed_objects("},{"line_number":44,"context_line":"            [capacity.CapacityWeigher],"},{"line_number":45,"context_line":"            hosts,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_a679f130","line":42,"in_reply_to":"da86d52c_5668ecb9","updated":"2015-02-18 09:35:33.000000000","message":"seems like error due merge, thanks, it is my fail","commit_id":"57f91e67de5ea20db54fe5707a727e3245b24168"}],"cinder/tests/test_netapp_nfs.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"6577f3593c3d0f78e95314f449468283ee006a53","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from lxml import etree"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import mox as mox_lib"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_36cc58bb","line":22,"updated":"2015-02-18 06:20:49.000000000","message":"Not sure I understand why this needs an alias.","commit_id":"57f91e67de5ea20db54fe5707a727e3245b24168"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2ebce173ee3be2c944c2420e53d92d3a11c68c47","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from lxml import etree"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import mox as mox_lib"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_a6cbb170","line":22,"in_reply_to":"da86d52c_36cc58bb","updated":"2015-02-18 09:35:33.000000000","message":"Alias needs to avoid name conflict in tests, please see line 135 for example","commit_id":"57f91e67de5ea20db54fe5707a727e3245b24168"}],"cinder/tests/windows/test_vhdutils.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"24de711ccbee1caeebb363dc48e40c2d0aebc5da","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        mock.patch.multiple("},{"line_number":51,"context_line":"            \u0027cinder.volume.drivers.windows.vhdutils\u0027, ctypes\u003dfake_ctypes,"},{"line_number":52,"context_line":"            windll\u003dmock.DEFAULT, wintypes\u003dmock.DEFAULT, kernel32\u003dmock.DEFAULT,"},{"line_number":53,"context_line":"            virtdisk\u003dmock.DEFAULT, Win32_GUID\u003dmock.DEFAULT,"},{"line_number":54,"context_line":"            Win32_RESIZE_VIRTUAL_DISK_PARAMETERS\u003dmock.DEFAULT,"},{"line_number":55,"context_line":"            Win32_CREATE_VIRTUAL_DISK_PARAMETERS\u003dmock.DEFAULT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_cf75e4fa","side":"PARENT","line":52,"updated":"2015-02-12 11:48:27.000000000","message":"The windll is not needed, right?","commit_id":"d8c67fd99dee803c3045bad6b3ac492a4f3f8af7"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"38aa5b78f12481090e7fffeff68b4644d7d9623d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        mock.patch.multiple("},{"line_number":51,"context_line":"            \u0027cinder.volume.drivers.windows.vhdutils\u0027, ctypes\u003dfake_ctypes,"},{"line_number":52,"context_line":"            windll\u003dmock.DEFAULT, wintypes\u003dmock.DEFAULT, kernel32\u003dmock.DEFAULT,"},{"line_number":53,"context_line":"            virtdisk\u003dmock.DEFAULT, Win32_GUID\u003dmock.DEFAULT,"},{"line_number":54,"context_line":"            Win32_RESIZE_VIRTUAL_DISK_PARAMETERS\u003dmock.DEFAULT,"},{"line_number":55,"context_line":"            Win32_CREATE_VIRTUAL_DISK_PARAMETERS\u003dmock.DEFAULT,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_f8b42f83","side":"PARENT","line":52,"in_reply_to":"da86d52c_cf75e4fa","updated":"2015-02-12 13:19:06.000000000","message":"windll and wintypes are from ctypes package, which is mock","commit_id":"d8c67fd99dee803c3045bad6b3ac492a4f3f8af7"}],"tox.ini":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2d688dc11f8faf7a29b84c35bee3850d0257cafb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Due to the upgrade to hacking 0.9.2 the following checking are"},{"line_number":71,"context_line":"# ignored on purpose for the moment and should be re-enabled."},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# H302,H405"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"ignore \u003d E251,E265,H402,H405,H803,H904"}],"source_content_type":"text/x-properties","patch_set":6,"id":"da86d52c_7b5fa20f","line":73,"updated":"2015-02-11 02:17:07.000000000","message":"Can remove H302 from the comment now.","commit_id":"752c34f3f01f0d01b8349628cc70cdbc696ac14b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c0251185f9c65cdb28151e3ed090bae714a13644","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# H405"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ignore \u003d E251,H302,H402,H405,H803,H904"},{"line_number":74,"context_line":"exclude \u003d .git,.venv,.tox,dist,tools,doc,common,*egg,build"},{"line_number":75,"context_line":"max-complexity\u003d30"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-properties","patch_set":11,"id":"da86d52c_d82766b4","line":73,"updated":"2015-02-19 14:37:28.000000000","message":"H302 was added back in to the ignore list. Isn\u0027t the point of this patch to not ignore that? :)","commit_id":"7a58ed0c51a811106e63fa771457fe1ef7adec8c"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"00629fc28ed5b1be271043032ab77200f5a3568d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# H405"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"ignore \u003d E251,H302,H402,H405,H803,H904"},{"line_number":74,"context_line":"exclude \u003d .git,.venv,.tox,dist,tools,doc,common,*egg,build"},{"line_number":75,"context_line":"max-complexity\u003d30"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-properties","patch_set":11,"id":"da86d52c_183f3e88","line":73,"in_reply_to":"da86d52c_d82766b4","updated":"2015-02-19 14:44:27.000000000","message":"Thanks Sean for catch it","commit_id":"7a58ed0c51a811106e63fa771457fe1ef7adec8c"}]}