)]}'
{"cinder/tests/targets/test_tgt_driver.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"03f87b41cf3160a70671d5d6149b1e6a71c1c851","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_create_iscsi_target_already_exists(self):"},{"line_number":202,"context_line":"        def _fake_execute(*args, **kwargs):"},{"line_number":203,"context_line":"            if \u0027udpate\u0027 in args:"},{"line_number":204,"context_line":"                raise putils.ProcessExecutionError("},{"line_number":205,"context_line":"                    exit_code\u003d1,"},{"line_number":206,"context_line":"                    stdout\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_39a21dae","line":203,"updated":"2015-01-09 01:07:51.000000000","message":"/udpate/update ?","commit_id":"f1424f27e81a9b46ed60a59eafb9f2dadd2f3b59"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"18a39ae478b8964886b807dd042bedc0b0503fcf","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_create_iscsi_target_already_exists(self):"},{"line_number":202,"context_line":"        def _fake_execute(*args, **kwargs):"},{"line_number":203,"context_line":"            if \u0027udpate\u0027 in args:"},{"line_number":204,"context_line":"                raise putils.ProcessExecutionError("},{"line_number":205,"context_line":"                    exit_code\u003d1,"},{"line_number":206,"context_line":"                    stdout\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7106791d","line":203,"in_reply_to":"3a961159_39a21dae","updated":"2015-01-09 04:31:24.000000000","message":"Thanks Sean!","commit_id":"f1424f27e81a9b46ed60a59eafb9f2dadd2f3b59"}],"cinder/volume/targets/tgt.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e7eddb480322175864edd26217264e22ee38784d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        volume_path \u003d os.path.join(volumes_dir, vol_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        if os.path.exists(volume_path):"},{"line_number":216,"context_line":"            LOG.warning(_LW(\u0027persistence file already exists for volume, \u0027"},{"line_number":217,"context_line":"                            \u0027found file at: %s\u0027), volume_path)"},{"line_number":218,"context_line":"        f \u003d open(volume_path, \u0027w+\u0027)"},{"line_number":219,"context_line":"        f.write(volume_conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_008b1dc0","line":216,"updated":"2015-01-09 11:51:12.000000000","message":"It would be better if you could capitalize the first letter.","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9774ab4aa6e90070dec5f4c54670101d1953b644","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        volume_path \u003d os.path.join(volumes_dir, vol_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        if os.path.exists(volume_path):"},{"line_number":216,"context_line":"            LOG.warning(_LW(\u0027persistence file already exists for volume, \u0027"},{"line_number":217,"context_line":"                            \u0027found file at: %s\u0027), volume_path)"},{"line_number":218,"context_line":"        f \u003d open(volume_path, \u0027w+\u0027)"},{"line_number":219,"context_line":"        f.write(volume_conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a6f41a89","line":216,"in_reply_to":"3a961159_008b1dc0","updated":"2015-01-09 17:14:03.000000000","message":"Ok","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e7eddb480322175864edd26217264e22ee38784d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        old_persist_file \u003d None"},{"line_number":226,"context_line":"        old_name \u003d kwargs.get(\u0027old_name\u0027, None)"},{"line_number":227,"context_line":"        if old_name is not None:"},{"line_number":228,"context_line":"            LOG.debug(\u0027detected old persistence file for volume \u0027"},{"line_number":229,"context_line":"                      \u0027%{vol}s at %{old_name}s\u0027,"},{"line_number":230,"context_line":"                      {\u0027vol\u0027: vol_id, \u0027old_name\u0027: old_name})"},{"line_number":231,"context_line":"            old_persist_file \u003d os.path.join(volumes_dir, old_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_80b62d87","line":228,"updated":"2015-01-09 11:51:12.000000000","message":"Same as above.","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9774ab4aa6e90070dec5f4c54670101d1953b644","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        old_persist_file \u003d None"},{"line_number":226,"context_line":"        old_name \u003d kwargs.get(\u0027old_name\u0027, None)"},{"line_number":227,"context_line":"        if old_name is not None:"},{"line_number":228,"context_line":"            LOG.debug(\u0027detected old persistence file for volume \u0027"},{"line_number":229,"context_line":"                      \u0027%{vol}s at %{old_name}s\u0027,"},{"line_number":230,"context_line":"                      {\u0027vol\u0027: vol_id, \u0027old_name\u0027: old_name})"},{"line_number":231,"context_line":"            old_persist_file \u003d os.path.join(volumes_dir, old_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e6ee22b5","line":228,"in_reply_to":"3a961159_80b62d87","updated":"2015-01-09 17:14:03.000000000","message":"Why not :)","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"228d7634f1ba9dd2c68ab8c2b4733756041ac59f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            LOG.debug(\"StdErr from tgt-admin --update: %s\", err)"},{"line_number":242,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":243,"context_line":"            if \"target already exists\" in e.stderr:"},{"line_number":244,"context_line":"                # Adding the additional Warning message above for a clear"},{"line_number":245,"context_line":"                # ER marker (Ref bug: #1398078)."},{"line_number":246,"context_line":"                LOG.warning(_LW(\u0027Could not create target because \u0027"},{"line_number":247,"context_line":"                                \u0027it already exists for volume: %s\u0027), vol_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_25190b88","line":244,"updated":"2015-01-09 10:06:37.000000000","message":"s/above/below","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9774ab4aa6e90070dec5f4c54670101d1953b644","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            LOG.debug(\"StdErr from tgt-admin --update: %s\", err)"},{"line_number":242,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":243,"context_line":"            if \"target already exists\" in e.stderr:"},{"line_number":244,"context_line":"                # Adding the additional Warning message above for a clear"},{"line_number":245,"context_line":"                # ER marker (Ref bug: #1398078)."},{"line_number":246,"context_line":"                LOG.warning(_LW(\u0027Could not create target because \u0027"},{"line_number":247,"context_line":"                                \u0027it already exists for volume: %s\u0027), vol_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_462d36fd","line":244,"in_reply_to":"3a961159_25190b88","updated":"2015-01-09 17:14:03.000000000","message":"Done","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e7eddb480322175864edd26217264e22ee38784d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Grab targets list for debug"},{"line_number":260,"context_line":"        # Consider adding a check for lun 0 and 1 for tgtadm"},{"line_number":261,"context_line":"        # before considering this as valid"},{"line_number":262,"context_line":"        (out, err) \u003d utils.execute(\u0027tgtadm\u0027,"},{"line_number":263,"context_line":"                                   \u0027--lld\u0027,"},{"line_number":264,"context_line":"                                   \u0027iscsi\u0027,"},{"line_number":265,"context_line":"                                   \u0027--op\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3b084a90","line":262,"updated":"2015-01-09 11:51:12.000000000","message":"Does it need try except protection?","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9774ab4aa6e90070dec5f4c54670101d1953b644","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # Grab targets list for debug"},{"line_number":260,"context_line":"        # Consider adding a check for lun 0 and 1 for tgtadm"},{"line_number":261,"context_line":"        # before considering this as valid"},{"line_number":262,"context_line":"        (out, err) \u003d utils.execute(\u0027tgtadm\u0027,"},{"line_number":263,"context_line":"                                   \u0027--lld\u0027,"},{"line_number":264,"context_line":"                                   \u0027iscsi\u0027,"},{"line_number":265,"context_line":"                                   \u0027--op\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_46dff60c","line":262,"in_reply_to":"3a961159_3b084a90","updated":"2015-01-09 17:14:03.000000000","message":"No,if a tgt show fails we\u0027ve got bigger problems and I\u0027m fine with it resulting in an unhandled exception/trace.","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e7eddb480322175864edd26217264e22ee38784d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                   \u0027--mode\u0027,"},{"line_number":268,"context_line":"                                   \u0027target\u0027,"},{"line_number":269,"context_line":"                                   run_as_root\u003dTrue)"},{"line_number":270,"context_line":"        LOG.debug(\"Targets after update: %s\" % out)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        iqn \u003d \u0027%s%s\u0027 % (self.iscsi_target_prefix, vol_id)"},{"line_number":273,"context_line":"        tid \u003d self._get_target(iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_60414162","line":270,"updated":"2015-01-09 11:51:12.000000000","message":"Would you also log what\u0027s in `err`?","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9774ab4aa6e90070dec5f4c54670101d1953b644","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                   \u0027--mode\u0027,"},{"line_number":268,"context_line":"                                   \u0027target\u0027,"},{"line_number":269,"context_line":"                                   run_as_root\u003dTrue)"},{"line_number":270,"context_line":"        LOG.debug(\"Targets after update: %s\" % out)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        iqn \u003d \u0027%s%s\u0027 % (self.iscsi_target_prefix, vol_id)"},{"line_number":273,"context_line":"        tid \u003d self._get_target(iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_46061687","line":270,"in_reply_to":"3a961159_60414162","updated":"2015-01-09 17:14:03.000000000","message":"No, it\u0027s there for debug purposes only, no reason to clutter up logs with a message that we\u0027re going to generate expectedly on every create we do.","commit_id":"e47babafcec0fef0fc1e2b21139b39653e174067"}]}