)]}'
{"cinder/tests/test_vmware_vmdk.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fffc64352d6991dd141281b49f3df04aa4d64d80","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            wsdl_loc\u003dself._config.vmware_wsdl_location)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Restore values set in setUp."},{"line_number":199,"context_line":"        self._session \u003d cur_session"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch(\u0027oslo.vmware.api.VMwareAPISession\u0027)"},{"line_number":202,"context_line":"    def test_session_with_non_default_port(self, apiSession):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_f4e6c943","line":199,"updated":"2015-01-21 01:01:59.000000000","message":"Tests should not clean up data. You should use tearDown method","commit_id":"89410b30304ef027dad21702cb73519d3b46ed60"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e927726d263bb3ec0739850211cd4a691bd47eae","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            wsdl_loc\u003dself._config.vmware_wsdl_location)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # Restore values set in setUp."},{"line_number":199,"context_line":"        self._session \u003d cur_session"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch(\u0027oslo.vmware.api.VMwareAPISession\u0027)"},{"line_number":202,"context_line":"    def test_session_with_non_default_port(self, apiSession):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_4a7348e9","line":199,"in_reply_to":"1a930d6b_f4e6c943","updated":"2015-01-22 07:16:03.000000000","message":"Thanks for pointing this out. In fact we don\u0027t need tearDown since session will be created new in setUp before every test method. Removed statement for resetting session.","commit_id":"89410b30304ef027dad21702cb73519d3b46ed60"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"bbaa79649f941096e9ea5d68ff4be7da07201e66","unresolved":false,"context_lines":[{"line_number":1869,"context_line":"            api_retry_count \u003d self.configuration.vmware_api_retry_count"},{"line_number":1870,"context_line":"            task_poll_interval \u003d self.configuration.vmware_task_poll_interval"},{"line_number":1871,"context_line":"            wsdl_loc \u003d self.configuration.safe_get(\u0027vmware_wsdl_location\u0027)"},{"line_number":1872,"context_line":"            pbm_wsdl \u003d self.pbm_wsdl if hasattr(self, \u0027pbm_wsdl\u0027) else None"},{"line_number":1873,"context_line":"            self._session \u003d api.VMwareAPISession(ip, username,"},{"line_number":1874,"context_line":"                                                 password, api_retry_count,"},{"line_number":1875,"context_line":"                                                 task_poll_interval,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e1ffa933","line":1872,"updated":"2015-01-13 07:54:15.000000000","message":"We should pass the port number here as well.","commit_id":"077f966c8ddcb239d80bb753af4a4207da70e3cd"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"494c4ee67728db6ff48c92bb70eb5a393d511934","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d443,"},{"line_number":65,"context_line":"               help\u003d\u0027Port number for connecting to VMware ESX/VC server.\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"},{"line_number":67,"context_line":"               default\u003dNone,"},{"line_number":68,"context_line":"               help\u003d\u0027Username for authenticating with VMware ESX/VC server.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027vmware_host_password\u0027,"},{"line_number":70,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_10c4565e","line":67,"updated":"2015-01-17 18:56:25.000000000","message":"I don\u0027t see any value checking on this input.  Not a fan of input like this without making sure it is a valid port number.  Could that be added please?","commit_id":"081b3c4a3552ea070a67c087806764a40ab803dd"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8c5747d874f017f421df7b88d473f1a3446168f3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d443,"},{"line_number":65,"context_line":"               help\u003d\u0027Port number for connecting to VMware ESX/VC server.\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"},{"line_number":67,"context_line":"               default\u003dNone,"},{"line_number":68,"context_line":"               help\u003d\u0027Username for authenticating with VMware ESX/VC server.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027vmware_host_password\u0027,"},{"line_number":70,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_6a2564c1","line":67,"in_reply_to":"3a961159_10c4565e","updated":"2015-01-22 07:14:29.000000000","message":"Added validation for port number. We can add validation for remaining config values in a different patch.","commit_id":"081b3c4a3552ea070a67c087806764a40ab803dd"},{"author":{"_account_id":9297,"name":"Johnson koil raj","email":"jraj@infoblox.com","username":"jkraj"},"change_message_id":"aa162b7b1d0f57dffa1df4575d9922fdf87b75ca","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d443,"},{"line_number":65,"context_line":"               help\u003d\u0027Port number for connecting to VMware ESX/VC server.\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"},{"line_number":67,"context_line":"               default\u003dNone,"},{"line_number":68,"context_line":"               help\u003d\u0027Username for authenticating with VMware ESX/VC server.\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027vmware_host_password\u0027,"},{"line_number":70,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c26d8b9c","line":67,"in_reply_to":"3a961159_10c4565e","updated":"2015-01-19 16:17:25.000000000","message":"Do you want to add more detail comments to the \u0027vmware_host_port\u0027,","commit_id":"081b3c4a3552ea070a67c087806764a40ab803dd"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13768488e4384cc99f8df4d88b54b1f5a5d5bdd7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027IP address for connecting to VMware ESX/VC server.\u0027),"},{"line_number":64,"context_line":"    cfg.IntOpt(\u0027vmware_host_port\u0027,"},{"line_number":65,"context_line":"               default\u003d443,"},{"line_number":66,"context_line":"               help\u003d\u0027Port number for connecting to VMware ESX/VC server.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"},{"line_number":68,"context_line":"               default\u003dNone,"},{"line_number":69,"context_line":"               help\u003d\u0027Username for authenticating with VMware ESX/VC server.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_24937650","line":66,"updated":"2015-01-22 19:47:32.000000000","message":"as part of https://bugs.launchpad.net/cinder/+bug/1398976 I\u0027d really like to just suck it up here and implement a generalized config option like \"backend_host_port\" or \"endpoint_port\" or something along those lines and just consolidate these rather than introducing another option here.","commit_id":"0789285863102fb71a8104a8d8fa5131596a2ad0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2d17013bba87439b3eab309c20ecbd7b947e76c2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027IP address for connecting to VMware ESX/VC server.\u0027),"},{"line_number":64,"context_line":"    cfg.IntOpt(\u0027vmware_host_port\u0027,"},{"line_number":65,"context_line":"               default\u003d443,"},{"line_number":66,"context_line":"               help\u003d\u0027Port number for connecting to VMware ESX/VC server.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"},{"line_number":68,"context_line":"               default\u003dNone,"},{"line_number":69,"context_line":"               help\u003d\u0027Username for authenticating with VMware ESX/VC server.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ed4c46ca","line":66,"in_reply_to":"1a930d6b_24937650","updated":"2015-02-06 14:58:48.000000000","message":"I like the idea of having a common config option that can be used by all backends.","commit_id":"0789285863102fb71a8104a8d8fa5131596a2ad0"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a9e3d8cd4599d6dbddb0cb9d3d0075a779033a3c","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _validate_config(self):"},{"line_number":254,"context_line":"        port \u003d self.configuration.vmware_host_port"},{"line_number":255,"context_line":"        if not netutils.is_valid_port(port):"},{"line_number":256,"context_line":"            reason \u003d _(\"Invalid port number: %s for connecting to VMware \""},{"line_number":257,"context_line":"                       \"ESX/VC server.\") % port"},{"line_number":258,"context_line":"            LOG.error(reason)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_45456b41","line":255,"updated":"2015-02-11 23:05:27.000000000","message":"Do we need to check other config options?","commit_id":"42f912eae69ae79ac187f14729dbd4526667cf8e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a9e3d8cd4599d6dbddb0cb9d3d0075a779033a3c","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            instance \u003d vim_util.get_moref(connector[\u0027instance\u0027],"},{"line_number":677,"context_line":"                                          \u0027VirtualMachine\u0027)"},{"line_number":678,"context_line":"            LOG.debug(\"The instance: %s for which initialize connection \""},{"line_number":679,"context_line":"                      \"is called, exists.\" % instance)"},{"line_number":680,"context_line":"            # Get host managing the instance"},{"line_number":681,"context_line":"            host \u003d self.volumeops.get_host(instance)"},{"line_number":682,"context_line":"            if not backing:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_c50b1b22","line":679,"updated":"2015-02-11 23:05:27.000000000","message":"% \u003d\u003e ,\nPlease, rollback such changes here and below","commit_id":"42f912eae69ae79ac187f14729dbd4526667cf8e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a9e3d8cd4599d6dbddb0cb9d3d0075a779033a3c","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            if not backing:"},{"line_number":683,"context_line":"                # Create a backing in case it does not exist under the"},{"line_number":684,"context_line":"                # host managing the instance."},{"line_number":685,"context_line":"                LOG.info(_LI(\"There is no backing for the volume: %s. \""},{"line_number":686,"context_line":"                             \"Need to create one.\") % volume[\u0027name\u0027])"},{"line_number":687,"context_line":"                backing \u003d self._create_backing(volume, host)"},{"line_number":688,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_e513bf59","line":685,"updated":"2015-02-11 23:05:27.000000000","message":"% \u003d\u003e ,","commit_id":"42f912eae69ae79ac187f14729dbd4526667cf8e"}]}