)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"dd584e38bd35d28530fa1e0c6f5f9ab28dbc9a22","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Philipp Marek \u003cphilipp.marek@linbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-12 10:37:48 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Give a meaningful error message if some library couldn\u0027t be loaded."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0631228228db06efdedd65a44a286824b34e0b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_99fda3b4","line":7,"updated":"2015-01-12 09:48:54.000000000","message":"Add \u0027DRDB\u0027 to the subject, please","commit_id":"aed899f151874f992e010f934dda420951d119f8"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"d72a198dc54ec0ec71be8147ffc1377a51651232","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Philipp Marek \u003cphilipp.marek@linbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-12 10:37:48 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Give a meaningful error message if some library couldn\u0027t be loaded."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0631228228db06efdedd65a44a286824b34e0b1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_dc570e59","line":7,"in_reply_to":"3a961159_99fda3b4","updated":"2015-01-12 15:27:22.000000000","message":"The first line of a commit generally doesn\u0027t take a dot at the end.","commit_id":"aed899f151874f992e010f934dda420951d119f8"}],"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"dd584e38bd35d28530fa1e0c6f5f9ab28dbc9a22","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Verify that requirements are in place to use DRBDmanage driver.\"\"\""},{"line_number":130,"context_line":"        if not all(dbus, dm_exc, dm_const, dm_utils):"},{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: required libraries\u0027"},{"line_number":132,"context_line":"                        \u0027not found.\u0027)"},{"line_number":133,"context_line":"            raise exception.VolumeDriverException(data\u003dmessage)"},{"line_number":134,"context_line":"        if self.odm.ping() !\u003d 0:"},{"line_number":135,"context_line":"            message \u003d _(\u0027Cannot ping DRBDmanage backend\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b9b7bff7","line":132,"updated":"2015-01-12 09:48:54.000000000","message":"Probably worth a LOG.error call too - drivers should not assume that the parent manager will do any specific logging","commit_id":"aed899f151874f992e010f934dda420951d119f8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"479e251e23a9ccf302650110318dcbb6edf0c2cd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Verify that requirements are in place to use DRBDmanage driver.\"\"\""},{"line_number":130,"context_line":"        if not all(dbus, dm_exc, dm_const, dm_utils):"},{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: required libraries\u0027"},{"line_number":132,"context_line":"                        \u0027not found.\u0027)"},{"line_number":133,"context_line":"            raise exception.VolumeDriverException(data\u003dmessage)"},{"line_number":134,"context_line":"        if self.odm.ping() !\u003d 0:"},{"line_number":135,"context_line":"            message \u003d _(\u0027Cannot ping DRBDmanage backend\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cb14aaa1","line":132,"in_reply_to":"3a961159_b9b7bff7","updated":"2015-01-12 14:20:17.000000000","message":"Agree with Duncan. Please, add also list of required libraries to a log message","commit_id":"aed899f151874f992e010f934dda420951d119f8"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"d72a198dc54ec0ec71be8147ffc1377a51651232","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Verify that requirements are in place to use DRBDmanage driver.\"\"\""},{"line_number":130,"context_line":"        if not all(dbus, dm_exc, dm_const, dm_utils):"},{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: required libraries\u0027"},{"line_number":132,"context_line":"                        \u0027not found.\u0027)"},{"line_number":133,"context_line":"            raise exception.VolumeDriverException(data\u003dmessage)"},{"line_number":134,"context_line":"        if self.odm.ping() !\u003d 0:"},{"line_number":135,"context_line":"            message \u003d _(\u0027Cannot ping DRBDmanage backend\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7c437aaf","line":132,"in_reply_to":"3a961159_cb14aaa1","updated":"2015-01-12 15:27:22.000000000","message":"Also, please add a space between \u0027libraries\u0027 and \u0027not\u0027 otherwise they\u0027ll be concatenated in one single word.","commit_id":"aed899f151874f992e010f934dda420951d119f8"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d7fa709f789a39eb3df62315040183610ae0d861","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def check_for_setup_error(self):"},{"line_number":129,"context_line":"        \"\"\"Verify that requirements are in place to use DRBDmanage driver.\"\"\""},{"line_number":130,"context_line":"        if not all(dbus, dm_exc, dm_const, dm_utils):"},{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: some required \u0027"},{"line_number":132,"context_line":"                        \u0027libraries (dbus, drbdmanage.*) not found.\u0027)"},{"line_number":133,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_20c19d4e","line":130,"updated":"2015-01-13 15:10:50.000000000","message":"all takes an iterable so I think you need to put those variables in a tuple:\n\nif not all((dbus, dm_exc, dm_const, dm_utils)):","commit_id":"a39c881b76c70ca13f0d5640815131eb576c4791"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e38f97fe2a7e25ad472de1f8f51217358e187b4d","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def check_for_setup_error(self):"},{"line_number":129,"context_line":"        \"\"\"Verify that requirements are in place to use DRBDmanage driver.\"\"\""},{"line_number":130,"context_line":"        if not all(dbus, dm_exc, dm_const, dm_utils):"},{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: some required \u0027"},{"line_number":132,"context_line":"                        \u0027libraries (dbus, drbdmanage.*) not found.\u0027)"},{"line_number":133,"context_line":"            LOG.error(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a3ebbea2","line":130,"in_reply_to":"3a961159_20c19d4e","updated":"2015-01-14 06:37:40.000000000","message":"right, thanks.","commit_id":"a39c881b76c70ca13f0d5640815131eb576c4791"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d7fa709f789a39eb3df62315040183610ae0d861","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: some required \u0027"},{"line_number":132,"context_line":"                        \u0027libraries (dbus, drbdmanage.*) not found.\u0027)"},{"line_number":133,"context_line":"            LOG.error(message)"},{"line_number":134,"context_line":"            raise exception.VolumeDriverException(data\u003dmessage)"},{"line_number":135,"context_line":"        if self.odm.ping() !\u003d 0:"},{"line_number":136,"context_line":"            message \u003d _(\u0027Cannot ping DRBDmanage backend\u0027)"},{"line_number":137,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f31a0d6e","line":134,"updated":"2015-01-13 15:10:50.000000000","message":"I think this line should be:\n\nraise exception.VolumeDriverException(message\u003dmessage)","commit_id":"a39c881b76c70ca13f0d5640815131eb576c4791"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"e38f97fe2a7e25ad472de1f8f51217358e187b4d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            message \u003d _(\u0027DRBDmanage driver setup error: some required \u0027"},{"line_number":132,"context_line":"                        \u0027libraries (dbus, drbdmanage.*) not found.\u0027)"},{"line_number":133,"context_line":"            LOG.error(message)"},{"line_number":134,"context_line":"            raise exception.VolumeDriverException(data\u003dmessage)"},{"line_number":135,"context_line":"        if self.odm.ping() !\u003d 0:"},{"line_number":136,"context_line":"            message \u003d _(\u0027Cannot ping DRBDmanage backend\u0027)"},{"line_number":137,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_23850ecf","line":134,"in_reply_to":"3a961159_f31a0d6e","updated":"2015-01-14 06:37:40.000000000","message":"I changed this line and the line below; but a \"grep\" on the sources shows \"data\u003d\" being used in at least one other place (cinder/volume/drivers/ibm/flashsystem.py).\n\nVolumeBackendAPIException uses \"data\u003d\" throughout, btw.","commit_id":"a39c881b76c70ca13f0d5640815131eb576c4791"}]}