)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message shown when the parser finds a parser error"},{"line_number":10,"context_line":"says, \u0027file not found\u0027 which causes confusion on the user when"},{"line_number":11,"context_line":"he/she needs to debug the real cause o the problem. This patch fix"},{"line_number":12,"context_line":"this by testing first if the file exist and then throwing a proper error"},{"line_number":13,"context_line":"message."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_f75f2073","line":11,"updated":"2015-01-14 22:31:42.000000000","message":"typo \"cause o the problem\" -\u003e \"cause of the problem\"\nand\nfix -\u003e fixes","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message shown when the parser finds a parser error"},{"line_number":10,"context_line":"says, \u0027file not found\u0027 which causes confusion on the user when"},{"line_number":11,"context_line":"he/she needs to debug the real cause o the problem. This patch fix"},{"line_number":12,"context_line":"this by testing first if the file exist and then throwing a proper error"},{"line_number":13,"context_line":"message."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_5d7d601d","line":11,"in_reply_to":"3a961159_f75f2073","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"}],"cinder/volume/drivers/hds/iscsi.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\"Read hds driver specific xml config file.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":95,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":96,"context_line":"                                             + xml_config_file)"},{"line_number":97,"context_line":"                                 )"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_77f7b08c","line":95,"updated":"2015-01-14 22:31:42.000000000","message":"Recommend using \" here so you don\u0027t need to escape the \u0027 in Can\u0027t.","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\"Read hds driver specific xml config file.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":95,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":96,"context_line":"                                             + xml_config_file)"},{"line_number":97,"context_line":"                                 )"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e04823b6","line":95,"in_reply_to":"3a961159_77f7b08c","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":95,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":96,"context_line":"                                             + xml_config_file)"},{"line_number":97,"context_line":"                                 )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3731a859","line":96,"updated":"2015-01-14 22:31:42.000000000","message":"Can\u0027t use + in exception messages.  Please do \"%s\", xml_config_file.","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":95,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":96,"context_line":"                                             + xml_config_file)"},{"line_number":97,"context_line":"                                 )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c04fa7bc","line":96,"in_reply_to":"3a961159_3731a859","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        root \u003d ETree.parse(xml_config_file).getroot()"},{"line_number":101,"context_line":"    except Exception:"},{"line_number":102,"context_line":"        raise exception.ConfigNotFound("},{"line_number":103,"context_line":"            message\u003d_LE(\u0027Error parsing config file: \u0027 + xml_config_file))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # mandatory parameters"},{"line_number":106,"context_line":"    config \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3708c87f","line":103,"updated":"2015-01-14 22:31:42.000000000","message":"Don\u0027t use + here either.  See line 85 above for a correct example.","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        root \u003d ETree.parse(xml_config_file).getroot()"},{"line_number":101,"context_line":"    except Exception:"},{"line_number":102,"context_line":"        raise exception.ConfigNotFound("},{"line_number":103,"context_line":"            message\u003d_LE(\u0027Error parsing config file: \u0027 + xml_config_file))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # mandatory parameters"},{"line_number":106,"context_line":"    config \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_20c6ab16","line":103,"in_reply_to":"3a961159_3708c87f","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"08a1da6a1fc1236209b6ecb56b623dae6b492466","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    except ETree.ParseError:"},{"line_number":82,"context_line":"        if check:"},{"line_number":83,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":84,"context_line":"                LOG.error(_LE(\"XML exception reading parameter: %s\") % element)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            LOG.info(_LI(\"XML exception reading parameter: %s\") % element)"},{"line_number":87,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e6267466","line":84,"updated":"2015-01-15 15:59:16.000000000","message":"Please, change logging formatting from \u0027%\u0027 to \u0027,\u0027 according to a guidelines","commit_id":"c0a0301c88add0cb41524e60c84a7307b9e98ef1"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"860c6a56d19348ba8090ad46f69f103a6b8dc649","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    except ETree.ParseError:"},{"line_number":82,"context_line":"        if check:"},{"line_number":83,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":84,"context_line":"                LOG.error(_LE(\"XML exception reading parameter: %s\") % element)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            LOG.info(_LI(\"XML exception reading parameter: %s\") % element)"},{"line_number":87,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_bb56f329","line":84,"in_reply_to":"3a961159_c655f852","updated":"2015-01-19 12:51:27.000000000","message":"Please, see http://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"c0a0301c88add0cb41524e60c84a7307b9e98ef1"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"3fc43c7ab0c7f102234e1849681281eefc7f6550","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    except ETree.ParseError:"},{"line_number":82,"context_line":"        if check:"},{"line_number":83,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":84,"context_line":"                LOG.error(_LE(\"XML exception reading parameter: %s\") % element)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            LOG.info(_LI(\"XML exception reading parameter: %s\") % element)"},{"line_number":87,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c655f852","line":84,"in_reply_to":"3a961159_e6267466","updated":"2015-01-19 12:40:03.000000000","message":"Can you point out the guidelines? This is passing PEP8 that should take care of any formatting guidelines doesn\u0027t?","commit_id":"c0a0301c88add0cb41524e60c84a7307b9e98ef1"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"08a1da6a1fc1236209b6ecb56b623dae6b492466","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":84,"context_line":"                LOG.error(_LE(\"XML exception reading parameter: %s\") % element)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            LOG.info(_LI(\"XML exception reading parameter: %s\") % element)"},{"line_number":87,"context_line":"            return None"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_061f000a","line":86,"updated":"2015-01-15 15:59:16.000000000","message":"Please, change logging formatting from \u0027%\u0027 to \u0027,\u0027 according to a guidelines","commit_id":"c0a0301c88add0cb41524e60c84a7307b9e98ef1"}],"cinder/volume/drivers/hds/nfs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":86,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":87,"context_line":"                                             + xml_config_file)"},{"line_number":88,"context_line":"                                 )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d71864cf","line":87,"updated":"2015-01-14 22:31:42.000000000","message":"The + here needs to be removed.","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if not os.access(xml_config_file, os.R_OK):"},{"line_number":86,"context_line":"        raise exception.NotFound(message\u003d_LE(\u0027Can\\\u0027t open config file: \u0027"},{"line_number":87,"context_line":"                                             + xml_config_file)"},{"line_number":88,"context_line":"                                 )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c0d6c7c2","line":87,"in_reply_to":"3a961159_d71864cf","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8a74468bedfc6f1b5353d91f72124cacc70f4451","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        root \u003d ETree.parse(xml_config_file).getroot()"},{"line_number":92,"context_line":"    except Exception:"},{"line_number":93,"context_line":"        raise exception.ConfigNotFound("},{"line_number":94,"context_line":"            message\u003d_LE(\u0027Error parsing config file: \u0027 + xml_config_file))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # mandatory parameters"},{"line_number":97,"context_line":"    config \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_377fe8e0","line":94,"updated":"2015-01-14 22:31:42.000000000","message":"The + here needs to be removed.","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"76676251922d74dcb3dcf3cfbbeee8aed60dc530","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        root \u003d ETree.parse(xml_config_file).getroot()"},{"line_number":92,"context_line":"    except Exception:"},{"line_number":93,"context_line":"        raise exception.ConfigNotFound("},{"line_number":94,"context_line":"            message\u003d_LE(\u0027Error parsing config file: \u0027 + xml_config_file))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # mandatory parameters"},{"line_number":97,"context_line":"    config \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_00dd2fdd","line":94,"in_reply_to":"3a961159_377fe8e0","updated":"2015-01-15 12:41:50.000000000","message":"Done","commit_id":"e8d96cc451f74a26c4197e05147dbdbf73f26eda"}]}