)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"756805130b5af4ccd6adbddb1e66ac3f9c247fad","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        else:"},{"line_number":325,"context_line":"            iscsi_target \u003d 1  # dummy value when using TgtAdm"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # Check for bug 1065702"},{"line_number":328,"context_line":"        old_name \u003d None"},{"line_number":329,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"},{"line_number":330,"context_line":"        if volume[\u0027provider_location\u0027] is not None and\\"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5kU%3D","line":327,"updated":"2012-10-29 22:12:35.000000000","message":"use full url?","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"856157d1bf8a9d074d861417c4dc8a059d610eb8","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        else:"},{"line_number":325,"context_line":"            iscsi_target \u003d 1  # dummy value when using TgtAdm"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # Check for bug 1065702"},{"line_number":328,"context_line":"        old_name \u003d None"},{"line_number":329,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"},{"line_number":330,"context_line":"        if volume[\u0027provider_location\u0027] is not None and\\"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5h0%3D","line":327,"in_reply_to":"AAAALn%2F%2F5kU%3D","updated":"2012-10-29 22:39:30.000000000","message":"Done","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"756805130b5af4ccd6adbddb1e66ac3f9c247fad","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        old_name \u003d None"},{"line_number":329,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"},{"line_number":330,"context_line":"        if volume[\u0027provider_location\u0027] is not None and\\"},{"line_number":331,"context_line":"            volume[\u0027name\u0027] not in volume[\u0027provider_location\u0027]:"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            msg \u003d _(\u0027Detected inconsistency in provider_location id\u0027)"},{"line_number":334,"context_line":"            LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5kY%3D","line":331,"updated":"2012-10-29 22:12:35.000000000","message":"parens instead of \\","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"856157d1bf8a9d074d861417c4dc8a059d610eb8","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        old_name \u003d None"},{"line_number":329,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"},{"line_number":330,"context_line":"        if volume[\u0027provider_location\u0027] is not None and\\"},{"line_number":331,"context_line":"            volume[\u0027name\u0027] not in volume[\u0027provider_location\u0027]:"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            msg \u003d _(\u0027Detected inconsistency in provider_location id\u0027)"},{"line_number":334,"context_line":"            LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5hw%3D","line":331,"in_reply_to":"AAAALn%2F%2F5kY%3D","updated":"2012-10-29 22:39:30.000000000","message":"Done","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"756805130b5af4ccd6adbddb1e66ac3f9c247fad","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            msg \u003d _(\u0027Detected inconsistency in provider_location id\u0027)"},{"line_number":334,"context_line":"            LOG.debug(msg)"},{"line_number":335,"context_line":"            old_name \u003d self._fix_id_migration(context, volume)"},{"line_number":336,"context_line":"            if \u0027in-use\u0027 in volume[\u0027status\u0027]:"},{"line_number":337,"context_line":"                volume_name \u003d old_name"},{"line_number":338,"context_line":"                old_name \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5jU%3D","line":335,"updated":"2012-10-29 22:12:35.000000000","message":"i thought you were going to do this fix on detach?","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"856157d1bf8a9d074d861417c4dc8a059d610eb8","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            msg \u003d _(\u0027Detected inconsistency in provider_location id\u0027)"},{"line_number":334,"context_line":"            LOG.debug(msg)"},{"line_number":335,"context_line":"            old_name \u003d self._fix_id_migration(context, volume)"},{"line_number":336,"context_line":"            if \u0027in-use\u0027 in volume[\u0027status\u0027]:"},{"line_number":337,"context_line":"                volume_name \u003d old_name"},{"line_number":338,"context_line":"                old_name \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5ig%3D","line":335,"in_reply_to":"AAAALn%2F%2F5jU%3D","updated":"2012-10-29 22:39:30.000000000","message":"This just uses the \"old\" name in the case of in-use by setting the kwargs[\u0027old_name\u0027] to None.  In the manager.detach, if provider_location is wrong I use this same kwargs to create the new target and remove the old persist file.\n\nSo in this case if the volume is attached it will just call the create_iscsi_target using the old volume name so there\u0027s nothing disturbed in terms of attached volumes.","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"756805130b5af4ccd6adbddb1e66ac3f9c247fad","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                                        check_exit_code\u003dFalse,"},{"line_number":348,"context_line":"                                        old_name\u003dold_name)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def _fix_id_migration(self, context, volume):"},{"line_number":351,"context_line":"            \"\"\"Fix provider_location and dev files to address bug 1065702.\"\"\""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            model_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALn%2F%2F5kE%3D","line":350,"updated":"2012-10-29 22:12:35.000000000","message":"remove extra four spaces on all lines below.","commit_id":"e50a34aedf6eea650def604e730f75a84e604e1e"}]}