)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"13175129c74543c888af4fc8204cc54a64f1ea54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-16 21:26:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes-Bug: pvs-separator-bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pvs separator character of \u0027:\u0027 does not work for names that already"},{"line_number":10,"context_line":"contain \u0027:\u0027. Changed to \u0027|\u0027, which is less likely to conflict."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_ffc88476","line":7,"updated":"2015-01-16 21:58:03.000000000","message":"Please make the summary line a description of what this patch does.","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"e73ec6c26baf42a09cbde82f611398ceb594a1cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-16 21:26:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes-Bug: pvs-separator-bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pvs separator character of \u0027:\u0027 does not work for names that already"},{"line_number":10,"context_line":"contain \u0027:\u0027. Changed to \u0027|\u0027, which is less likely to conflict."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_7f7c94eb","line":7,"in_reply_to":"3a961159_ffc88476","updated":"2015-01-16 22:19:32.000000000","message":"Will rewrite - thanks!","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"13175129c74543c888af4fc8204cc54a64f1ea54","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes-Bug: pvs-separator-bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pvs separator character of \u0027:\u0027 does not work for names that already"},{"line_number":10,"context_line":"contain \u0027:\u0027. Changed to \u0027|\u0027, which is less likely to conflict."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia5442af2a06a004ff1af58ce08b816506b369f22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_9fa780bb","line":10,"updated":"2015-01-16 21:58:03.000000000","message":"Under what circumstances does the pv contain a \u0027:\u0027?","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"e73ec6c26baf42a09cbde82f611398ceb594a1cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes-Bug: pvs-separator-bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pvs separator character of \u0027:\u0027 does not work for names that already"},{"line_number":10,"context_line":"contain \u0027:\u0027. Changed to \u0027|\u0027, which is less likely to conflict."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia5442af2a06a004ff1af58ce08b816506b369f22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_9f56a05c","line":10,"in_reply_to":"3a961159_9fa780bb","updated":"2015-01-16 22:19:32.000000000","message":"See http://paste.openstack.org/show/158024/ for an example.\n\nLooks like there are cases where the underlying disk could be remotely mounted (if I understand correctly - we use iSCSI in our case) and the \u0027:\u0027 can enter into it, as seen in the above paste.\n\nNote that \u0027:\u0027 is also used in get_all_volume_groups() but, per our IRC chat, LVM doesn\u0027t consider \u0027:\u0027 to be valid in a volume group name. Leaving that one alone. :)","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d838c9c1d5cc06e9b8ccb5a95f8b8144aaf68f21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_c676bf05","line":7,"updated":"2015-01-27 06:39:53.000000000","message":"It will be perfect that if you can tell us why you choose \"|\" instead of other characters as the delimiter. \nIs it because \"|\" will never show up in the fields like vg_name, name, etc? It need at a comment here to prove that.\nI am little afraid that taking another delimiter won\u0027t treat the root cause.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"382dbafe295c6a7bcfa453e7b406c39087f903de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_578d08d2","line":7,"in_reply_to":"1a930d6b_064e0797","updated":"2015-01-27 14:48:15.000000000","message":"Small nit for the future: commit messages shouldn\u0027t end in periods.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"3d987e74d922d9eaa6d58930538ca65674efe76c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa81d914_569a3115","line":7,"in_reply_to":"1a930d6b_064e0797","updated":"2015-01-28 01:46:19.000000000","message":"Thx, dude.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8a68abb04ea10d8ac15feece88e15123dd67117","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_c659488f","line":7,"in_reply_to":"1a930d6b_0bea79da","updated":"2015-01-27 16:15:22.000000000","message":"Personally, I think the pipe char is a good choice here.  If that for some reason fails, \nthere are other various options which would be more robust but would require more fancy parsing:\n\n$ pvs --rows --nameprefixes\n\nor\n\n$ pvs --rows --separator \u0027|cinder\u003e\u0027\n\nBut that\u0027s really overkill at this point since AFAICT pipes won\u0027t ever show up in the output here.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"94ded0db3ab7f145beaa1ff8bc4b7c0b17494823","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa81d914_f6e405ae","line":7,"in_reply_to":"1a930d6b_0bea79da","updated":"2015-01-28 01:45:31.000000000","message":"Yeah, that is cool for now. Thx.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"31452fb829ceac31fdeb61b5c586588023b4b0b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_c011305e","line":7,"in_reply_to":"1a930d6b_578d08d2","updated":"2015-01-27 15:46:34.000000000","message":"Appreciated, Eric, thanks! I don\u0027t suppose I should change it now (?). Suspecting no.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8a68abb04ea10d8ac15feece88e15123dd67117","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_66c25454","line":7,"in_reply_to":"1a930d6b_c011305e","updated":"2015-01-27 16:15:22.000000000","message":"Don\u0027t worry about it unless changing this commit for some other reason.","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"31452fb829ceac31fdeb61b5c586588023b4b0b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_0bea79da","line":7,"in_reply_to":"1a930d6b_c676bf05","updated":"2015-01-27 15:46:34.000000000","message":"Hi Vincent! See Anish\u0027s comment for context. Please let me know if that helps.\n\nI suppose I could use a control character. (Tried null. Didn\u0027t work out.) Perhaps a tab?\n\ntbh, I was going to pick the Unicode Snowman to be *extra* extra sure, but thought better of it. :)","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"dacefff279d7cf4967a359d34735270a4055ac6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joe D\u0027Andrea \u003cjdandrea@research.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-26 18:35:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed pvs separator from \u0027:\u0027 to \u0027|\u0027 to support names with \u0027:\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_all_physical_volumes() runs:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a930d6b_064e0797","line":7,"in_reply_to":"1a930d6b_c676bf05","updated":"2015-01-27 06:46:45.000000000","message":"The complete details are in RFC 3721/3722, but I can answer part of this. \u0027:\u0027 is an acceptable component of iqn names, \u0027|\u0027 is not","commit_id":"456a6f81d8da03ef852575e1e6053dae6958dd43"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"15ca45d80e07277efe506e42c15c23961e85d747","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        cmd \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027, \u0027pvs\u0027, \u0027--noheadings\u0027,"},{"line_number":318,"context_line":"               \u0027--unit\u003dg\u0027,"},{"line_number":319,"context_line":"               \u0027-o\u0027, \u0027vg_name,name,size,free\u0027,"},{"line_number":320,"context_line":"               \u0027--separator\u0027, LVM.FIELD_SEP,"},{"line_number":321,"context_line":"               \u0027--nosuffix\u0027]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        (out, _err) \u003d putils.execute(*cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3fe92cab","line":320,"updated":"2015-01-16 22:05:16.000000000","message":"self.FIELD_SEP","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f1c7acc6ef17ac5aecf8fb7da8e0a186c7f10225","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        cmd \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027, \u0027pvs\u0027, \u0027--noheadings\u0027,"},{"line_number":318,"context_line":"               \u0027--unit\u003dg\u0027,"},{"line_number":319,"context_line":"               \u0027-o\u0027, \u0027vg_name,name,size,free\u0027,"},{"line_number":320,"context_line":"               \u0027--separator\u0027, LVM.FIELD_SEP,"},{"line_number":321,"context_line":"               \u0027--nosuffix\u0027]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        (out, _err) \u003d putils.execute(*cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_dfdae8e7","line":320,"in_reply_to":"3a961159_3fe92cab","updated":"2015-01-16 22:12:40.000000000","message":"I think using LVM. is ok since this is a class variable and not an instance variable?","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"e73ec6c26baf42a09cbde82f611398ceb594a1cc","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        cmd \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027, \u0027pvs\u0027, \u0027--noheadings\u0027,"},{"line_number":318,"context_line":"               \u0027--unit\u003dg\u0027,"},{"line_number":319,"context_line":"               \u0027-o\u0027, \u0027vg_name,name,size,free\u0027,"},{"line_number":320,"context_line":"               \u0027--separator\u0027, LVM.FIELD_SEP,"},{"line_number":321,"context_line":"               \u0027--nosuffix\u0027]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        (out, _err) \u003d putils.execute(*cmd,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5f635819","line":320,"in_reply_to":"3a961159_dfdae8e7","updated":"2015-01-16 22:19:32.000000000","message":"Ok! Moving this to a local var, as it\u0027s only needed in one method.","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"508d2c1fa613c33e99a4f168a096fc3b70dc0189","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        pvs \u003d out.split()"},{"line_number":328,"context_line":"        if vg_name is not None:"},{"line_number":329,"context_line":"            pvs \u003d [pv for pv in pvs "},{"line_number":330,"context_line":"                   if vg_name \u003d\u003d pv.split(LVM.FIELD_SEP)[0]]"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        pv_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_bfb35c07","line":329,"updated":"2015-01-16 21:57:29.000000000","message":"trailing whitespace here.","commit_id":"73b08293b6971c059b889dff886595b9398d455c"},{"author":{"_account_id":13134,"name":"Joe D\u0027Andrea","email":"jdandrea@redhat.com","username":"jdandrea"},"change_message_id":"e73ec6c26baf42a09cbde82f611398ceb594a1cc","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        pvs \u003d out.split()"},{"line_number":328,"context_line":"        if vg_name is not None:"},{"line_number":329,"context_line":"            pvs \u003d [pv for pv in pvs "},{"line_number":330,"context_line":"                   if vg_name \u003d\u003d pv.split(LVM.FIELD_SEP)[0]]"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        pv_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9f7ea019","line":329,"in_reply_to":"3a961159_bfb35c07","updated":"2015-01-16 22:19:32.000000000","message":"Gah! I thought I got rid of that. Thank you - good catch.","commit_id":"73b08293b6971c059b889dff886595b9398d455c"}],"cinder/tests/test_srb.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"47a3cca5e4f207719becd1982d779f75baffd89f","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        return check, act"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def _fake_get_all_physical_volumes(self):"},{"line_number":433,"context_line":"        def check(cmd_string):"},{"line_number":434,"context_line":"            return \u0027env, LC_ALL\u003dC, pvs, --noheadings, --unit\u003dg, \u0027 \\"},{"line_number":435,"context_line":"                \u0027-o, vg_name,name,size,free, --separator, |, \u0027 \\"},{"line_number":436,"context_line":"                \u0027--nosuffix\u0027 in cmd_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_bd6c74d1","line":433,"updated":"2015-01-26 18:33:20.000000000","message":"Fixing this test up here is good for this patch, but this is kind of unfortunate.  Tests for the srb driver should mock out calls to brick, not reproduce all of its command strings.","commit_id":"ead6e8fc207e8650a926f516588d613c361890db"}]}