)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Keeping this \"Cinder\" only alleviates concerns that other may be"},{"line_number":32,"context_line":"using the system of \"other\" LVM purposes that the global conf setting"},{"line_number":33,"context_line":"would break them."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Going forward there may some opportunities to auto-generate the"},{"line_number":36,"context_line":"filters we want (ie: take the VG for a driver instance, get it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_8b53ad6b","line":33,"updated":"2015-01-20 20:04:47.000000000","message":"This paragraph is confusing.  Do you mean:\n\nKeeping this \"Cinder\" only alleviates concerns that others may be\nusing the system for \"other\" LVM purposes and that changing the global conf setting would break them.","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Keeping this \"Cinder\" only alleviates concerns that other may be"},{"line_number":32,"context_line":"using the system of \"other\" LVM purposes that the global conf setting"},{"line_number":33,"context_line":"would break them."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Going forward there may some opportunities to auto-generate the"},{"line_number":36,"context_line":"filters we want (ie: take the VG for a driver instance, get it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_74ed7e8b","line":33,"in_reply_to":"1a930d6b_8b53ad6b","updated":"2015-01-20 21:52:30.000000000","message":"Must not be that confusing.. you seem to understand just fine","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Going forward there may some opportunities to auto-generate the"},{"line_number":36,"context_line":"filters we want (ie: take the VG for a driver instance, get it\u0027s"},{"line_number":37,"context_line":"PV\u0027s and write them to the filter), but for now the creation and"},{"line_number":38,"context_line":"configuration of the lvm.conf file is left as a seperate task."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We\u0027ll update the OpenStack Devstack deployment scripts to put this"},{"line_number":41,"context_line":"together and fix things up there first. Until that\u0027s done and until"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_cb4db5c6","line":38,"updated":"2015-01-20 20:04:47.000000000","message":"seperate -\u003e separate","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Going forward there may some opportunities to auto-generate the"},{"line_number":36,"context_line":"filters we want (ie: take the VG for a driver instance, get it\u0027s"},{"line_number":37,"context_line":"PV\u0027s and write them to the filter), but for now the creation and"},{"line_number":38,"context_line":"configuration of the lvm.conf file is left as a seperate task."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We\u0027ll update the OpenStack Devstack deployment scripts to put this"},{"line_number":41,"context_line":"together and fix things up there first. Until that\u0027s done and until"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_d4fb9245","line":38,"in_reply_to":"1a930d6b_cb4db5c6","updated":"2015-01-20 21:52:30.000000000","message":"Done","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":52,"context_line":"avoid any possible issues with compatability issues between"},{"line_number":53,"context_line":"platforms or versions."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"To use, just copy the sytems /etc/lvm/lvm.conf file to /etc/cinder and"},{"line_number":56,"context_line":"modify the filter as appropriate, for example:"},{"line_number":57,"context_line":"  To use loopback device only:"},{"line_number":58,"context_line":"    filter \u003d [ \"a/loop/\", \"r/.*/\" ]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_8bdacde7","line":55,"updated":"2015-01-20 20:04:47.000000000","message":"systems -\u003e system\u0027s","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":52,"context_line":"avoid any possible issues with compatability issues between"},{"line_number":53,"context_line":"platforms or versions."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"To use, just copy the sytems /etc/lvm/lvm.conf file to /etc/cinder and"},{"line_number":56,"context_line":"modify the filter as appropriate, for example:"},{"line_number":57,"context_line":"  To use loopback device only:"},{"line_number":58,"context_line":"    filter \u003d [ \"a/loop/\", \"r/.*/\" ]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_14951ae4","line":55,"in_reply_to":"1a930d6b_8bdacde7","updated":"2015-01-20 21:52:30.000000000","message":"Seriously?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        exists \u003d False"},{"line_number":106,"context_line":"        (out, _err) \u003d self._execute("},{"line_number":107,"context_line":"            \u0027env\u0027, \u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027,"},{"line_number":108,"context_line":"            \u0027LC_ALL\u003dC\u0027, \u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027,"},{"line_number":109,"context_line":"            self.vg_name, root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_eb8fd1ca","line":107,"updated":"2015-01-20 20:04:47.000000000","message":"Given the number of places that this is used, do we want to put it in a Global Variable or in a configuration item in the case that we need to change this in the future?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        exists \u003d False"},{"line_number":106,"context_line":"        (out, _err) \u003d self._execute("},{"line_number":107,"context_line":"            \u0027env\u0027, \u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027,"},{"line_number":108,"context_line":"            \u0027LC_ALL\u003dC\u0027, \u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027,"},{"line_number":109,"context_line":"            self.vg_name, root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_df4acb54","line":107,"in_reply_to":"1a930d6b_eb8fd1ca","updated":"2015-01-20 21:52:30.000000000","message":"Considered that, however that makes things interesting with the rootwrap, also should consider the same for things like LC_ALL and --noheadings etc as pointed out in commit message.","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"666eaa3850163fa8cf6de0899647d56ffef41b08","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            vgs \u003d out.split()"},{"line_number":382,"context_line":"            for vg in vgs:"},{"line_number":383,"context_line":"                fields \u003d vg.split(\u0027:\u0027)"},{"line_number":384,"context_line":"                if vg_name is None or vg_name in fields[0]:"},{"line_number":385,"context_line":"                    vg_list.append({\u0027name\u0027: fields[0],"},{"line_number":386,"context_line":"                                    \u0027size\u0027: float(fields[1]),"},{"line_number":387,"context_line":"                                    \u0027available\u0027: float(fields[2]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_7d444a19","line":384,"updated":"2015-01-20 19:04:14.000000000","message":"Not sure why this change is required, but it doesn\u0027t seem to be mentioned in the commit message?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            vgs \u003d out.split()"},{"line_number":382,"context_line":"            for vg in vgs:"},{"line_number":383,"context_line":"                fields \u003d vg.split(\u0027:\u0027)"},{"line_number":384,"context_line":"                if vg_name is None or vg_name in fields[0]:"},{"line_number":385,"context_line":"                    vg_list.append({\u0027name\u0027: fields[0],"},{"line_number":386,"context_line":"                                    \u0027size\u0027: float(fields[1]),"},{"line_number":387,"context_line":"                                    \u0027available\u0027: float(fields[2]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_bf925f9d","line":384,"in_reply_to":"3a961159_7d444a19","updated":"2015-01-20 21:52:30.000000000","message":"Nice eye :)\n\nSo I changed it because frankly I couldn\u0027t figure how the hell the srb test was working and was sick of messing with it, so I hacked the check in here to solve the problem.\n\nNow that you\u0027ve caught me and pointed out I\u0027m surely doomed.","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"}],"cinder/tests/test_srb.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.vg.set_execute(executor)"},{"line_number":104,"context_line":"        thin_calc \u003d\\"},{"line_number":105,"context_line":"            mock.MagicMock("},{"line_number":106,"context_line":"                side_effect\u003dException("},{"line_number":107,"context_line":"                    \u0027Unexpected call to _calculate_thin_pool_size\u0027))"},{"line_number":108,"context_line":"        self.vg._calculate_thin_pool_size \u003d thin_calc"},{"line_number":109,"context_line":"        self.vg.extend_thin_pool()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_6b7201e7","line":106,"updated":"2015-01-20 20:04:47.000000000","message":"Why was this change made?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.vg.set_execute(executor)"},{"line_number":104,"context_line":"        thin_calc \u003d\\"},{"line_number":105,"context_line":"            mock.MagicMock("},{"line_number":106,"context_line":"                side_effect\u003dException("},{"line_number":107,"context_line":"                    \u0027Unexpected call to _calculate_thin_pool_size\u0027))"},{"line_number":108,"context_line":"        self.vg._calculate_thin_pool_size \u003d thin_calc"},{"line_number":109,"context_line":"        self.vg.extend_thin_pool()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1fd0d352","line":106,"in_reply_to":"1a930d6b_6b7201e7","updated":"2015-01-20 21:52:30.000000000","message":"because my version of pep8 complains about the formatting they had here, so I fixed it to make it go away.  Are we not allowed to reformat lines?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e4ec9b4e6fc05dd4fe80ff7d29b2e65ce81e9957","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        ]"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # I wonder if you could\u0027ve come up with a more complex"},{"line_number":724,"context_line":"        # and difficult to maintain solution?  I\u0027m betting not"},{"line_number":725,"context_line":"        for (check, act) in handlers:"},{"line_number":726,"context_line":"            if check(cmd_string):"},{"line_number":727,"context_line":"                out \u003d act(cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_0b317d0b","line":724,"updated":"2015-01-20 20:04:47.000000000","message":"Did you really mean to leave this here?","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"caa29fd8a4eade44a8e4c58a734b2ac991be8024","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        ]"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # I wonder if you could\u0027ve come up with a more complex"},{"line_number":724,"context_line":"        # and difficult to maintain solution?  I\u0027m betting not"},{"line_number":725,"context_line":"        for (check, act) in handlers:"},{"line_number":726,"context_line":"            if check(cmd_string):"},{"line_number":727,"context_line":"                out \u003d act(cmd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5f417b0a","line":724,"in_reply_to":"1a930d6b_0b317d0b","updated":"2015-01-20 21:52:30.000000000","message":"yes, I REALLY did... This is in fact the \"nice\" version of the comment I had written prior to submitting.","commit_id":"4307f16af8976aaa1657c8439086eed4130b229e"}]}