)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"dc376de18272a448f05f4b832ee406496d80d70f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        exists \u003d False"},{"line_number":112,"context_line":"        cmd \u003d copy.copy(LVM_CMD_PREFIX)"},{"line_number":113,"context_line":"        cmd.extend([\u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027, self.vg_name])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        (out, _err) \u003d self._execute(*cmd,"},{"line_number":116,"context_line":"                                    root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_97ff0c67","line":113,"updated":"2015-01-22 13:10:46.000000000","message":"I think it might be more idiomatic to write this as:\n\ncmd \u003d LVM_CMD_PREFIX + [\u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027, self.vg_name]\n\nand then you wouldn\u0027t need to import the copy module.\n\nWhat do you think?\n\n(Obviously, if you agree, similarly for all the other cases too.)","commit_id":"36ce96e7fdbe94009d5b1886bae36c1ad873a2cb"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"cc22eafa2079415292b8abd0a067c6af7429f7e8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        exists \u003d False"},{"line_number":112,"context_line":"        cmd \u003d copy.copy(LVM_CMD_PREFIX)"},{"line_number":113,"context_line":"        cmd.extend([\u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027, self.vg_name])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        (out, _err) \u003d self._execute(*cmd,"},{"line_number":116,"context_line":"                                    root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_49e16fcf","line":113,"in_reply_to":"1a930d6b_97ff0c67","updated":"2015-01-29 05:05:28.000000000","message":"problem with that is that if you use the append like that you\u0027ll update the global, that\u0027s why I forced the local var of it with copy.copy","commit_id":"36ce96e7fdbe94009d5b1886bae36c1ad873a2cb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"30318b65e7b3bfbbec083264b9ee301dea3a7993","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"LVM_CMD_PREFIX \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class LVM(executor.Executor):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_076869b9","line":37,"updated":"2015-02-02 11:16:38.000000000","message":"I don\u0027t see any reason to not make this an instance var in LVM(), as self.LVM_CMD_PREFIX.\n\nWith brick aiming to be a library, this would be cleaner.","commit_id":"b78287e7dcf4fed54d1cce0036c1dfb8c6c36ee6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"93eb7ef8d87d474b5c69e34e80c4fffd4d1e2782","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"LVM_CMD_PREFIX \u003d [\u0027env\u0027, \u0027LC_ALL\u003dC\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class LVM(executor.Executor):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a2f22298","line":37,"in_reply_to":"da86d52c_076869b9","updated":"2015-02-02 15:13:36.000000000","message":"The problem is that won\u0027t work on the static methods in this class.  Unless there\u0027s another way to go about it which then I\u0027m open.  Initially I was going to do exactly as you suggest, but the static methods then won\u0027t pick the var up.","commit_id":"b78287e7dcf4fed54d1cce0036c1dfb8c6c36ee6"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"da9c8b3d309d52d896bd2b310676057f46648b8d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"LVM class for performing LVM operations."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import copy"},{"line_number":21,"context_line":"import itertools"},{"line_number":22,"context_line":"import math"},{"line_number":23,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_80518810","line":20,"updated":"2015-02-02 19:15:09.000000000","message":"Please delete; this import isn\u0027t needed.","commit_id":"cb98f1d3340b79efc39ed8d9d741ff4c7f6f542d"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"da9c8b3d309d52d896bd2b310676057f46648b8d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":"        exists \u003d False"},{"line_number":115,"context_line":"        cmd \u003d copy.copy(LVM.LVM_CMD_PREFIX)"},{"line_number":116,"context_line":"        cmd.extend([\u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027, self.vg_name])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        (out, _err) \u003d self._execute(*cmd,"},{"line_number":119,"context_line":"                                    root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c072a0ac","line":116,"updated":"2015-02-02 19:15:09.000000000","message":"Simplify:\n\ncmd \u003d LVM.LVM_CMD_PREFIX + [\u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027, self.vg_name]\n\n+ similarly for all following cases where change currently uses copy.copy and .extend.","commit_id":"cb98f1d3340b79efc39ed8d9d741ff4c7f6f542d"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"2acf2d318ed9e7acf3517ad473b92d148e316f02","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":103,"context_line":"            LVM.LVM_CMD_PREFIX \u003d [\u0027env\u0027,"},{"line_number":104,"context_line":"                                  \u0027LC_ALL\u003dC\u0027,"},{"line_number":105,"context_line":"                                  \u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _vg_exists(self):"},{"line_number":108,"context_line":"        \"\"\"Simple check to see if VG exists."}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b3d6dac1","line":105,"updated":"2015-02-03 03:31:26.000000000","message":"Wouldn\u0027t it be better to use LVM.LVM_CMD_PREFIX.append?\u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027)?","commit_id":"eb7bb3e08c1b8e1008ba447b842b635821e2097e"}]}