)]}'
{"cinder/volume/flows/manager/initialize_connection.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"1e4e052076b027c2801f193934c670c30b490bc7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            self.driver.validate_connector(connector)"},{"line_number":54,"context_line":"        except Exception as err:"},{"line_number":55,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":56,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":57,"context_line":"            LOG.error(err_msg)"},{"line_number":58,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ed796efd","line":55,"updated":"2015-01-22 07:40:00.000000000","message":"This message should be localized with _LE.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"1e4e052076b027c2801f193934c670c30b490bc7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            model_update \u003d self.driver.create_export(context.elevated(),"},{"line_number":80,"context_line":"                                                     volume_ref)"},{"line_number":81,"context_line":"        except exception.CinderException:"},{"line_number":82,"context_line":"            err_msg \u003d (_(\u0027Unable to create export for volume %(volume_id)s.\u0027)"},{"line_number":83,"context_line":"                       % {\u0027volume_id\u0027: volume_id})"},{"line_number":84,"context_line":"            LOG.exception(err_msg)"},{"line_number":85,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_6df81e7d","line":82,"updated":"2015-01-22 07:40:00.000000000","message":"This message should be localized with _LE.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aedf000384ceb78539c14f55ecb5895e4724b614","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            except exception.CinderException as ex:"},{"line_number":93,"context_line":"                LOG.exception(_LE(\"Failed updating model of volume \""},{"line_number":94,"context_line":"                                  \"%(volume_id)s with driver provided model \""},{"line_number":95,"context_line":"                                  \"%(model)s.\") % {\u0027volume_id\u0027: volume_id,"},{"line_number":96,"context_line":"                                                   \u0027model\u0027: model_update})"},{"line_number":97,"context_line":"                raise exception.ExportFailure(reason\u003dex)"},{"line_number":98,"context_line":"        return volume_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_352039f7","line":95,"updated":"2015-01-21 15:00:42.000000000","message":"Please use , instead of % if the string is only going to a log call.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"1e4e052076b027c2801f193934c670c30b490bc7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return self.driver.initialize_connection(volume_ref,"},{"line_number":122,"context_line":"                                                     connector)"},{"line_number":123,"context_line":"        except Exception as err:"},{"line_number":124,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":125,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":126,"context_line":"            LOG.error(err_msg)"},{"line_number":127,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ed124eb3","line":124,"updated":"2015-01-22 07:40:00.000000000","message":"This message should be localized with _LE.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aedf000384ceb78539c14f55ecb5895e4724b614","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        if type_id:"},{"line_number":148,"context_line":"            res \u003d volume_types.get_volume_type_qos_specs(type_id)"},{"line_number":149,"context_line":"            qos \u003d res[\u0027qos_specs\u0027]"},{"line_number":150,"context_line":"            # only pass qos_specs that is designated to be consumed by"},{"line_number":151,"context_line":"            # front-end, or both front-end and back-end."},{"line_number":152,"context_line":"            if qos and qos.get(\u0027consumer\u0027) in [\u0027front-end\u0027, \u0027both\u0027]:"},{"line_number":153,"context_line":"                specs \u003d qos.get(\u0027specs\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_5574e5fc","line":150,"updated":"2015-01-21 15:00:42.000000000","message":"Start comments uppercase.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"3151d09746e6f9b87e421a8737953da58aa90c71","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            self.driver.validate_connector(connector)"},{"line_number":54,"context_line":"        except Exception as err:"},{"line_number":55,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":56,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":57,"context_line":"            LOG.error(err_msg)"},{"line_number":58,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ec86e8b9","line":55,"updated":"2015-03-17 07:32:50.000000000","message":"Please put _LE before the message.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4c797eaa7d57f23490ecc84109020d0500faf183","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            self.driver.validate_connector(connector)"},{"line_number":54,"context_line":"        except Exception as err:"},{"line_number":55,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":56,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":57,"context_line":"            LOG.error(err_msg)"},{"line_number":58,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e76523e3","line":55,"in_reply_to":"9a80dd14_ec86e8b9","updated":"2015-03-17 07:46:32.000000000","message":"_() is actually correct since this message is being used in the VolumeBackendAPIException.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"3151d09746e6f9b87e421a8737953da58aa90c71","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            model_update \u003d self.driver.create_export(context.elevated(),"},{"line_number":80,"context_line":"                                                     volume_ref)"},{"line_number":81,"context_line":"        except exception.CinderException:"},{"line_number":82,"context_line":"            err_msg \u003d (_(\u0027Unable to create export for volume %(volume_id)s.\u0027)"},{"line_number":83,"context_line":"                       % {\u0027volume_id\u0027: volume_id})"},{"line_number":84,"context_line":"            LOG.exception(err_msg)"},{"line_number":85,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_0c841cb0","line":82,"updated":"2015-03-17 07:32:50.000000000","message":"Please put _LE before the message.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4c797eaa7d57f23490ecc84109020d0500faf183","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            model_update \u003d self.driver.create_export(context.elevated(),"},{"line_number":80,"context_line":"                                                     volume_ref)"},{"line_number":81,"context_line":"        except exception.CinderException:"},{"line_number":82,"context_line":"            err_msg \u003d (_(\u0027Unable to create export for volume %(volume_id)s.\u0027)"},{"line_number":83,"context_line":"                       % {\u0027volume_id\u0027: volume_id})"},{"line_number":84,"context_line":"            LOG.exception(err_msg)"},{"line_number":85,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_27b73b3c","line":82,"in_reply_to":"9a80dd14_0c841cb0","updated":"2015-03-17 07:46:32.000000000","message":"_() is correct.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"11dd70e89287f5060bb1307eb2aac78e2f44555f","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if model_update:"},{"line_number":88,"context_line":"            try:"},{"line_number":89,"context_line":"                volume_ref \u003d self.db.volume_update(context,"},{"line_number":90,"context_line":"                                                   volume_id,"},{"line_number":91,"context_line":"                                                   model_update)"},{"line_number":92,"context_line":"            except exception.CinderException as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_95ba7b21","line":89,"updated":"2015-01-23 12:20:08.000000000","message":"I guess the revert should undo this volume_update?  No idea how though...","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"11dd70e89287f5060bb1307eb2aac78e2f44555f","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def execute(self, volume_ref, connector):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            return self.driver.initialize_connection(volume_ref,"},{"line_number":122,"context_line":"                                                     connector)"},{"line_number":123,"context_line":"        except Exception as err:"},{"line_number":124,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_157e8b6b","line":121,"updated":"2015-01-23 12:20:08.000000000","message":"Should we have a revert here that calls terminate_connection?","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"3151d09746e6f9b87e421a8737953da58aa90c71","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                                     connector)"},{"line_number":123,"context_line":"        except Exception as err:"},{"line_number":124,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":125,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":126,"context_line":"            LOG.error(err_msg)"},{"line_number":127,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_4c8e14d2","line":125,"updated":"2015-03-17 07:32:50.000000000","message":"Please put _LE before the message.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4c797eaa7d57f23490ecc84109020d0500faf183","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                                     connector)"},{"line_number":123,"context_line":"        except Exception as err:"},{"line_number":124,"context_line":"            err_msg \u003d (_(\u0027Unable to fetch connection information from \u0027"},{"line_number":125,"context_line":"                         \u0027backend: %(err)s.\u0027) % {\u0027err\u0027: err})"},{"line_number":126,"context_line":"            LOG.error(err_msg)"},{"line_number":127,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_27601bcf","line":125,"in_reply_to":"9a80dd14_4c8e14d2","updated":"2015-03-17 07:46:32.000000000","message":"_() is correct.\n\nSince string formatting is being done directly here though you will need to put err inside six.text_type(err). Otherwise this could cause a Unicode exception.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"}],"cinder/volume/manager.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"1e4e052076b027c2801f193934c670c30b490bc7","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                                         self.driver,"},{"line_number":893,"context_line":"                                                         create_what)"},{"line_number":894,"context_line":"        except Exception:"},{"line_number":895,"context_line":"            msg \u003d _(\"Failed to create initialize connection flow.\")"},{"line_number":896,"context_line":"            LOG.exception(msg)"},{"line_number":897,"context_line":"            raise exception.CinderException(msg)"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_2d8456d3","line":895,"updated":"2015-01-22 07:40:00.000000000","message":"This message should be localized with _LE.","commit_id":"7bdbe345be92ecaf04185d9c0f3d5cc5c6d0ec2f"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"3151d09746e6f9b87e421a8737953da58aa90c71","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                                         self.driver,"},{"line_number":893,"context_line":"                                                         create_what)"},{"line_number":894,"context_line":"        except Exception:"},{"line_number":895,"context_line":"            msg \u003d _(\"Failed to create initialize connection flow.\")"},{"line_number":896,"context_line":"            LOG.exception(msg)"},{"line_number":897,"context_line":"            raise exception.CinderException(msg)"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ac9dd00c","line":895,"updated":"2015-03-17 07:32:50.000000000","message":"Please put _LE before the message.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4c797eaa7d57f23490ecc84109020d0500faf183","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                                         self.driver,"},{"line_number":893,"context_line":"                                                         create_what)"},{"line_number":894,"context_line":"        except Exception:"},{"line_number":895,"context_line":"            msg \u003d _(\"Failed to create initialize connection flow.\")"},{"line_number":896,"context_line":"            LOG.exception(msg)"},{"line_number":897,"context_line":"            raise exception.CinderException(msg)"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8785475b","line":895,"in_reply_to":"9a80dd14_ac9dd00c","updated":"2015-03-17 07:46:32.000000000","message":"msg is used for logging as well as the exception, so _() is correct.","commit_id":"cffd8cb87d340911b12c13996f0960732c4f66c0"}]}