)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ba8e9ab2df61b5524b92031eb9392684a602bb8b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ca cert option to backups swift driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the option in volume backups swift driver"},{"line_number":10,"context_line":"to specify a ca cert file"},{"line_number":11,"context_line":"Closes-Bug: 1413945"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibcfe220d35cbb5369679a1ff51fffd41f16c9909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_2ecb3154","line":10,"updated":"2015-01-23 15:31:59.000000000","message":"Please add a newline between here.  Makes it more readable :)","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"ad1de8d6a3abe7a5fe1aeb6b49b522718053a3fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ca cert option to backups swift driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the option in volume backups swift driver"},{"line_number":10,"context_line":"to specify a ca cert file"},{"line_number":11,"context_line":"Closes-Bug: 1413945"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibcfe220d35cbb5369679a1ff51fffd41f16c9909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_3b3d2cbc","line":10,"in_reply_to":"1a930d6b_2ecb3154","updated":"2015-01-23 16:43:10.000000000","message":"Done","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ba8e9ab2df61b5524b92031eb9392684a602bb8b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the option in volume backups swift driver"},{"line_number":10,"context_line":"to specify a ca cert file"},{"line_number":11,"context_line":"Closes-Bug: 1413945"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibcfe220d35cbb5369679a1ff51fffd41f16c9909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_53e3c604","line":11,"updated":"2015-01-23 15:31:59.000000000","message":"Should add a \"DocImpact\", since you added a new option.","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"ad1de8d6a3abe7a5fe1aeb6b49b522718053a3fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the option in volume backups swift driver"},{"line_number":10,"context_line":"to specify a ca cert file"},{"line_number":11,"context_line":"Closes-Bug: 1413945"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibcfe220d35cbb5369679a1ff51fffd41f16c9909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_dbdee83e","line":11,"in_reply_to":"1a930d6b_53e3c604","updated":"2015-01-23 16:43:10.000000000","message":"Done","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"}],"cinder/backup/drivers/swift.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ba8e9ab2df61b5524b92031eb9392684a602bb8b","unresolved":false,"context_lines":[{"line_number":29,"context_line":":backup_compression_algorithm: Compression algorithm to use for volume"},{"line_number":30,"context_line":"                               backups. Supported options are:"},{"line_number":31,"context_line":"                               None (to disable), zlib and bz2 (default: zlib)"},{"line_number":32,"context_line":":backup_swift_ca_cert_file: The location of the ca certificate file to use"},{"line_number":33,"context_line":"                            for swift client requests (default: None)"},{"line_number":34,"context_line":"\"\"\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ee9a0962","line":32,"updated":"2015-01-23 15:31:59.000000000","message":"s/CA certificate/CA certificate/","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"ad1de8d6a3abe7a5fe1aeb6b49b522718053a3fc","unresolved":false,"context_lines":[{"line_number":29,"context_line":":backup_compression_algorithm: Compression algorithm to use for volume"},{"line_number":30,"context_line":"                               backups. Supported options are:"},{"line_number":31,"context_line":"                               None (to disable), zlib and bz2 (default: zlib)"},{"line_number":32,"context_line":":backup_swift_ca_cert_file: The location of the ca certificate file to use"},{"line_number":33,"context_line":"                            for swift client requests (default: None)"},{"line_number":34,"context_line":"\"\"\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_855ec310","line":32,"in_reply_to":"1a930d6b_ee9a0962","updated":"2015-01-23 16:43:10.000000000","message":"Done","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ba8e9ab2df61b5524b92031eb9392684a602bb8b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                     \u0027default value is True to enable the timer.\u0027),"},{"line_number":107,"context_line":"    cfg.StrOpt(\u0027backup_swift_ca_cert_file\u0027,"},{"line_number":108,"context_line":"               default\u003dNone,"},{"line_number":109,"context_line":"               help\u003d\u0027Location of ca certificates file to use for swift \u0027"},{"line_number":110,"context_line":"                    \u0027client requests\u0027),"},{"line_number":111,"context_line":"]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_2e96d14c","line":109,"updated":"2015-01-23 15:31:59.000000000","message":"s/CA certificates/CA certificate/","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"ad1de8d6a3abe7a5fe1aeb6b49b522718053a3fc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                     \u0027default value is True to enable the timer.\u0027),"},{"line_number":107,"context_line":"    cfg.StrOpt(\u0027backup_swift_ca_cert_file\u0027,"},{"line_number":108,"context_line":"               default\u003dNone,"},{"line_number":109,"context_line":"               help\u003d\u0027Location of ca certificates file to use for swift \u0027"},{"line_number":110,"context_line":"                    \u0027client requests\u0027),"},{"line_number":111,"context_line":"]"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_a5d1ff58","line":109,"in_reply_to":"1a930d6b_2e96d14c","updated":"2015-01-23 16:43:10.000000000","message":"Done","commit_id":"f2e13bbea5ae04479acaf984c5d8787be503d917"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cdea0ca586a946a5e1db2fbd81cef9f7ecca5894","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    cfg.StrOpt(\u0027backup_swift_ca_cert_file\u0027,"},{"line_number":108,"context_line":"               default\u003dNone,"},{"line_number":109,"context_line":"               help\u003d\u0027Location of the CA certificate file to use for swift \u0027"},{"line_number":110,"context_line":"                    \u0027client requests\u0027),"},{"line_number":111,"context_line":"]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_967a77ef","line":110,"updated":"2015-01-23 17:14:50.000000000","message":"Suggest ending this with a \u0027.\u0027","commit_id":"4c545ee8f89cc930ba52b00340b93e35290be7d4"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"9c3f0e18e99417ef2569d0c69503bdeec9c4d3b9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    cfg.StrOpt(\u0027backup_swift_ca_cert_file\u0027,"},{"line_number":108,"context_line":"               default\u003dNone,"},{"line_number":109,"context_line":"               help\u003d\u0027Location of the CA certificate file to use for swift \u0027"},{"line_number":110,"context_line":"                    \u0027client requests\u0027),"},{"line_number":111,"context_line":"]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_f808a629","line":110,"in_reply_to":"1a930d6b_967a77ef","updated":"2015-01-27 13:56:06.000000000","message":"Done","commit_id":"4c545ee8f89cc930ba52b00340b93e35290be7d4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cdea0ca586a946a5e1db2fbd81cef9f7ecca5894","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                key\u003dCONF.backup_swift_key,"},{"line_number":187,"context_line":"                retries\u003dself.swift_attempts,"},{"line_number":188,"context_line":"                starting_backoff\u003dself.swift_backoff,"},{"line_number":189,"context_line":"                cacert\u003dCONF.backup_swift_ca_cert_file)"},{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            self.conn \u003d swift.Connection(retries\u003dself.swift_attempts,"},{"line_number":192,"context_line":"                                         preauthurl\u003dself.swift_url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_d6e95f81","line":189,"updated":"2015-01-23 17:14:50.000000000","message":"What happens here if the file that input file is not accessible?  I think it would be best if we did some input verification and returned an error if the file isn\u0027t accessible.","commit_id":"4c545ee8f89cc930ba52b00340b93e35290be7d4"},{"author":{"_account_id":4961,"name":"francis-moorehead","email":"francis.moorehead@hp.com","username":"francis-moorehead"},"change_message_id":"9c3f0e18e99417ef2569d0c69503bdeec9c4d3b9","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                key\u003dCONF.backup_swift_key,"},{"line_number":187,"context_line":"                retries\u003dself.swift_attempts,"},{"line_number":188,"context_line":"                starting_backoff\u003dself.swift_backoff,"},{"line_number":189,"context_line":"                cacert\u003dCONF.backup_swift_ca_cert_file)"},{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            self.conn \u003d swift.Connection(retries\u003dself.swift_attempts,"},{"line_number":192,"context_line":"                                         preauthurl\u003dself.swift_url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_7854b6c9","line":189,"in_reply_to":"1a930d6b_d6e95f81","updated":"2015-01-27 13:56:06.000000000","message":"If the file is not accessible then the requests library will throw an exception (SSLError: [Errno 2] No such file or directory) and the backup is put into the error state. \n\nI think it is cleaner to let the requests library handle this than adding checking in the swift driver which may unnecessarily clutter the code.","commit_id":"4c545ee8f89cc930ba52b00340b93e35290be7d4"}]}