)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1e3a26d1db1bc23455e1da428372997ed6089fad","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Also use nas_mount_options to replace"},{"line_number":22,"context_line":"nfs_mount_options."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements blueprint: remotefs-cfg-improvements"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ic72ae6c7fdd2c6a7fea27152f27c6521a561977b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_a539dbd8","line":24,"updated":"2015-01-26 05:59:29.000000000","message":"This should be remotefs-share-cfg-improvements\n\nhttps://blueprints.launchpad.net/cinder/+spec/remotefs-share-cfg-improvements","commit_id":"5faedf045a128194bf0e5380add3fac364210f36"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c75e1e32afc8c9e6a18fb352a1825821e5c627b2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Also use nas_mount_options to replace"},{"line_number":22,"context_line":"nfs_mount_options."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Implements blueprint: remotefs-cfg-improvements"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ic72ae6c7fdd2c6a7fea27152f27c6521a561977b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a930d6b_3c1a547d","line":24,"in_reply_to":"1a930d6b_a539dbd8","updated":"2015-01-26 14:33:34.000000000","message":"Whoops, thanks.","commit_id":"5faedf045a128194bf0e5380add3fac364210f36"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RemoteFS: Use nas_ip and nas_share_path options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This replaces the \u003cx\u003efs_share_config file configuration"},{"line_number":10,"context_line":"options with the existing nas_ip option and new"},{"line_number":11,"context_line":"nas_share_path and nas_mount_options configuration"},{"line_number":12,"context_line":"options."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da86d52c_81140e45","line":9,"updated":"2015-02-03 12:20:46.000000000","message":"\u003cx\u003efs_shares_config","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RemoteFS: Use nas_ip and nas_share_path options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This replaces the \u003cx\u003efs_share_config file configuration"},{"line_number":10,"context_line":"options with the existing nas_ip option and new"},{"line_number":11,"context_line":"nas_share_path and nas_mount_options configuration"},{"line_number":12,"context_line":"options."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da86d52c_9e029f09","line":9,"in_reply_to":"da86d52c_81140e45","updated":"2015-02-03 16:31:21.000000000","message":"Done","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the nas_ip and nas_share_path options are set, they"},{"line_number":18,"context_line":"are used.  If not, the previous configuration mechanism,"},{"line_number":19,"context_line":"based on loading a set of shares from a file configured"},{"line_number":20,"context_line":"by \u003cx\u003efs_share_config will be used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Also use nas_mount_options to replace"},{"line_number":23,"context_line":"nfs_mount_options for consistency.  If nas_mount_options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da86d52c_014f3e6c","line":20,"updated":"2015-02-03 12:20:46.000000000","message":"same","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the nas_ip and nas_share_path options are set, they"},{"line_number":18,"context_line":"are used.  If not, the previous configuration mechanism,"},{"line_number":19,"context_line":"based on loading a set of shares from a file configured"},{"line_number":20,"context_line":"by \u003cx\u003efs_share_config will be used."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Also use nas_mount_options to replace"},{"line_number":23,"context_line":"nfs_mount_options for consistency.  If nas_mount_options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da86d52c_e103fc0a","line":20,"in_reply_to":"da86d52c_014f3e6c","updated":"2015-02-03 16:31:21.000000000","message":"Done","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"}],"cinder/tests/test_netapp_nfs.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    configuration.append_config_values(mox.IgnoreArg())"},{"line_number":65,"context_line":"    configuration.nfs_mount_point_base \u003d \u0027/mnt/test\u0027"},{"line_number":66,"context_line":"    configuration.nfs_mount_options \u003d None"},{"line_number":67,"context_line":"    configuration.nas_mount_options \u003d None"},{"line_number":68,"context_line":"    configuration.netapp_server_hostname \u003d CONNECTION_INFO[\u0027hostname\u0027]"},{"line_number":69,"context_line":"    configuration.netapp_transport_type \u003d CONNECTION_INFO[\u0027transport_type\u0027]"},{"line_number":70,"context_line":"    configuration.netapp_server_port \u003d CONNECTION_INFO[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_8197ae8f","line":67,"updated":"2015-02-03 12:20:46.000000000","message":"Any reason why nas_ip and nas_share_path are not set here like in the others?","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    configuration.append_config_values(mox.IgnoreArg())"},{"line_number":65,"context_line":"    configuration.nfs_mount_point_base \u003d \u0027/mnt/test\u0027"},{"line_number":66,"context_line":"    configuration.nfs_mount_options \u003d None"},{"line_number":67,"context_line":"    configuration.nas_mount_options \u003d None"},{"line_number":68,"context_line":"    configuration.netapp_server_hostname \u003d CONNECTION_INFO[\u0027hostname\u0027]"},{"line_number":69,"context_line":"    configuration.netapp_transport_type \u003d CONNECTION_INFO[\u0027transport_type\u0027]"},{"line_number":70,"context_line":"    configuration.netapp_server_port \u003d CONNECTION_INFO[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_be4be385","line":67,"in_reply_to":"da86d52c_8197ae8f","updated":"2015-02-03 16:31:21.000000000","message":"NetApp drivers use the parameters below for server information rather than nas_ip and nas_share_path, so it isn\u0027t required.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"}],"cinder/tests/test_nfs.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        self.configuration.nfs_mount_point_base \u003d self.TEST_MNT_POINT_BASE"},{"line_number":370,"context_line":"        self.configuration.nfs_mount_options \u003d None"},{"line_number":371,"context_line":"        self.configuration.nfs_mount_attempts \u003d 3"},{"line_number":372,"context_line":"        self.configuration.nfs_qcow2_volumes \u003d False"},{"line_number":373,"context_line":"        self.configuration.nas_secure_file_permissions \u003d \u0027false\u0027"},{"line_number":374,"context_line":"        self.configuration.nas_secure_file_operations \u003d \u0027false\u0027"},{"line_number":375,"context_line":"        self.configuration.nas_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_0139fea3","line":372,"updated":"2015-02-03 12:20:46.000000000","message":"Is this used anywhere?","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        self.configuration.nfs_mount_point_base \u003d self.TEST_MNT_POINT_BASE"},{"line_number":370,"context_line":"        self.configuration.nfs_mount_options \u003d None"},{"line_number":371,"context_line":"        self.configuration.nfs_mount_attempts \u003d 3"},{"line_number":372,"context_line":"        self.configuration.nfs_qcow2_volumes \u003d False"},{"line_number":373,"context_line":"        self.configuration.nas_secure_file_permissions \u003d \u0027false\u0027"},{"line_number":374,"context_line":"        self.configuration.nas_secure_file_operations \u003d \u0027false\u0027"},{"line_number":375,"context_line":"        self.configuration.nas_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_bebbe3e3","line":372,"in_reply_to":"da86d52c_0139fea3","updated":"2015-02-03 16:31:21.000000000","message":"It\u0027s used by _do_create_volume in remotefs.py.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"f5b7b565d5470a21a41c0528ae74102126f26902","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        nas_mount_options \u003d getattr(self.configuration,"},{"line_number":99,"context_line":"                                    \u0027nas_mount_options\u0027,"},{"line_number":100,"context_line":"                                    None)"},{"line_number":101,"context_line":"        if nas_mount_options is not None:"},{"line_number":102,"context_line":"            LOG.debug(\u0027overriding nfs_mount_options with nas_mount_options\u0027)"},{"line_number":103,"context_line":"            opts \u003d nas_mount_options"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_09bd6ed8","line":101,"updated":"2015-02-04 13:45:04.000000000","message":"Why not just: if nas_mount_options: and the message in LOG.debug(...) should start with a capital letter","commit_id":"170ab5825ec24e7cd181147efc331e08029a7354"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"3abc287b73ea763c46f27becc49b590aa73b9770","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        nas_mount_options \u003d getattr(self.configuration,"},{"line_number":99,"context_line":"                                    \u0027nas_mount_options\u0027,"},{"line_number":100,"context_line":"                                    None)"},{"line_number":101,"context_line":"        if nas_mount_options is not None:"},{"line_number":102,"context_line":"            LOG.debug(\u0027overriding nfs_mount_options with nas_mount_options\u0027)"},{"line_number":103,"context_line":"            opts \u003d nas_mount_options"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_64b34c98","line":101,"in_reply_to":"da86d52c_09bd6ed8","updated":"2015-02-05 09:50:38.000000000","message":"checking for not None is more explicit and generally better","commit_id":"170ab5825ec24e7cd181147efc331e08029a7354"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a34dd711d13ef1d2ba2d909fb10b78e7bc49f5fb","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":393,"context_line":"                msg \u003d (_LE(\"Share %s ignored due to invalid format. Must \""},{"line_number":394,"context_line":"                           \"be of form address:/export. Please check the \""},{"line_number":395,"context_line":"                           \"nas_ip and nas_share_path settings.\") %"},{"line_number":396,"context_line":"                       share_address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_238641ba","line":393,"updated":"2015-01-28 14:34:41.000000000","message":"Should _LE() be used for an exception message? I didn\u0027t think so.","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1d2879d476b7a4f713c6cc084f2763ae85efbc73","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":393,"context_line":"                msg \u003d (_LE(\"Share %s ignored due to invalid format. Must \""},{"line_number":394,"context_line":"                           \"be of form address:/export. Please check the \""},{"line_number":395,"context_line":"                           \"nas_ip and nas_share_path settings.\") %"},{"line_number":396,"context_line":"                       share_address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fd1126ad","line":393,"in_reply_to":"fa81d914_0fa6b010","updated":"2015-02-02 12:37:22.000000000","message":"Interesting, I hadn\u0027t seen that.  We are doing this wrong everywhere in Cinder... :)\n\nDone.","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2181769f79fb66494200a0642caf2892f383d77c","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":393,"context_line":"                msg \u003d (_LE(\"Share %s ignored due to invalid format. Must \""},{"line_number":394,"context_line":"                           \"be of form address:/export. Please check the \""},{"line_number":395,"context_line":"                           \"nas_ip and nas_share_path settings.\") %"},{"line_number":396,"context_line":"                       share_address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_0fa6b010","line":393,"in_reply_to":"fa81d914_126d0533","updated":"2015-01-28 19:47:17.000000000","message":"Actually, this is what I was thinking of:\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function\nThe log marker functions (_LI(), _LW(), _LE(), and _LC()) must only be used when the message is only sent directly to the log. Anytime that the message will be passed outside of the current context (for example as part of an exception) the _() marker function must be used.","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7686308561e654b48071be2b787dc8beccf0e4f9","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":393,"context_line":"                msg \u003d (_LE(\"Share %s ignored due to invalid format. Must \""},{"line_number":394,"context_line":"                           \"be of form address:/export. Please check the \""},{"line_number":395,"context_line":"                           \"nas_ip and nas_share_path settings.\") %"},{"line_number":396,"context_line":"                       share_address)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_126d0533","line":393,"in_reply_to":"fa81d914_238641ba","updated":"2015-01-28 16:01:59.000000000","message":"Yes, we don\u0027t have a separate identifier for exception vs. error.  This matches the rest of our code and what\u0027s in cinder-log-error.pot.","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a34dd711d13ef1d2ba2d909fb10b78e7bc49f5fb","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"                if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":425,"context_line":"                    LOG.error(_LE(\"Share %s ignored due to invalid format. \""},{"line_number":426,"context_line":"                                  \"Must be of form address:/export.\") %"},{"line_number":427,"context_line":"                              share_address)"},{"line_number":428,"context_line":"                    continue"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_c3b6458a","line":426,"updated":"2015-01-28 14:34:41.000000000","message":"Should probably switch % to , if updating again.","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1d2879d476b7a4f713c6cc084f2763ae85efbc73","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"                if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":425,"context_line":"                    LOG.error(_LE(\"Share %s ignored due to invalid format. \""},{"line_number":426,"context_line":"                                  \"Must be of form address:/export.\") %"},{"line_number":427,"context_line":"                              share_address)"},{"line_number":428,"context_line":"                    continue"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_5d2072f7","line":426,"in_reply_to":"fa81d914_c3b6458a","updated":"2015-02-02 12:37:22.000000000","message":"Done","commit_id":"150ba6eea87081cc967fab15aa27779add690731"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d(\u0027Options used to mount the storage backend file system \u0027"},{"line_number":83,"context_line":"                     \u0027where Cinder volumes are stored.\u0027))"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"},{"line_number":87,"context_line":"CONF.register_opts(nas_opts)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_61039a73","line":84,"updated":"2015-02-03 12:20:46.000000000","message":"How to separate multiple options? Comma separated? (-o rw, -o nolock).  Would be useful also to give a short example like you did above.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d(\u0027Options used to mount the storage backend file system \u0027"},{"line_number":83,"context_line":"                     \u0027where Cinder volumes are stored.\u0027))"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"},{"line_number":87,"context_line":"CONF.register_opts(nas_opts)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_deba57bf","line":84,"in_reply_to":"da86d52c_61039a73","updated":"2015-02-03 16:31:21.000000000","message":"It\u0027s a string like you would specify on the mount command line.  Normally it\u0027s \"-o rw,nolock\".  I believe \"-o rw -o nolock\" works for some filesystems.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            # QCOW2 volumes are inherently sparse, so this setting"},{"line_number":192,"context_line":"            # will override the _sparsed_volumes setting."},{"line_number":193,"context_line":"            self._create_qcow2_file(volume_path, volume_size)"},{"line_number":194,"context_line":"        elif getattr(self.configuration,"},{"line_number":195,"context_line":"                     self.driver_prefix + \u0027_sparsed_volumes\u0027, False):"},{"line_number":196,"context_line":"            self._create_sparsed_file(volume_path, volume_size)"},{"line_number":197,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_8127ae11","line":194,"updated":"2015-02-03 12:20:46.000000000","message":"Is this related to the config change? Didn\u0027t understand how.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            # QCOW2 volumes are inherently sparse, so this setting"},{"line_number":192,"context_line":"            # will override the _sparsed_volumes setting."},{"line_number":193,"context_line":"            self._create_qcow2_file(volume_path, volume_size)"},{"line_number":194,"context_line":"        elif getattr(self.configuration,"},{"line_number":195,"context_line":"                     self.driver_prefix + \u0027_sparsed_volumes\u0027, False):"},{"line_number":196,"context_line":"            self._create_sparsed_file(volume_path, volume_size)"},{"line_number":197,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_1e5f8f73","line":194,"in_reply_to":"da86d52c_8127ae11","updated":"2015-02-03 16:31:21.000000000","message":"This crept in from my NFS snapshots patch.  Will clean it up.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5b4d0e9a014adb4e31f52640d093bb60a8100771","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        if all((self.configuration.nas_ip,"},{"line_number":381,"context_line":"                self.configuration.nas_share_path)):"},{"line_number":382,"context_line":"            LOG.debug(\u0027Using nas_ip and nas_share_path configuration.\u0027)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            nas_ip \u003d self.configuration.nas_ip"},{"line_number":385,"context_line":"            nas_share_path \u003d self.configuration.nas_share_path"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_cd9a8b6d","line":383,"updated":"2015-02-04 09:58:04.000000000","message":"Here","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"651b9583da746c7129135e91786f38d908fdd4d8","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    continue"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"                self.shares[share_address] \u003d share_opts"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        LOG.debug(\"shares loaded: %s\", self.shares)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_mount_point_for_share(self, path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_6172bae6","line":428,"updated":"2015-02-03 12:20:46.000000000","message":"So, it will still be possible to use multiple shares using the old config format?","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5b4d0e9a014adb4e31f52640d093bb60a8100771","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    continue"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"                self.shares[share_address] \u003d share_opts"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        LOG.debug(\"shares loaded: %s\", self.shares)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_mount_point_for_share(self, path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_ad747736","line":428,"in_reply_to":"da86d52c_18cf9a80","updated":"2015-02-04 09:58:04.000000000","message":"It\u0027s actually implemented above (marked \"Here\").  The only difference from the spec is that I reused existing config options (nas_ip) and added \"nas_share_path\" to fit with the nas* options rather than introducing different \"address\" and \"export_path\" as the spec showed.\n\nThe result behaves the same as the spec though, other than the name changes.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"cc182acd7e0899e30facc07c93618e9589d65570","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    continue"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"                self.shares[share_address] \u003d share_opts"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        LOG.debug(\"shares loaded: %s\", self.shares)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_mount_point_for_share(self, path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_18cf9a80","line":428,"in_reply_to":"da86d52c_5e3bc737","updated":"2015-02-04 09:53:07.000000000","message":"So, then the new config format (like describe in the spec) will be implemented in a later time? I didn\u0027t notice the parsing, CMIIW. That format by the way does not make sense if the backend will handle only one export at time.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"130cd79f3f222b16c43351f2f4595a1dd84f5dd2","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    continue"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"                self.shares[share_address] \u003d share_opts"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        LOG.debug(\"shares loaded: %s\", self.shares)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_mount_point_for_share(self, path):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_5e3bc737","line":428,"in_reply_to":"da86d52c_6172bae6","updated":"2015-02-03 16:31:21.000000000","message":"For now, yes.  That will be removed probably in L, as it is being deprecated.","commit_id":"fa23eb0709bc0154bdc95ebb80cec6aeabc5a73f"}]}