)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"169710b71f4d08994b91f0608518c90ec13ba690","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027perform write-back(on) or write-through(off). \u0027"},{"line_number":118,"context_line":"                    \u0027This parameter is valid if iscsi_helper is set \u0027"},{"line_number":119,"context_line":"                    \u0027to tgtadm or iseradm.\u0027),"},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027iser_enabled\u0027,"},{"line_number":121,"context_line":"                default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d\u0027Determines if iser will be enabled in new iSCSI volumes \u0027"},{"line_number":123,"context_line":"                     \u0027using tgtadm or lioadm target helpers. In order to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_002978e5","line":120,"updated":"2015-01-27 15:32:05.000000000","message":"We don\u0027t want to use a boolean for this.  If we end up with another protocol supported (pretend it\u0027s \"iser2\" for the sake of example), then you end up with multiple _enabled booleans with no clear resolution if someone configures more than one of them to true.\n\nIt would be better to create an option like \"storage_protocol\" which defaults to \"iscsi\", and can be changed to \"iser\" or anything else.","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"2788db510ee3d4140bb52563d424708480140a60","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027perform write-back(on) or write-through(off). \u0027"},{"line_number":118,"context_line":"                    \u0027This parameter is valid if iscsi_helper is set \u0027"},{"line_number":119,"context_line":"                    \u0027to tgtadm or iseradm.\u0027),"},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027iser_enabled\u0027,"},{"line_number":121,"context_line":"                default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d\u0027Determines if iser will be enabled in new iSCSI volumes \u0027"},{"line_number":123,"context_line":"                     \u0027using tgtadm or lioadm target helpers. In order to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_bf5f61e4","line":120,"in_reply_to":"1a930d6b_002978e5","updated":"2015-01-29 21:18:07.000000000","message":"Done","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9ff9b1e0c2019d74060a5387379f153cea636f80","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027perform write-back(on) or write-through(off). \u0027"},{"line_number":118,"context_line":"                    \u0027This parameter is valid if iscsi_helper is set \u0027"},{"line_number":119,"context_line":"                    \u0027to tgtadm or iseradm.\u0027),"},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027iser_enabled\u0027,"},{"line_number":121,"context_line":"                default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d\u0027Determines if iser will be enabled in new iSCSI volumes \u0027"},{"line_number":123,"context_line":"                     \u0027using tgtadm or lioadm target helpers. In order to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_6bac5236","line":120,"in_reply_to":"1a930d6b_002978e5","updated":"2015-01-29 15:19:18.000000000","message":"seems like a good way to go","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"64e80cf268e9ea71b4e7235ca7e177aafb8e564b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027perform write-back(on) or write-through(off). \u0027"},{"line_number":118,"context_line":"                    \u0027This parameter is valid if iscsi_helper is set \u0027"},{"line_number":119,"context_line":"                    \u0027to tgtadm or iseradm.\u0027),"},{"line_number":120,"context_line":"    cfg.BoolOpt(\u0027iser_enabled\u0027,"},{"line_number":121,"context_line":"                default\u003dFalse,"},{"line_number":122,"context_line":"                help\u003d\u0027Determines if iser will be enabled in new iSCSI volumes \u0027"},{"line_number":123,"context_line":"                     \u0027using tgtadm or lioadm target helpers. In order to \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_4b0dce3d","line":120,"in_reply_to":"fa81d914_6bac5236","updated":"2015-01-29 15:21:48.000000000","message":"I agree. should we go with iscsi_protocol or iscsi_transport ?","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"7edc8a147655004407b5405f5fa2e0e1fe85f54f","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        LOG.warning(_LW(\u0027LVMISERDriver is deprecated, you should \u0027"},{"line_number":609,"context_line":"                        \u0027now just use LVMVolumeDriver and specify \u0027"},{"line_number":610,"context_line":"                        \u0027target_helper for the target driver you \u0027"},{"line_number":611,"context_line":"                        \u0027wish to use. in Order to enable iser, please \u0027"},{"line_number":612,"context_line":"                        \u0027set iser_enabled\u003dTrue.\u0027))"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\u0027Attempting to initialize LVM driver with the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_cff0c693","line":611,"updated":"2015-01-26 03:51:05.000000000","message":"Should be \"In order to...\"","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"2788db510ee3d4140bb52563d424708480140a60","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        LOG.warning(_LW(\u0027LVMISERDriver is deprecated, you should \u0027"},{"line_number":609,"context_line":"                        \u0027now just use LVMVolumeDriver and specify \u0027"},{"line_number":610,"context_line":"                        \u0027target_helper for the target driver you \u0027"},{"line_number":611,"context_line":"                        \u0027wish to use. in Order to enable iser, please \u0027"},{"line_number":612,"context_line":"                        \u0027set iser_enabled\u003dTrue.\u0027))"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\u0027Attempting to initialize LVM driver with the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_bfd12159","line":611,"in_reply_to":"1a930d6b_cff0c693","updated":"2015-01-29 21:18:07.000000000","message":"Done","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"}],"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"81190af20e6c86f7aca03f51d0134951775111c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.iser_enabled \u003d \\"},{"line_number":38,"context_line":"            self.configuration.safe_get(\u0027iser_enabled\u0027)"},{"line_number":39,"context_line":"        if self.iser_enabled:"},{"line_number":40,"context_line":"            self.iscsi_driver \u003d \u0027iser\u0027"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            self.iscsi_driver \u003d \u0027iscsi\u0027"},{"line_number":43,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_9f07a817","line":40,"updated":"2015-01-26 21:07:49.000000000","message":"Maybe change this to iscsi_extension ? iscsi_driver seems confusing","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"95850594ddb2e88cc0bd06f9c264cf75018080a0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.iser_enabled \u003d \\"},{"line_number":38,"context_line":"            self.configuration.safe_get(\u0027iser_enabled\u0027)"},{"line_number":39,"context_line":"        if self.iser_enabled:"},{"line_number":40,"context_line":"            self.iscsi_driver \u003d \u0027iser\u0027"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            self.iscsi_driver \u003d \u0027iscsi\u0027"},{"line_number":43,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_b9a47f4b","line":40,"in_reply_to":"1a930d6b_9f07a817","updated":"2015-01-26 22:50:34.000000000","message":"Or something like \u0027iscsi_driver_type\u0027","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"df7c350bfbf74c46923838fff48ca59ebf5b27f5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.iser_enabled \u003d \\"},{"line_number":38,"context_line":"            self.configuration.safe_get(\u0027iser_enabled\u0027)"},{"line_number":39,"context_line":"        if self.iser_enabled:"},{"line_number":40,"context_line":"            self.iscsi_driver \u003d \u0027iser\u0027"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            self.iscsi_driver \u003d \u0027iscsi\u0027"},{"line_number":43,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_4e6bbcb6","line":40,"in_reply_to":"1a930d6b_b9a47f4b","updated":"2015-01-27 12:39:48.000000000","message":"maybe iscsi_volume_type?","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"}],"cinder/volume/targets/iser.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"81190af20e6c86f7aca03f51d0134951775111c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ISERTgtAdm(TgtAdm):"},{"line_number":23,"context_line":"    VERSION \u003d \u00270.2\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    VOLUME_CONF \u003d \"\"\""},{"line_number":26,"context_line":"                \u003ctarget %s\u003e"},{"line_number":27,"context_line":"                    backing-store %s"},{"line_number":28,"context_line":"                    driver %s"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e45f453f","line":25,"updated":"2015-01-26 21:07:49.000000000","message":"Since tgtadm also supports specifying driver in VOLUME_CONF*, can that not be reused ?","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"2788db510ee3d4140bb52563d424708480140a60","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ISERTgtAdm(TgtAdm):"},{"line_number":23,"context_line":"    VERSION \u003d \u00270.2\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    VOLUME_CONF \u003d \"\"\""},{"line_number":26,"context_line":"                \u003ctarget %s\u003e"},{"line_number":27,"context_line":"                    backing-store %s"},{"line_number":28,"context_line":"                    driver %s"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_ff42b90e","line":25,"in_reply_to":"1a930d6b_e45f453f","updated":"2015-01-29 21:18:07.000000000","message":"Done","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"}],"cinder/volume/targets/tgt.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"fd5a17b7f4fadcb2b66b0a1bf7b28ed6fca6f3dc","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        vol_id \u003d name.split(\u0027:\u0027)[1]"},{"line_number":203,"context_line":"        write_cache \u003d kwargs.get(\u0027iscsi_write_cache\u0027, \u0027on\u0027)"},{"line_number":204,"context_line":"        driver \u003d self.iscsi_driver"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        if chap_auth is None:"},{"line_number":207,"context_line":"            volume_conf \u003d self.VOLUME_CONF % (name, path, driver, write_cache)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_1746534f","line":204,"updated":"2015-01-26 14:37:35.000000000","message":"this makes things a little confusing IMO, we\u0027re overloading driver quite a bit again.  IIUC currently there are two options here, \"iser\" or \"iscsi\"; maybe we should introduce something more explicit for this; even if we use the iser_enabled flag you already have for now that would sure make it more clear.","commit_id":"fae357488fcdd559bee22a7668a2cfa08e1031b4"}]}