)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"23169dcd63963f216690ffb9eea084e5bf3ba6fe","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    spec_value \u003d volume_types.get_volume_type_extra_specs(type_id,"},{"line_number":137,"context_line":"                                                          spec_key)"},{"line_number":138,"context_line":"    if not spec_value:"},{"line_number":139,"context_line":"        LOG.debug(\"Returning default spec value: %s.\", default_value)"},{"line_number":140,"context_line":"        return default_value"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if possible_values is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_f15b4e51","line":139,"updated":"2015-02-06 10:52:01.000000000","message":"It should be  LOG.debug(\"Returning default spec value: %s.\" % default_value)  or  LOG.debug(_LI(\"Returning default spec value: %s.\"), default_value)  if you want to use the _LI().","commit_id":"e9b0d59ff43322032e3b44ec20978b1e959ba1d1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fc8e2460a2b3dd18b94164e00cf97bda482c14fd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    spec_value \u003d volume_types.get_volume_type_extra_specs(type_id,"},{"line_number":137,"context_line":"                                                          spec_key)"},{"line_number":138,"context_line":"    if not spec_value:"},{"line_number":139,"context_line":"        LOG.debug(\"Returning default spec value: %s.\", default_value)"},{"line_number":140,"context_line":"        return default_value"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if possible_values is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_482c6099","line":139,"in_reply_to":"da86d52c_145450c8","updated":"2015-02-06 15:04:58.000000000","message":"Vipin is correct.","commit_id":"e9b0d59ff43322032e3b44ec20978b1e959ba1d1"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"565fea6d81fba2686e2a7708eac34dbf3f88c0fb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    spec_value \u003d volume_types.get_volume_type_extra_specs(type_id,"},{"line_number":137,"context_line":"                                                          spec_key)"},{"line_number":138,"context_line":"    if not spec_value:"},{"line_number":139,"context_line":"        LOG.debug(\"Returning default spec value: %s.\", default_value)"},{"line_number":140,"context_line":"        return default_value"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if possible_values is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_145450c8","line":139,"in_reply_to":"da86d52c_f15b4e51","updated":"2015-02-06 11:07:56.000000000","message":"I disagree with you. We shouldn\u0027t translate (do not use marker functions such as _(), _LI() etc) debug messages. Also, delaying string interpolation works even if we don\u0027t use marker functions because the interpolation is done by the LOG method. In your example (using _LI), default_value is the second arg to LOG.debug method which is same as the existing code.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"e9b0d59ff43322032e3b44ec20978b1e959ba1d1"}]}
