)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73a6fd098815f83f4de6205865fda36d4c801a55","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Wang \u003cjwang@nimblestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-27 12:02:59 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use proper way to check the volume attribute contents in display_name"},{"line_number":8,"context_line":"and display_description. If they are not empty, translate them to"},{"line_number":9,"context_line":"volume backend description. Modify other places where return empty"},{"line_number":10,"context_line":"string makes sense than None as well as the return value checking."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_5c587656","line":7,"updated":"2015-01-28 15:29:14.000000000","message":"Please follow commit guidelines detailed from here: https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes","commit_id":"e6b35c5fdec61874f9ca009c90556ba4fbba1c51"}],"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"03fd436dfe13c0171703a73d770b6c38df18adfe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        subnet_label \u003d self.configuration.nimble_subnet_label"},{"line_number":96,"context_line":"        LOG.debug(\u0027subnet_label used %(netlabel)s, netconfig %(netconf)s\u0027"},{"line_number":97,"context_line":"                  % {\u0027netlabel\u0027: subnet_label, \u0027netconf\u0027: netconfig})"},{"line_number":98,"context_line":"        ret_discovery_ip \u003d \u0027\u0027"},{"line_number":99,"context_line":"        for subnet in netconfig[\u0027subnet-list\u0027]:"},{"line_number":100,"context_line":"            LOG.info(_LI(\u0027Exploring array subnet label %s\u0027) % subnet[\u0027label\u0027])"},{"line_number":101,"context_line":"            if subnet_label \u003d\u003d \u0027*\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_8ff7b558","line":98,"updated":"2015-01-30 04:31:15.000000000","message":"Unclear why you\u0027re changing this to an empty string?","commit_id":"cddeb047b298c2a56b667cb667ab0142ddc8bf1a"},{"author":{"_account_id":10395,"name":"Jay Wang","email":"jwang@nimblestorage.com","username":"jwang"},"change_message_id":"b2c8bdd3251379ee262fdcdbb75751f481a5dd8e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        subnet_label \u003d self.configuration.nimble_subnet_label"},{"line_number":96,"context_line":"        LOG.debug(\u0027subnet_label used %(netlabel)s, netconfig %(netconf)s\u0027"},{"line_number":97,"context_line":"                  % {\u0027netlabel\u0027: subnet_label, \u0027netconf\u0027: netconfig})"},{"line_number":98,"context_line":"        ret_discovery_ip \u003d \u0027\u0027"},{"line_number":99,"context_line":"        for subnet in netconfig[\u0027subnet-list\u0027]:"},{"line_number":100,"context_line":"            LOG.info(_LI(\u0027Exploring array subnet label %s\u0027) % subnet[\u0027label\u0027])"},{"line_number":101,"context_line":"            if subnet_label \u003d\u003d \u0027*\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0b1df4bd","line":98,"in_reply_to":"fa81d914_8ff7b558","updated":"2015-01-31 03:54:24.000000000","message":"Thanks John. This is an attempt to make it more consistent in the code. The ret_discovery_ip is a string type, so we can initialize to an empty string to start with. At line #123, it also checks to see if it\u0027s empty or not. If we initialize it to None, a more consistent way to check will be \u0027if ret_discovery_ip is not None\u0027. In addition, at line #151 when it returns to caller, if for some reason None is returned, it will not concatenate None type and string.","commit_id":"cddeb047b298c2a56b667cb667ab0142ddc8bf1a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1dd1544a1e1cbcf20b062ac1b8f2427ac622e6af","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Get discovery ip.\"\"\""},{"line_number":95,"context_line":"        subnet_label \u003d self.configuration.nimble_subnet_label"},{"line_number":96,"context_line":"        LOG.debug(\u0027subnet_label used %(netlabel)s, netconfig %(netconf)s\u0027"},{"line_number":97,"context_line":"                  % {\u0027netlabel\u0027: subnet_label, \u0027netconf\u0027: netconfig})"},{"line_number":98,"context_line":"        ret_discovery_ip \u003d \u0027\u0027"},{"line_number":99,"context_line":"        for subnet in netconfig[\u0027subnet-list\u0027]:"},{"line_number":100,"context_line":"            LOG.info(_LI(\u0027Exploring array subnet label %s\u0027) % subnet[\u0027label\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_20dbae1c","line":97,"updated":"2015-01-31 23:08:16.000000000","message":"Please consider a follow up patch to change LOG.x() calls to use a , instead of a %. That will allow the logger to handle formatting the string only if it is actually at a log level that needs it. Just mentioning to make sure you are aware.","commit_id":"7f88689a2038b50d0f7b7f01c5086e648f15e81a"}]}