)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a48bd18f74387f574d624124d32cd87347cb0c93","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            return"},{"line_number":283,"context_line":"        if volume[\u0027attach_status\u0027] \u003d\u003d \"attached\":"},{"line_number":284,"context_line":"            # Volume is still attached, need to detach first"},{"line_number":285,"context_line":"            LOG.error(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":286,"context_line":"                          \u0027volume is attached.\u0027), volume[\u0027id\u0027])"},{"line_number":287,"context_line":"            raise exception.VolumeAttached(volume_id\u003dvolume_id)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_b2e18800","line":285,"updated":"2015-01-28 21:09:29.000000000","message":"Should this be error? Error is supposed to be \u0027you system is broken\u0027 - this seems warning or even info?\n\nSame as the ones below","commit_id":"0fcac918a5085b899b60a5018b87544d1a1ed044"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a17296aed74fc8803e1086a943e52b5e31133539","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            return"},{"line_number":283,"context_line":"        if volume[\u0027attach_status\u0027] \u003d\u003d \"attached\":"},{"line_number":284,"context_line":"            # Volume is still attached, need to detach first"},{"line_number":285,"context_line":"            LOG.error(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":286,"context_line":"                          \u0027volume is attached.\u0027), volume[\u0027id\u0027])"},{"line_number":287,"context_line":"            raise exception.VolumeAttached(volume_id\u003dvolume_id)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_e6f97ec9","line":285,"in_reply_to":"fa81d914_b2e18800","updated":"2015-01-28 22:20:23.000000000","message":"Done","commit_id":"0fcac918a5085b899b60a5018b87544d1a1ed044"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"19f4d3787e98789b48dccc49c0e5b0b2976e3d1c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            return"},{"line_number":283,"context_line":"        if volume[\u0027attach_status\u0027] \u003d\u003d \"attached\":"},{"line_number":284,"context_line":"            # Volume is still attached, need to detach first"},{"line_number":285,"context_line":"            LOG.info(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":286,"context_line":"                         \u0027volume is attached.\u0027), volume[\u0027id\u0027])"},{"line_number":287,"context_line":"            raise exception.VolumeAttached(volume_id\u003dvolume_id)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_46a96a7a","line":285,"updated":"2015-01-28 22:24:13.000000000","message":"Should we use _LI here and below?","commit_id":"0108ced5d33a0fad86b30416c79019408f8bba33"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"386eb7825437eb82acab9e88ab4ac0dc32ea2bd8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                                                  \"error_extending\"]:"},{"line_number":292,"context_line":"            msg \u003d _(\"Volume status must be available or error, \""},{"line_number":293,"context_line":"                    \"but current status is: %s\") % volume[\u0027status\u0027]"},{"line_number":294,"context_line":"            LOG.info(_LE(\u0027Unable to delete volume: %(vol_id)s, \u0027"},{"line_number":295,"context_line":"                         \u0027volume must be available or \u0027"},{"line_number":296,"context_line":"                         \u0027error, but is %(vol_status)s.\u0027),"},{"line_number":297,"context_line":"                     {\u0027vol_id\u0027: volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_48309001","line":294,"updated":"2015-01-29 01:48:36.000000000","message":"Should we use _LI?","commit_id":"0108ced5d33a0fad86b30416c79019408f8bba33"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"386eb7825437eb82acab9e88ab4ac0dc32ea2bd8","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if volume[\u0027migration_status\u0027] is not None:"},{"line_number":302,"context_line":"            # Volume is migrating, wait until done"},{"line_number":303,"context_line":"            LOG.info(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":304,"context_line":"                         \u0027volume is currently migrating.\u0027), volume[\u0027id\u0027])"},{"line_number":305,"context_line":"            msg \u003d _(\"Volume cannot be deleted while migrating\")"},{"line_number":306,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_080db83e","line":303,"updated":"2015-01-29 01:48:36.000000000","message":"Should we use _LI?","commit_id":"0108ced5d33a0fad86b30416c79019408f8bba33"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"386eb7825437eb82acab9e88ab4ac0dc32ea2bd8","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if volume[\u0027consistencygroup_id\u0027] is not None:"},{"line_number":309,"context_line":"            msg \u003d _(\"Volume cannot be deleted while in a consistency group.\")"},{"line_number":310,"context_line":"            LOG.info(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":311,"context_line":"                         \u0027volume is currently part of a \u0027"},{"line_number":312,"context_line":"                         \u0027consistency group.\u0027), volume[\u0027id\u0027])"},{"line_number":313,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_e816a454","line":310,"updated":"2015-01-29 01:48:36.000000000","message":"Should we use _LI?","commit_id":"0108ced5d33a0fad86b30416c79019408f8bba33"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"386eb7825437eb82acab9e88ab4ac0dc32ea2bd8","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        snapshots \u003d self.db.snapshot_get_all_for_volume(context, volume_id)"},{"line_number":316,"context_line":"        if len(snapshots):"},{"line_number":317,"context_line":"            LOG.info(_LE(\u0027Unable to delete volume: %s, \u0027"},{"line_number":318,"context_line":"                         \u0027volume currently has snapshots.\u0027), volume[\u0027id\u0027])"},{"line_number":319,"context_line":"            msg \u003d _(\"Volume still has %d dependent snapshots\") % len(snapshots)"},{"line_number":320,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_c813a064","line":317,"updated":"2015-01-29 01:48:36.000000000","message":"Should we use _LI?","commit_id":"0108ced5d33a0fad86b30416c79019408f8bba33"}]}