)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"3ee40ad9105a71dd841d91b1f299500cdeda8e9e","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        ret_function \u003d self.configuration.filter_function"},{"line_number":525,"context_line":"        if not ret_function:"},{"line_number":526,"context_line":"            ret_function \u003d CONF.filter_function"},{"line_number":527,"context_line":"        return ret_function"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    def _attach_volume(self, context, volume, properties, remote\u003dFalse):"},{"line_number":530,"context_line":"        \"\"\"Attach the volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_56cf0c7f","line":527,"updated":"2015-02-11 09:32:07.000000000","message":"These still need to be fed up to the scheduler appropriately...","commit_id":"1a64988b12787e1f296860a656f500bf485a0f0d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"dcf656f33f135c32da23ccdb64557e60e3dc18b5","unresolved":false,"context_lines":[{"line_number":1706,"context_line":"    def _update_volume_stats(self):"},{"line_number":1707,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"        LOG.debug(\"Updating volume stats\")"},{"line_number":1710,"context_line":"        data \u003d {}"},{"line_number":1711,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":1712,"context_line":"        data[\"volume_backend_name\"] \u003d backend_name or \u0027Generic_FC\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_72b5857d","line":1709,"updated":"2015-02-26 23:22:22.000000000","message":"Suggest \"Updating volume stats...\"","commit_id":"5848346a7d70dc60e3023a7f599a9b295551a147"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"c5c93dab133e6775d2c18c89f5ec1f10cb182ba5","unresolved":false,"context_lines":[{"line_number":1706,"context_line":"    def _update_volume_stats(self):"},{"line_number":1707,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"        LOG.debug(\"Updating volume stats\")"},{"line_number":1710,"context_line":"        data \u003d {}"},{"line_number":1711,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":1712,"context_line":"        data[\"volume_backend_name\"] \u003d backend_name or \u0027Generic_FC\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_0bd5cb42","line":1709,"in_reply_to":"ba7be1f8_72b5857d","updated":"2015-02-27 18:59:39.000000000","message":"Done","commit_id":"5848346a7d70dc60e3023a7f599a9b295551a147"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c7cfeb60a248e61b0842d50b672f24709b642ae6","unresolved":false,"context_lines":[{"line_number":1756,"context_line":"        # None won\u0027t be used in calculation. It will be overridden by"},{"line_number":1757,"context_line":"        # driver\u0027s provisioned_capacity_gb if reported, otherwise it"},{"line_number":1758,"context_line":"        # defaults to allocated_capacity_gb in host_manager.py."},{"line_number":1759,"context_line":"        if self.pools:"},{"line_number":1760,"context_line":"            for pool in self.pools:"},{"line_number":1761,"context_line":"                new_pool \u003d {}"},{"line_number":1762,"context_line":"                new_pool.update(dict("}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_fbdd7715","line":1759,"updated":"2015-03-02 10:53:48.000000000","message":"This code is the same in in lines 1465-1490 and 1625-1650. Please, move it to the function","commit_id":"c7207bb0c1663fe979399cd3dcbc417ccda0d44c"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"a9d2cbd954b830a3c6f6f0607babdab60466a226","unresolved":false,"context_lines":[{"line_number":1756,"context_line":"        # None won\u0027t be used in calculation. It will be overridden by"},{"line_number":1757,"context_line":"        # driver\u0027s provisioned_capacity_gb if reported, otherwise it"},{"line_number":1758,"context_line":"        # defaults to allocated_capacity_gb in host_manager.py."},{"line_number":1759,"context_line":"        if self.pools:"},{"line_number":1760,"context_line":"            for pool in self.pools:"},{"line_number":1761,"context_line":"                new_pool \u003d {}"},{"line_number":1762,"context_line":"                new_pool.update(dict("}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_a28acf61","line":1759,"in_reply_to":"ba7be1f8_fbdd7715","updated":"2015-03-02 23:30:18.000000000","message":"Done","commit_id":"c7207bb0c1663fe979399cd3dcbc417ccda0d44c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cfe57749c4085ccd75b40fe2be09c7ed3c4bb2db","unresolved":false,"context_lines":[{"line_number":195,"context_line":"               secret\u003dTrue),"},{"line_number":196,"context_line":"    cfg.StrOpt(\u0027filter_function\u0027,"},{"line_number":197,"context_line":"               default\u003dNone,"},{"line_number":198,"context_line":"               help\u003d\"Add filter_function.\"),"},{"line_number":199,"context_line":"    cfg.StrOpt(\u0027goodness_function\u0027,"},{"line_number":200,"context_line":"               default\u003dNone,"},{"line_number":201,"context_line":"               help\u003d\"Add goodness_function.\"),"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_52094630","line":198,"updated":"2015-03-04 21:05:25.000000000","message":"Please, add more user-friendly message here and below","commit_id":"3bde2d0065e673487032560dd7776f703de7b50d"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"c7d0195ec7a80cc7fb97fdcaea3cfe7d36619e41","unresolved":false,"context_lines":[{"line_number":195,"context_line":"               secret\u003dTrue),"},{"line_number":196,"context_line":"    cfg.StrOpt(\u0027filter_function\u0027,"},{"line_number":197,"context_line":"               default\u003dNone,"},{"line_number":198,"context_line":"               help\u003d\"Add filter_function.\"),"},{"line_number":199,"context_line":"    cfg.StrOpt(\u0027goodness_function\u0027,"},{"line_number":200,"context_line":"               default\u003dNone,"},{"line_number":201,"context_line":"               help\u003d\"Add goodness_function.\"),"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_0595c53f","line":198,"in_reply_to":"9a80dd14_52094630","updated":"2015-03-04 23:15:26.000000000","message":"Done","commit_id":"3bde2d0065e673487032560dd7776f703de7b50d"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"83690d72a76af34a10624b781e6a2feffe001291","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                                         cpg[\u0027SDUsage\u0027][\u0027usedMiB\u0027])) * const)"},{"line_number":691,"context_line":"                capacity_utilization \u003d \\"},{"line_number":692,"context_line":"                    (float(total_capacity - free_capacity) /"},{"line_number":693,"context_line":"                     float(total_capacity)) * 100"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"            except hpexceptions.HTTPNotFound:"},{"line_number":696,"context_line":"                err \u003d (_(\"CPG (%s) doesn\u0027t exist on array\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_ad7d6ce9","line":693,"updated":"2015-01-29 22:51:13.000000000","message":"Instead of using the \u0027\\\u0027 for line continuation you can wrap this in ( .. ).\n\ncapacity_utilization \u003d (\n    (float(total_capacity - free_capacity) /\n     float(total_capacity)))","commit_id":"10e95c44402bd13d43ca510b28df4236e2ca8730"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9906602d0fa954461842206ea23c0511444b7ed7","unresolved":false,"context_lines":[{"line_number":1929,"context_line":"        return self._retype_from_old_to_new(volume, new_type,"},{"line_number":1930,"context_line":"                                            old_volume_settings, host)"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"    def get_goodness_function(self):"},{"line_number":1933,"context_line":"        \"\"\"Get hp3par_good_function string."},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"           Returns either the string from the driver instance or global section"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b253a215","line":1932,"updated":"2015-02-06 02:24:10.000000000","message":"These should be private methods as they aren\u0027t called outside of this.\n\ndef _get_goodness_fucntion","commit_id":"992104e1cfcf9550a400f3217b2aad0296a737e2"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"decbc8373d29839a15505a858d7f8359912f87be","unresolved":false,"context_lines":[{"line_number":1929,"context_line":"        return self._retype_from_old_to_new(volume, new_type,"},{"line_number":1930,"context_line":"                                            old_volume_settings, host)"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"    def get_goodness_function(self):"},{"line_number":1933,"context_line":"        \"\"\"Get hp3par_good_function string."},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"           Returns either the string from the driver instance or global section"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_2151f9d8","line":1932,"in_reply_to":"da86d52c_b253a215","updated":"2015-02-06 23:24:02.000000000","message":"ok","commit_id":"992104e1cfcf9550a400f3217b2aad0296a737e2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9906602d0fa954461842206ea23c0511444b7ed7","unresolved":false,"context_lines":[{"line_number":1940,"context_line":"            ret_function \u003d CONF.hp3par_goodness_function"},{"line_number":1941,"context_line":"        return ret_function"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":"    def get_filter_fucntion(self):"},{"line_number":1944,"context_line":"        \"\"\"Get hp3par_filter_function string."},{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":"           Returns either the string from the driver instance or global section"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_12446e48","line":1943,"updated":"2015-02-06 02:24:10.000000000","message":"same","commit_id":"992104e1cfcf9550a400f3217b2aad0296a737e2"},{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"decbc8373d29839a15505a858d7f8359912f87be","unresolved":false,"context_lines":[{"line_number":1940,"context_line":"            ret_function \u003d CONF.hp3par_goodness_function"},{"line_number":1941,"context_line":"        return ret_function"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":"    def get_filter_fucntion(self):"},{"line_number":1944,"context_line":"        \"\"\"Get hp3par_filter_function string."},{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":"           Returns either the string from the driver instance or global section"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_a15c09ef","line":1943,"in_reply_to":"da86d52c_12446e48","updated":"2015-02-06 23:24:02.000000000","message":"ok","commit_id":"992104e1cfcf9550a400f3217b2aad0296a737e2"}]}