)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c8ad1924de81b1cbaa8e8c1c00c2b4842e56bd95","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"        # Hide status update from user if we\u0027re performing a volume migration"},{"line_number":1139,"context_line":"        # or uploading it to image"},{"line_number":1140,"context_line":"        if not volume_ref[\u0027migration_status\u0027] and \\"},{"line_number":1141,"context_line":"                not (volume_ref[\u0027status\u0027] \u003d\u003d \u0027uploading\u0027):"},{"line_number":1142,"context_line":"            volume_ref[\u0027status\u0027] \u003d \u0027available\u0027"},{"line_number":1143,"context_line":"        volume_ref[\u0027mountpoint\u0027] \u003d None"},{"line_number":1144,"context_line":"        volume_ref[\u0027attach_status\u0027] \u003d \u0027detached\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_c5917bf2","line":1141,"updated":"2015-01-30 16:29:52.000000000","message":"downloading?","commit_id":"fc7ac3bf448620f58c1d6b847670e1083fd1e08a"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"94c291383d20c9f6db6f22f3e70064e7dd7b8ed1","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        if not remain_attachment:"},{"line_number":1210,"context_line":"            # Hide status update from user if we\u0027re performing volume migration"},{"line_number":1211,"context_line":"            # or uploading it to image"},{"line_number":1212,"context_line":"            if not volume_ref[\u0027migration_status\u0027] and \\"},{"line_number":1213,"context_line":"                    not (volume_ref[\u0027status\u0027] \u003d\u003d \u0027uploading\u0027):"},{"line_number":1214,"context_line":"                volume_ref[\u0027status\u0027] \u003d \u0027available\u0027"},{"line_number":1215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_3136f352","line":1212,"updated":"2015-03-31 09:45:20.000000000","message":"Replace \u0027\\\u0027 with parentheses?","commit_id":"ee134fef04fd1cd78bb8e6b81bdde9418a175a88"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"94c291383d20c9f6db6f22f3e70064e7dd7b8ed1","unresolved":false,"context_lines":[{"line_number":2343,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":2344,"context_line":"        self.volume.attach_volume(self.context, volume_id, instance_uuid,"},{"line_number":2345,"context_line":"                                  None, mountpoint, \u0027ro\u0027)"},{"line_number":2346,"context_line":"        # Change volume status to \u0027uploading\u0027"},{"line_number":2347,"context_line":"        db.volume_update(self.context, volume_id, {\u0027status\u0027: \u0027uploading\u0027})"},{"line_number":2348,"context_line":"        # call detach api"},{"line_number":2349,"context_line":"        self.volume.detach_volume(self.context, volume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_4c78ba8f","line":2346,"updated":"2015-03-31 09:45:20.000000000","message":"All beginning character in new comments are uncapitalized except this one.","commit_id":"ee134fef04fd1cd78bb8e6b81bdde9418a175a88"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"94c291383d20c9f6db6f22f3e70064e7dd7b8ed1","unresolved":false,"context_lines":[{"line_number":2349,"context_line":"        self.volume.detach_volume(self.context, volume_id)"},{"line_number":2350,"context_line":"        vol \u003d db.volume_get(self.context, volume_id)"},{"line_number":2351,"context_line":"        # check that volume status is \u0027uploading\u0027"},{"line_number":2352,"context_line":"        self.assertEqual(vol[\u0027status\u0027], \"uploading\")"},{"line_number":2353,"context_line":"        self.assertEqual(vol[\u0027attach_status\u0027], \"detached\")"},{"line_number":2354,"context_line":""},{"line_number":2355,"context_line":"    @mock.patch.object(cinder.volume.api.API, \u0027update\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_ec978e8e","line":2352,"updated":"2015-03-31 09:45:20.000000000","message":"assertEqual(expected_value, actual_value)?","commit_id":"ee134fef04fd1cd78bb8e6b81bdde9418a175a88"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"2086a152fc5eb560398a2c2a5a2e4032366a3ea6","unresolved":false,"context_lines":[{"line_number":2373,"context_line":"        db.volume_update(self.context, volume_id, {\u0027status\u0027: \u0027uploading\u0027})"},{"line_number":2374,"context_line":"        # Call detach api"},{"line_number":2375,"context_line":"        self.volume.detach_volume(self.context, volume_id)"},{"line_number":2376,"context_line":"        vol \u003d db.volume_get(self.context, volume_id)"},{"line_number":2377,"context_line":"        # Check that volume status is \u0027uploading\u0027"},{"line_number":2378,"context_line":"        self.assertEqual(\"uploading\", vol[\u0027status\u0027])"},{"line_number":2379,"context_line":"        self.assertEqual(\"detached\", vol[\u0027attach_status\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_07273865","line":2376,"updated":"2015-04-03 01:05:58.000000000","message":"Rather than making actual DB calls why not mock them ?","commit_id":"909a4eb2fd5411f11e57c2589fc786611cdeda57"},{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"c9b17e63ea8ba57111e3e500cddb494fa180f775","unresolved":false,"context_lines":[{"line_number":2373,"context_line":"        db.volume_update(self.context, volume_id, {\u0027status\u0027: \u0027uploading\u0027})"},{"line_number":2374,"context_line":"        # Call detach api"},{"line_number":2375,"context_line":"        self.volume.detach_volume(self.context, volume_id)"},{"line_number":2376,"context_line":"        vol \u003d db.volume_get(self.context, volume_id)"},{"line_number":2377,"context_line":"        # Check that volume status is \u0027uploading\u0027"},{"line_number":2378,"context_line":"        self.assertEqual(\"uploading\", vol[\u0027status\u0027])"},{"line_number":2379,"context_line":"        self.assertEqual(\"detached\", vol[\u0027attach_status\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_5564c320","line":2376,"in_reply_to":"baa041b7_07273865","updated":"2015-04-03 07:17:26.000000000","message":"Hi Vilobh,\n\n\u0027tests_utils.create_volume\u0027 method creates test volume in DB ( Cinder is using fixture for DB : https://github.com/openstack/cinder/blob/master/cinder/test.py#L69). In test case I am updating volume before making call to \u0027detach_volume\u0027. This will update volume in test DB. \n\nAfter detach call I am again getting this volume from DB and checking for \u0027status\u0027.\nSo if I mock this DB call then I will not get proper results.","commit_id":"909a4eb2fd5411f11e57c2589fc786611cdeda57"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"6efe5b86df78b7870a2d9a783ff9d68a9c6d3ce1","unresolved":false,"context_lines":[{"line_number":3080,"context_line":"                          self._create_volume_from_image)"},{"line_number":3081,"context_line":"        # NOTE(dulek): Rescheduling should not occur, so lets assert that"},{"line_number":3082,"context_line":"        # allocated_capacity is incremented."},{"line_number":3083,"context_line":"        self.assertDictEqual(self.volume.stats[\u0027pools\u0027],"},{"line_number":3084,"context_line":"                             {\u0027_pool0\u0027: {\u0027allocated_capacity_gb\u0027: 1}})"},{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"    def test_create_volume_from_exact_sized_image(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_a2b5e531","line":3083,"updated":"2015-04-01 07:51:19.000000000","message":"assertDictEqual(expected, actual)?","commit_id":"909a4eb2fd5411f11e57c2589fc786611cdeda57"}]}