)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f399244764c86d4a5c9615a8b42543b2484fcb9a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027display_name\u0027: \u0027Foo Volume\u0027,"},{"line_number":118,"context_line":"                    \u0027size\u0027: 2,"},{"line_number":119,"context_line":"                    \u0027host\u0027: FAKE_HOST,"},{"line_number":120,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":121,"context_line":"                    \u0027volume_type_id\u0027: \u0027dedup\u0027}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    volume_pool \u003d {\u0027name\u0027: VOLUME_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8634724b","line":120,"updated":"2015-02-07 15:57:42.000000000","message":"Should \u0027volume_type\u0027 be \u0027dedup\u0027 as you created a volume_type_dedup with \u0027name\u0027 as \u0027dedup\u0027 on line 172?","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b71075a316da7aa394bbd7f34c60d3621b4a7acb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    \u0027display_name\u0027: \u0027Foo Volume\u0027,"},{"line_number":118,"context_line":"                    \u0027size\u0027: 2,"},{"line_number":119,"context_line":"                    \u0027host\u0027: FAKE_HOST,"},{"line_number":120,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":121,"context_line":"                    \u0027volume_type_id\u0027: \u0027dedup\u0027}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    volume_pool \u003d {\u0027name\u0027: VOLUME_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3d9095ec","line":120,"in_reply_to":"da86d52c_8634724b","updated":"2015-02-12 01:24:54.000000000","message":"Done","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f399244764c86d4a5c9615a8b42543b2484fcb9a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    \u0027size\u0027: 2,"},{"line_number":119,"context_line":"                    \u0027host\u0027: FAKE_HOST,"},{"line_number":120,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":121,"context_line":"                    \u0027volume_type_id\u0027: \u0027dedup\u0027}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    volume_pool \u003d {\u0027name\u0027: VOLUME_NAME,"},{"line_number":124,"context_line":"                   \u0027id\u0027: VOLUME_ID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_06f16295","line":121,"updated":"2015-02-07 15:57:42.000000000","message":"Since volume_type_id is a uuid, it is better to provide a uuid like value here.","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b71075a316da7aa394bbd7f34c60d3621b4a7acb","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    \u0027size\u0027: 2,"},{"line_number":119,"context_line":"                    \u0027host\u0027: FAKE_HOST,"},{"line_number":120,"context_line":"                    \u0027volume_type\u0027: None,"},{"line_number":121,"context_line":"                    \u0027volume_type_id\u0027: \u0027dedup\u0027}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    volume_pool \u003d {\u0027name\u0027: VOLUME_NAME,"},{"line_number":124,"context_line":"                   \u0027id\u0027: VOLUME_ID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5d8d49d2","line":121,"in_reply_to":"da86d52c_06f16295","updated":"2015-02-12 01:24:54.000000000","message":"Done","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f399244764c86d4a5c9615a8b42543b2484fcb9a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                         \u0027extra_specs\u0027: {\u0027cpg\u0027: HP3PAR_CPG2,"},{"line_number":176,"context_line":"                                         \u0027provisioning\u0027: \u0027dedup\u0027},"},{"line_number":177,"context_line":"                         \u0027deleted_at\u0027: None,"},{"line_number":178,"context_line":"                         \u0027id\u0027: \u0027dedup\u0027}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    cpgs \u003d ["},{"line_number":181,"context_line":"        {\u0027SAGrowth\u0027: {\u0027LDLayout\u0027: {\u0027diskPatterns\u0027: [{\u0027diskType\u0027: 2}]},"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e63a8e33","line":178,"updated":"2015-02-07 15:57:42.000000000","message":"Suggest using a uuid like value for \u0027id\u0027 rather than \u0027dedup\u0027.","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b71075a316da7aa394bbd7f34c60d3621b4a7acb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                         \u0027extra_specs\u0027: {\u0027cpg\u0027: HP3PAR_CPG2,"},{"line_number":176,"context_line":"                                         \u0027provisioning\u0027: \u0027dedup\u0027},"},{"line_number":177,"context_line":"                         \u0027deleted_at\u0027: None,"},{"line_number":178,"context_line":"                         \u0027id\u0027: \u0027dedup\u0027}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    cpgs \u003d ["},{"line_number":181,"context_line":"        {\u0027SAGrowth\u0027: {\u0027LDLayout\u0027: {\u0027diskPatterns\u0027: [{\u0027diskType\u0027: 2}]},"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_bdb3a598","line":178,"in_reply_to":"da86d52c_e63a8e33","updated":"2015-02-12 01:24:54.000000000","message":"Done","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f399244764c86d4a5c9615a8b42543b2484fcb9a","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                        \u0027tpvv\u0027: False,"},{"line_number":798,"context_line":"                        \u0027tdvv\u0027: True,"},{"line_number":799,"context_line":"                        \u0027snapCPG\u0027: HP3PAR_CPG_SNAP})]"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"            mock_client.assert_has_calls("},{"line_number":802,"context_line":"                self.standard_login +"},{"line_number":803,"context_line":"                expected +"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a61096a9","line":800,"updated":"2015-02-07 15:57:42.000000000","message":"Can you add a failure test case for creating a dedup volume?","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b71075a316da7aa394bbd7f34c60d3621b4a7acb","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                        \u0027tpvv\u0027: False,"},{"line_number":798,"context_line":"                        \u0027tdvv\u0027: True,"},{"line_number":799,"context_line":"                        \u0027snapCPG\u0027: HP3PAR_CPG_SNAP})]"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"            mock_client.assert_has_calls("},{"line_number":802,"context_line":"                self.standard_login +"},{"line_number":803,"context_line":"                expected +"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_71d95156","line":800,"in_reply_to":"da86d52c_a61096a9","updated":"2015-02-12 01:24:54.000000000","message":"Done","commit_id":"959303c95554a03b4c952b03bb51a97d66625382"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"ace5f5e34ca4f945c4da29abe60e2a8fd469b56c","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"            err \u003d (_(\"Dedup is a valid provisioning type, \""},{"line_number":1042,"context_line":"                     \"but requires WSAPI version \u0027%(dedup_version)s\u0027 \""},{"line_number":1043,"context_line":"                     \"version \u0027%(version)s\u0027 is installed.\") %"},{"line_number":1044,"context_line":"                    ({\u0027dedup_version\u0027: DEDUP_API_VERSION,"},{"line_number":1045,"context_line":"                      \u0027version\u0027: self.API_VERSION}))"},{"line_number":1046,"context_line":"            LOG.error(err)"},{"line_number":1047,"context_line":"            raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_3ea03df4","line":1044,"updated":"2015-01-30 23:24:38.000000000","message":"nit: this set of parenthesis is unnecessary","commit_id":"05955a8312ae4d2a287362c3cc13bef9242450e9"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"1468726f41ab59c9626fe4726e12a6c00a552299","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"            err \u003d (_(\"Dedup is a valid provisioning type, \""},{"line_number":1042,"context_line":"                     \"but requires WSAPI version \u0027%(dedup_version)s\u0027 \""},{"line_number":1043,"context_line":"                     \"version \u0027%(version)s\u0027 is installed.\") %"},{"line_number":1044,"context_line":"                    ({\u0027dedup_version\u0027: DEDUP_API_VERSION,"},{"line_number":1045,"context_line":"                      \u0027version\u0027: self.API_VERSION}))"},{"line_number":1046,"context_line":"            LOG.error(err)"},{"line_number":1047,"context_line":"            raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f275f932","line":1044,"in_reply_to":"da86d52c_3ea03df4","updated":"2015-01-31 00:31:36.000000000","message":"Done","commit_id":"05955a8312ae4d2a287362c3cc13bef9242450e9"}]}