)]}'
{"cinder/volume/drivers/ibm/storwize_svc/__init__.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"6acccb0cc319d186297a7787ee42a09e3072e42e","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                                                \u0027conn\u0027: connector})"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        LOG.debug(\u0027leave: initialize_connection:\\n volume: %(vol)s\\n \u0027"},{"line_number":498,"context_line":"                  \u0027connector %(conn)s\\n properties: %(prop)s\u0027"},{"line_number":499,"context_line":"                  % {\u0027vol\u0027: volume, \u0027conn\u0027: connector, \u0027prop\u0027: properties})"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        return {\u0027driver_volume_type\u0027: type_str, \u0027data\u0027: properties, }"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_284ef56f","line":498,"updated":"2015-02-03 02:16:06.000000000","message":"Should use volume[\u0027id\u0027] here too.","commit_id":"00373dfc21108b2ba5497c14dc45387f88b20606"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"6acccb0cc319d186297a7787ee42a09e3072e42e","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        self._helpers.unmap_vol_from_host(vol_name, host_name)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        LOG.debug(\u0027leave: terminate_connection: volume %(vol)s with \u0027"},{"line_number":561,"context_line":"                  \u0027connector %(conn)s\u0027 % {\u0027vol\u0027: volume, \u0027conn\u0027: connector})"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        return info"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e84bfd56","line":560,"updated":"2015-02-03 02:16:06.000000000","message":"Ditto","commit_id":"00373dfc21108b2ba5497c14dc45387f88b20606"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b6d81a8eb04f8502a702afdf37ec42a8b1dead14","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        \"\"\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        LOG.debug(\u0027enter: initialize_connection: volume %(vol)s with connector\u0027"},{"line_number":341,"context_line":"                  \u0027 %(conn)s\u0027 % {\u0027vol\u0027: volume[\u0027id\u0027], \u0027conn\u0027: connector})"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        vol_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027])"},{"line_number":344,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_459fc650","line":341,"updated":"2015-02-08 23:37:00.000000000","message":"According to a logging guidelines, please replace % to ,","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b6d81a8eb04f8502a702afdf37ec42a8b1dead14","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                LOG.error(_LE(\u0027initialize_connection: Failed \u0027"},{"line_number":492,"context_line":"                              \u0027to collect return \u0027"},{"line_number":493,"context_line":"                              \u0027properties for volume %(vol)s and connector \u0027"},{"line_number":494,"context_line":"                              \u0027%(conn)s.\\n\u0027) % {\u0027vol\u0027: volume,"},{"line_number":495,"context_line":"                                                \u0027conn\u0027: connector})"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        LOG.debug(\u0027leave: initialize_connection:\\n volume: %(vol)s\\n \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a5b5e2d1","line":494,"updated":"2015-02-08 23:37:00.000000000","message":"% \u003d\u003e ,","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b6d81a8eb04f8502a702afdf37ec42a8b1dead14","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        LOG.debug(\u0027leave: initialize_connection:\\n volume: %(vol)s\\n \u0027"},{"line_number":498,"context_line":"                  \u0027connector %(conn)s\\n properties: %(prop)s\u0027"},{"line_number":499,"context_line":"                  % {\u0027vol\u0027: volume[\u0027id\u0027], \u0027conn\u0027: connector,"},{"line_number":500,"context_line":"                     \u0027prop\u0027: properties})"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        return {\u0027driver_volume_type\u0027: type_str, \u0027data\u0027: properties, }"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_65acca8d","line":499,"updated":"2015-02-08 23:37:00.000000000","message":"% \u003d\u003e ,","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"2529a74482685fd1d16c0a82b09c3e94bf278855","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        3. Delete the host if it has no more mappings (hosts are created"},{"line_number":524,"context_line":"           automatically by this driver when mappings are created)"},{"line_number":525,"context_line":"        \"\"\""},{"line_number":526,"context_line":"        LOG.debug(\u0027enter: terminate_connection: volume %(vol)s with  connector\u0027"},{"line_number":527,"context_line":"                  \u0027 %(conn)s\u0027 % {\u0027vol\u0027: volume[\u0027id\u0027], \u0027conn\u0027: connector})"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e0193b89","line":526,"updated":"2015-02-03 15:47:46.000000000","message":"nit:  You have 2 white spaces between \"with\" and \"connector\".  You might want to fix it if you rebase.","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b6d81a8eb04f8502a702afdf37ec42a8b1dead14","unresolved":false,"context_lines":[{"line_number":524,"context_line":"           automatically by this driver when mappings are created)"},{"line_number":525,"context_line":"        \"\"\""},{"line_number":526,"context_line":"        LOG.debug(\u0027enter: terminate_connection: volume %(vol)s with  connector\u0027"},{"line_number":527,"context_line":"                  \u0027 %(conn)s\u0027 % {\u0027vol\u0027: volume[\u0027id\u0027], \u0027conn\u0027: connector})"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"},{"line_number":530,"context_line":"        if \u0027host\u0027 in connector:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c5bad6bf","line":527,"updated":"2015-02-08 23:37:00.000000000","message":"% \u003d\u003e ,","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b6d81a8eb04f8502a702afdf37ec42a8b1dead14","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        LOG.debug(\u0027leave: terminate_connection: volume %(vol)s with \u0027"},{"line_number":562,"context_line":"                  \u0027connector %(conn)s\u0027 % {\u0027vol\u0027: volume[\u0027id\u0027],"},{"line_number":563,"context_line":"                                          \u0027conn\u0027: connector})"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        return info"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e5afda7b","line":563,"updated":"2015-02-08 23:37:00.000000000","message":"% \u003d\u003e ,","commit_id":"6d85dcb7354aaa96d475a401f7c957a1cc93358c"}]}
