)]}'
{"cinder/tests/test_volume.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0c6527f95b86d171c1b50300690adeb4a09d038c","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"                              dst_vol_id,"},{"line_number":1111,"context_line":"                              **kwargs)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"        # ensure that status of volume is \u0027error\u0027"},{"line_number":1114,"context_line":"        vol \u003d db.volume_get(self.context, dst_vol_id)"},{"line_number":1115,"context_line":"        self.assertEqual(\u0027error\u0027, vol[\u0027status\u0027])"},{"line_number":1116,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_55cfc655","line":1113,"updated":"2015-02-05 16:20:59.000000000","message":"In the future, start all comments uppercase.","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7876f487fcffff98859240a69774a5949ecf86eb","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            # would be available for that volume in"},{"line_number":400,"context_line":"            # volume glance metadata table"},{"line_number":401,"context_line":"            pass"},{"line_number":402,"context_line":"        except Exception as ex:"},{"line_number":403,"context_line":"            LOG.exception(exception_template % {\u0027src_type\u0027: src_type,"},{"line_number":404,"context_line":"                                                \u0027src_id\u0027: src_id,"},{"line_number":405,"context_line":"                                                \u0027vol_id\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c60e9ce4","line":402,"updated":"2015-02-05 23:40:05.000000000","message":"I would like this to remain as CinderException.","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8170484de592821115c5d411879922f74a6daf31","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            # would be available for that volume in"},{"line_number":400,"context_line":"            # volume glance metadata table"},{"line_number":401,"context_line":"            pass"},{"line_number":402,"context_line":"        except Exception as ex:"},{"line_number":403,"context_line":"            LOG.exception(exception_template % {\u0027src_type\u0027: src_type,"},{"line_number":404,"context_line":"                                                \u0027src_id\u0027: src_id,"},{"line_number":405,"context_line":"                                                \u0027vol_id\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_05eceec6","line":402,"in_reply_to":"da86d52c_c60e9ce4","updated":"2015-02-08 23:46:53.000000000","message":"+1","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8170484de592821115c5d411879922f74a6daf31","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            pass"},{"line_number":402,"context_line":"        except Exception as ex:"},{"line_number":403,"context_line":"            LOG.exception(exception_template % {\u0027src_type\u0027: src_type,"},{"line_number":404,"context_line":"                                                \u0027src_id\u0027: src_id,"},{"line_number":405,"context_line":"                                                \u0027vol_id\u0027: volume_id})"},{"line_number":406,"context_line":"            raise exception.MetadataCopyFailure(reason\u003dex)"},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_65da0a19","line":404,"updated":"2015-02-08 23:46:53.000000000","message":"Since you are here, replacing %\u003d\u003e, will be ok","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"}],"cinder/volume/manager.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7876f487fcffff98859240a69774a5949ecf86eb","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                # would be available for that volume in"},{"line_number":574,"context_line":"                # volume glance metadata table"},{"line_number":575,"context_line":"                pass"},{"line_number":576,"context_line":"            except Exception as ex:"},{"line_number":577,"context_line":"                LOG.exception(_LE(\"Failed updating %(snapshot_id)s\""},{"line_number":578,"context_line":"                                  \" metadata using the provided volumes\""},{"line_number":579,"context_line":"                                  \" %(volume_id)s metadata\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_26f778d4","line":576,"updated":"2015-02-05 23:40:05.000000000","message":"I would like this to remain as CinderException.","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"},{"author":{"_account_id":10300,"name":"Pranali Deore","email":"pranalideore@gmail.com","username":"PranaliDeore"},"change_message_id":"74ec1cd790d8a300a89e9e08953eb59d77193876","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                # would be available for that volume in"},{"line_number":574,"context_line":"                # volume glance metadata table"},{"line_number":575,"context_line":"                pass"},{"line_number":576,"context_line":"            except Exception as ex:"},{"line_number":577,"context_line":"                LOG.exception(_LE(\"Failed updating %(snapshot_id)s\""},{"line_number":578,"context_line":"                                  \" metadata using the provided volumes\""},{"line_number":579,"context_line":"                                  \" %(volume_id)s metadata\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ab7ec367","line":576,"in_reply_to":"da86d52c_26f778d4","updated":"2015-02-06 09:36:28.000000000","message":"Hi Mike,\n\nI have caught generic exception because if DB service is down, it raises sqlalchemy.exc.OperationalError which will not be caught if CinderException is used. I have verified that No other exception will be raised except \u0027GlanceMetadataNotFound\u0027 and \u0027OperationalError\u0027 in this case. Please let me know your suggestion.","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8170484de592821115c5d411879922f74a6daf31","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                # would be available for that volume in"},{"line_number":574,"context_line":"                # volume glance metadata table"},{"line_number":575,"context_line":"                pass"},{"line_number":576,"context_line":"            except Exception as ex:"},{"line_number":577,"context_line":"                LOG.exception(_LE(\"Failed updating %(snapshot_id)s\""},{"line_number":578,"context_line":"                                  \" metadata using the provided volumes\""},{"line_number":579,"context_line":"                                  \" %(volume_id)s metadata\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_05030e74","line":576,"in_reply_to":"da86d52c_ab7ec367","updated":"2015-02-08 23:46:53.000000000","message":"Pranali, we can\u0027t say, that no more exception type will be in a future. Catching too general exception, could raise errors later. Also, in some cases oslo.db will raise own exception type instead of OperationalError","commit_id":"4634ca9598a7c114899a75914c1f4b42feec87a6"}]}