)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6edd4b4b022a41a1ea5f35c7efec138b0b8a818a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wuyuting \u003cwytdahu@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-07 20:31:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wrong loggin when volume type quota exceed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a volume type volume, if the quota"},{"line_number":10,"context_line":"has exceed, we can get a QuotaExceed Exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_71be5ad6","line":7,"updated":"2015-02-07 17:04:08.000000000","message":"loggin-\u003elogging","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8710c7eaa7988f5e54f26e11d10c7235b8cf6bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Wrong loggin when volume type quota exceed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a volume type volume, if the quota"},{"line_number":10,"context_line":"has exceed, we can get a QuotaExceed Exception."},{"line_number":11,"context_line":"However, when logging the exception, it compared"},{"line_number":12,"context_line":"with the none type quota, and give a wrong log."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_2091e952","line":10,"updated":"2015-02-07 21:50:47.000000000","message":"/exceed/been exceeded/","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8710c7eaa7988f5e54f26e11d10c7235b8cf6bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a volume type volume, if the quota"},{"line_number":10,"context_line":"has exceed, we can get a QuotaExceed Exception."},{"line_number":11,"context_line":"However, when logging the exception, it compared"},{"line_number":12,"context_line":"with the none type quota, and give a wrong log."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ice7ac2be5366f6834b9d876d63c573cf51542eb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_409edd64","line":11,"updated":"2015-02-07 21:50:47.000000000","message":"/compared/compares/","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8710c7eaa7988f5e54f26e11d10c7235b8cf6bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When create a volume type volume, if the quota"},{"line_number":10,"context_line":"has exceed, we can get a QuotaExceed Exception."},{"line_number":11,"context_line":"However, when logging the exception, it compared"},{"line_number":12,"context_line":"with the none type quota, and give a wrong log."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ice7ac2be5366f6834b9d876d63c573cf51542eb8"},{"line_number":15,"context_line":"Closes-Bug: 1419261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_8087f511","line":12,"updated":"2015-02-07 21:50:47.000000000","message":"/log/log message/","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"}],"cinder/tests/test_quota.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8710c7eaa7988f5e54f26e11d10c7235b8cf6bb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            db.volume_destroy(self.context, volume_id)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_too_many_volumes_of_type(self):"},{"line_number":106,"context_line":"        self.volume_type_name \u003d CONF.default_volume_type"},{"line_number":107,"context_line":"        self.volume_type \u003d db.volume_type_create("},{"line_number":108,"context_line":"            context.get_admin_context(),"},{"line_number":109,"context_line":"            dict(name\u003dself.volume_type_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_007b052a","line":106,"updated":"2015-02-07 21:50:47.000000000","message":"Since these are local to specific tests now and not done in setup just make these local variable and not instance variables.","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"}],"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8710c7eaa7988f5e54f26e11d10c7235b8cf6bb","unresolved":false,"context_lines":[{"line_number":583,"context_line":"                msg \u003d _(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":584,"context_line":"                        \"%(s_size)sG volume (%(d_consumed)dG \""},{"line_number":585,"context_line":"                        \"of %(d_quota)dG already consumed)\")"},{"line_number":586,"context_line":"                LOG.warn(msg % {\u0027s_pid\u0027: context.project_id,"},{"line_number":587,"context_line":"                                \u0027s_size\u0027: size,"},{"line_number":588,"context_line":"                                \u0027d_consumed\u0027: _consumed(gigabytes_name),"},{"line_number":589,"context_line":"                                \u0027d_quota\u0027: quotas[gigabytes_name]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_808e1526","line":586,"updated":"2015-02-07 21:50:47.000000000","message":"Just a recommendation, but since you are touching this code anyway it would be good to get these log messages converted to just pass in the formatting args to the logger and let it do the string formatting if and when needed. So instead of:\n\nLOG.warn(msg % [args])\n\ndo instead:\n\nLOG.warn(msg, [args])","commit_id":"082978dc9791c017a931fc4530110ddeb45b79f6"}]}