)]}'
{"id":"openstack%2Fcinder~15518","triplet_id":"openstack%2Fcinder~master~I7ae4decea42d8f070d774d3e6376686b3e5b4f83","project":"openstack/cinder","branch":"master","topic":"bug/1075675","hashtags":[],"change_id":"I7ae4decea42d8f070d774d3e6376686b3e5b4f83","subject":"Remove dm_setup(remove) call in volume_delete.","status":"MERGED","created":"2012-11-06 18:12:19.000000000","updated":"2012-11-07 01:55:59.000000000","submitted":"2012-11-07 01:55:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e7f2864e4a80f541245363b63d6e00db77be85b8","_number":15518,"virtual_id_number":15518,"owner":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2012-11-06 18:31:06.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2012-11-07 01:55:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2012-11-06 18:49:02.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-11-06 18:35:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":2,"date":"2012-11-06 18:27:14.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"date":"2012-11-06 22:28:32.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"all":[{"value":0,"date":"2012-11-06 18:49:02.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-11-06 18:35:53.000000000","_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"date":"2012-11-06 18:27:14.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"date":"2012-11-06 22:28:32.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-06 18:27:14.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2012-11-06 18:31:06.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-11-06 18:35:53.000000000","updated_by":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"reviewer":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"state":"REVIEWER"},{"updated":"2012-11-06 18:49:02.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2012-11-07 01:55:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"679f58334a53129e66e20eb0409177a1fe558e45","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2012-11-06 18:27:14.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"2a22ecf3f88d99dd02858960d4f749f6a287f26b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-11-06 18:31:10.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/44596\n\tLibvirt (Fedora 17) Running: http://smokestack.openstack.org/?go\u003d/jobs/44595\n","accounts_in_message":[],"_revision_number":1},{"id":"488ae4c05ceb2b3ef9ce9b06c12c14fbfe9ae45d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 18:32:36.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15518/1/check/gate-cinder-merge/1268 : SUCCESS\n- http://logs.openstack.org/15518/1/check/gate-cinder-docs/1176 : SUCCESS\n- http://logs.openstack.org/15518/1/check/gate-cinder-pep8/1215 : SUCCESS\n- http://logs.openstack.org/15518/1/check/gate-cinder-python26/1203 : SUCCESS\n- http://logs.openstack.org/15518/1/check/gate-cinder-python27/1215 : SUCCESS\n- http://logs.openstack.org/15518/1/check/gate-tempest-devstack-vm/17286 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"3a7ba9a1b764e8f7e0f51c511a3e4223c45f7870","author":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"date":"2012-11-06 18:35:53.000000000","message":"Patch Set 1: Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0ed893e314d14b10eba83e89174b2f5fc93de60e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 18:35:54.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"d4082ffd7f079f67bdd78cfe4db941b9f4a554d8","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2012-11-06 18:49:02.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nYeah I always sorta think removing the volume from under lvm with dmsetup was a bad idea.\n\nBut the original bug # 979020 may still be an issue for some people?  If so, we could catch the ProcessError/exitcode\u003d\u003d5 after _try_execute exhausts num_shell_retries and then do the `dmsetup remove` as a last resort?\n\nOTOH, I still sorta think if lvm is refusing to remove the volume because some process has an open handle even after retries and sleeps, we may not want to circumvent it...\n\nSo yeah I\u0027m fine with this as is.","accounts_in_message":[],"_revision_number":1},{"id":"6bdefd238aeae526521203dc51072a625d4e24ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 20:24:49.000000000","message":"Patch Set 1: Fails\n\nBuild failed\n\n- http://logs.openstack.org/15518/1/gate/gate-cinder-merge/1274 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-docs/1182 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-pep8/1221 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python26/1209 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python27/1221 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-tempest-devstack-vm/17319 : FAILURE\n","accounts_in_message":[],"_revision_number":1},{"id":"e5ca193ab3443541e49409ba3771ae2024f0036c","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-06 22:28:32.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"a632ca138266aa390eb2833d6c7fb2678d70c2ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 22:28:33.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"187a215dad0db4e9583323d2e26eafd2ca0843d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-07 00:57:20.000000000","message":"Patch Set 1: Fails\n\nBuild failed\n\n- http://logs.openstack.org/15518/1/gate/gate-cinder-merge/1280 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-docs/1188 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-pep8/1227 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python26/1215 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python27/1227 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-tempest-devstack-vm/17390 : FAILURE\n","accounts_in_message":[],"_revision_number":1},{"id":"a8a5671b33ee66cb4e2f5361a8517ff6faa71d08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-07 00:58:28.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"79826a12ce995c4d8791273c0a1b871fee3181a0","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-07 00:58:28.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"e844ef95c520ff6de8983b1fb4699684ff7fc67d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-07 01:55:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"8174e50961bb17add77bd632538ea720f4acaead","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-07 01:55:59.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15518/1/gate/gate-cinder-merge/1282 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-docs/1190 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-pep8/1229 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python26/1217 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-cinder-python27/1229 : SUCCESS\n- http://logs.openstack.org/15518/1/gate/gate-tempest-devstack-vm/17421 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c5f3a32178c09f03d617998d7b6d0559ea9e0ca3","revisions":{"c5f3a32178c09f03d617998d7b6d0559ea9e0ca3":{"kind":"REWORK","_number":1,"created":"2012-11-06 18:12:19.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/18/15518/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/18/15518/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/18/15518/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/18/15518/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/18/15518/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/18/15518/1"}}},"commit":{"parents":[{"commit":"84c9dd1ea899796793e9c9c79b0366b71e4a285a","subject":"Add ability to disable secure volume delete.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/84c9dd1ea899796793e9c9c79b0366b71e4a285a"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-11-06 18:08:58.000000000","tz":-420},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2012-11-06 18:12:18.000000000","tz":-420},"subject":"Remove dm_setup(remove) call in volume_delete.","message":"Remove dm_setup(remove) call in volume_delete.\n\nWhile it makes sense to perform the dm_setup(remove) before\nperforming the lvm remove, it seems to cause some buffer IO\nerrors as evident by kern.log.\n\nI\u0027m also a bit suspicous in that it seems the delete timeouts\nwe see seems to have increased in frequency with this addition.\nI propose this step is removed until we completely understand the\nimpact of the kernel error on Precise kernels.\n\nFixes bug: #1075675\n\nChange-Id: I7ae4decea42d8f070d774d3e6376686b3e5b4f83\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/c5f3a32178c09f03d617998d7b6d0559ea9e0ca3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/c5f3a32178c09f03d617998d7b6d0559ea9e0ca3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"84c9dd1ea899796793e9c9c79b0366b71e4a285a","is_merged_in_target_branch":true,"change_id":"I2a06e4f0021ba1f5d5aad7d0a5997a992e268858","change_number":15477,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}