)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d0622f23b310d48ac4a4c4996d2f4955f436a628","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additionally, since I found ETERNUS reuses DeviceID of deleted volume"},{"line_number":16,"context_line":"and it causes trouble when user delete using ETERNUS WebGUI/CLI"},{"line_number":17,"context_line":"not using OpenStack dashboard, I also fix this bug."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I004302c0bfd52325acc3ad703a17f09f7be833f9"},{"line_number":20,"context_line":"Closes-Bug: #1417351"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_7f68c021","line":17,"updated":"2015-02-16 04:11:22.000000000","message":"fixed","commit_id":"6f05f83c43099ac80ab31851f170f319fba9b4e9"}],"cinder/volume/drivers/fujitsu/eternus_dx_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d0622f23b310d48ac4a4c4996d2f4955f436a628","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                         \u0027rc\u0027: rc})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if rc !\u003d 0L:"},{"line_number":242,"context_line":"            if \"Job\" in job:"},{"line_number":243,"context_line":"                rc, errordesc \u003d self._wait_for_job_complete(self.conn, job)"},{"line_number":244,"context_line":"            else:"},{"line_number":245,"context_line":"                errordesc \u003d RETCODE_dic.get(six.text_type(rc), UNDEF_MSG)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ff2e70f9","line":242,"updated":"2015-02-16 04:11:22.000000000","message":"If this key word was spelled wrong, how can any operation that needs to wait for job completion be successful? This wait function is called in many places. Are you saying create volume is slower with the new firmware compared to the old firmware where you don\u0027t need to wait?\n\nAlso suggest that you make \u0027Job\u0027 a constant to avoid more mistakes on this. It is used in more than 1 places.","commit_id":"6f05f83c43099ac80ab31851f170f319fba9b4e9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5d1121e6be0c76f371e3d939873f28fcc42a1da4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                         \u0027rc\u0027: rc})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if rc !\u003d 0L:"},{"line_number":242,"context_line":"            if \"Job\" in job:"},{"line_number":243,"context_line":"                rc, errordesc \u003d self._wait_for_job_complete(self.conn, job)"},{"line_number":244,"context_line":"            else:"},{"line_number":245,"context_line":"                errordesc \u003d RETCODE_dic.get(six.text_type(rc), UNDEF_MSG)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2de5e7a3","line":242,"in_reply_to":"da86d52c_2780a8be","updated":"2015-02-18 04:06:05.000000000","message":"Thanks for the explanation.","commit_id":"6f05f83c43099ac80ab31851f170f319fba9b4e9"},{"author":{"_account_id":10674,"name":"Yusuke Hayashi","email":"yusuke.hayashi.710@gmail.com","username":"YusukeHayashi"},"change_message_id":"22351738211a026447567d6e8969fee4c07a2d2d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                         \u0027rc\u0027: rc})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if rc !\u003d 0L:"},{"line_number":242,"context_line":"            if \"Job\" in job:"},{"line_number":243,"context_line":"                rc, errordesc \u003d self._wait_for_job_complete(self.conn, job)"},{"line_number":244,"context_line":"            else:"},{"line_number":245,"context_line":"                errordesc \u003d RETCODE_dic.get(six.text_type(rc), UNDEF_MSG)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2780a8be","line":242,"in_reply_to":"da86d52c_ff2e70f9","updated":"2015-02-18 02:40:16.000000000","message":"Our old firmware does not use job mechanism.I mean that it does not reply to requester until finishing requested operation,\nalthough many smis-s provider regulary replies return-value 4096 while waiting job completion.\nThis is why, in old firmware,  [if \"job\" in job] is always false and _wait_for_job_complete was never called.\n\nBut, since new firmware uses job mechanism and it includes job-infomation in \u0027Job\u0027 key not \u0027job\u0027 key, this volume driver do not work in new firmware in operation related to copy(e.g. createClonedVolume).\n\nAnd, since I heard ETERNUS SMI-S Provider will use 4096 value while waing job completion in 2015ver, I prepared this sentences to prepare for future ETERNUS firmware update. Unfortunately, I misunderstood keyword\u0027s letter.\n\nAlso, since this sentence is always false in \"create volume\", \"extend volume\" in even new firmware, I will remove sentences l.242,l.1044 in patch set 2.\n\nthanks.","commit_id":"6f05f83c43099ac80ab31851f170f319fba9b4e9"}]}