)]}'
{"cinder/keymgr/barbican.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"0e9708cb6926b5bdeb73597fdf2568618ab0e54d","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param ctxt: the user context for authentication"},{"line_number":55,"context_line":"        :return: a Barbican Client object"},{"line_number":56,"context_line":"        :throws NotAuthorized: if the ctxt is None"},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if not self._barbican_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_dd34b4fd","line":56,"updated":"2015-03-09 20:18:09.000000000","message":":throws KeyManagerError: if ctxt is missing project_id or project_id is None","commit_id":"d79d4b5f713b6197aa90ee3706af1ac1496f1fa4"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"5f620ba957e610cd05cb31533b6198598b36dfd0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        :param ctxt: the user context for authentication"},{"line_number":55,"context_line":"        :return: a Barbican Client object"},{"line_number":56,"context_line":"        :throws NotAuthorized: if the ctxt is None"},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        if not self._barbican_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_50b26b4c","line":56,"in_reply_to":"9a80dd14_dd34b4fd","updated":"2015-03-09 20:26:07.000000000","message":"Good point.  Done.","commit_id":"d79d4b5f713b6197aa90ee3706af1ac1496f1fa4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"f8929efa58474a1a635e63e7c8e31f174195b213","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if not self._barbican_client:"},{"line_number":62,"context_line":"            # Confirm context is provided, if not raise not authorized"},{"line_number":63,"context_line":"            if not ctxt:"},{"line_number":64,"context_line":"                msg \u003d _(\"User is not authorized to use key manager.\")"},{"line_number":65,"context_line":"                LOG.error(msg)"},{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_aeaa5682","line":64,"updated":"2015-03-10 08:13:12.000000000","message":"_LE as well","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e7dd6b03471ca271c379df6342fd5331070ffaf6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if not self._barbican_client:"},{"line_number":62,"context_line":"            # Confirm context is provided, if not raise not authorized"},{"line_number":63,"context_line":"            if not ctxt:"},{"line_number":64,"context_line":"                msg \u003d _(\"User is not authorized to use key manager.\")"},{"line_number":65,"context_line":"                LOG.error(msg)"},{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_9b04e04a","line":64,"in_reply_to":"9a80dd14_60dcdd46","updated":"2015-03-10 15:18:38.000000000","message":"I will leave it as is.  See http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"613146757285020e3c7f4889c54905b46eeb1972","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if not self._barbican_client:"},{"line_number":62,"context_line":"            # Confirm context is provided, if not raise not authorized"},{"line_number":63,"context_line":"            if not ctxt:"},{"line_number":64,"context_line":"                msg \u003d _(\"User is not authorized to use key manager.\")"},{"line_number":65,"context_line":"                LOG.error(msg)"},{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_60dcdd46","line":64,"in_reply_to":"9a80dd14_aeaa5682","updated":"2015-03-10 13:35:39.000000000","message":"This is used for both logging and as the exception message. So the current _() is correct.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"f8929efa58474a1a635e63e7c8e31f174195b213","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if not hasattr(ctxt, \u0027project_id\u0027) or ctxt.project_id is None:"},{"line_number":69,"context_line":"                msg \u003d _(\"Unable to create Barbican Client without project_id.\")"},{"line_number":70,"context_line":"                LOG.error(msg)"},{"line_number":71,"context_line":"                raise exception.KeyManagerError(msg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_2e54a6c8","line":69,"updated":"2015-03-10 08:13:12.000000000","message":"please use _LE instead of _, since this is the log error message.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"613146757285020e3c7f4889c54905b46eeb1972","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if not hasattr(ctxt, \u0027project_id\u0027) or ctxt.project_id is None:"},{"line_number":69,"context_line":"                msg \u003d _(\"Unable to create Barbican Client without project_id.\")"},{"line_number":70,"context_line":"                LOG.error(msg)"},{"line_number":71,"context_line":"                raise exception.KeyManagerError(msg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e0efede6","line":69,"in_reply_to":"9a80dd14_2e54a6c8","updated":"2015-03-10 13:35:39.000000000","message":"Same.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e7dd6b03471ca271c379df6342fd5331070ffaf6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                raise exception.NotAuthorized(msg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if not hasattr(ctxt, \u0027project_id\u0027) or ctxt.project_id is None:"},{"line_number":69,"context_line":"                msg \u003d _(\"Unable to create Barbican Client without project_id.\")"},{"line_number":70,"context_line":"                LOG.error(msg)"},{"line_number":71,"context_line":"                raise exception.KeyManagerError(msg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_fbf5dc50","line":69,"in_reply_to":"9a80dd14_e0efede6","updated":"2015-03-10 15:18:38.000000000","message":"I will leave as is.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"}],"cinder/tests/keymgr/test_barbican.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"f8929efa58474a1a635e63e7c8e31f174195b213","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.key_mgr._barbican_client \u003d None"},{"line_number":242,"context_line":"        del self.ctxt.project_id"},{"line_number":243,"context_line":"        self.assertRaises(exception.KeyManagerError,"},{"line_number":244,"context_line":"                          self.key_mgr.create_key, self.ctxt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_aefdf66f","line":244,"updated":"2015-03-10 08:13:12.000000000","message":"I suggest you add one test with the correct \"project_id\" input to test if the method identity.v3.Token is really called with the project_id parameter.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"e7dd6b03471ca271c379df6342fd5331070ffaf6","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.key_mgr._barbican_client \u003d None"},{"line_number":242,"context_line":"        del self.ctxt.project_id"},{"line_number":243,"context_line":"        self.assertRaises(exception.KeyManagerError,"},{"line_number":244,"context_line":"                          self.key_mgr.create_key, self.ctxt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_9b493b35","line":244,"in_reply_to":"9a80dd14_aefdf66f","updated":"2015-03-10 15:18:38.000000000","message":"Good suggestion.  Included in the next patch.","commit_id":"dac3f60ed8e4f061bff09b15ae1c29d596341d35"}]}