)]}'
{"cinder/volume/drivers/netapp/eseries/iscsi.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"50eae7fcbd705dc0e69ed05558799ef5b0213f56","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027sas\u0027: \u0027SAS\u0027,"},{"line_number":92,"context_line":"        \u0027sata\u0027: \u0027SATA\u0027,"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"    SSC_UPDATE_INTERVAL \u003d 60  # seconds"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":97,"context_line":"        super(NetAppEseriesISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_564a8383","line":94,"updated":"2015-02-18 23:13:43.000000000","message":"Is there a reason this isn\u0027t configurable?","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1293c853e672a37412c98ceaed10fea40c47bbcc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027sas\u0027: \u0027SAS\u0027,"},{"line_number":92,"context_line":"        \u0027sata\u0027: \u0027SATA\u0027,"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"    SSC_UPDATE_INTERVAL \u003d 60  # seconds"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":97,"context_line":"        super(NetAppEseriesISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_02007ea9","line":94,"in_reply_to":"ba7be1f8_f7edeaf0","updated":"2015-02-20 01:16:42.000000000","message":"I would agree with Jay and suggest that this to be configurable. I\u0027m not sure if there\u0027s any performance impact by adding the periodic update. So it is good to make the interval adjustable.","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"b8076fd5a3684728c52ed10fe728703377dd058c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027sas\u0027: \u0027SAS\u0027,"},{"line_number":92,"context_line":"        \u0027sata\u0027: \u0027SATA\u0027,"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":"    SSC_UPDATE_INTERVAL \u003d 60  # seconds"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":97,"context_line":"        super(NetAppEseriesISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f7edeaf0","line":94,"in_reply_to":"da86d52c_564a8383","updated":"2015-02-20 00:38:26.000000000","message":"I\u0027m not sure there is a lot to be gained by allowing a deployer to tweak this, then it would just be yet another variable between deployments. I think if it does show itself to be useful we can add it in the future. Good thing to think about though.","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"c17d3f7b0afd1bcb87905b276326c70f4fd9aba0","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        The self._ssc_stats attribute is updated with the following format."},{"line_number":790,"context_line":"        {\u003cvolume_group_ref\u003e : {\u003cssc_key\u003e: \u003cssc_value\u003e}}"},{"line_number":791,"context_line":"        \"\"\""},{"line_number":792,"context_line":"        LOG.info(_(\"Updating storage service catalog information for backend \""},{"line_number":793,"context_line":"                   \"\u0027%s\u0027\") % self._backend_name)"},{"line_number":794,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":795,"context_line":"            self._update_ssc_disk_encryption(self._objects[\"disk_pool_refs\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_d6a2f398","line":792,"updated":"2015-02-18 22:57:56.000000000","message":"Use markers: http://docs.openstack.org/developer/oslo.i18n/usage.html","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"b8076fd5a3684728c52ed10fe728703377dd058c","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        The self._ssc_stats attribute is updated with the following format."},{"line_number":790,"context_line":"        {\u003cvolume_group_ref\u003e : {\u003cssc_key\u003e: \u003cssc_value\u003e}}"},{"line_number":791,"context_line":"        \"\"\""},{"line_number":792,"context_line":"        LOG.info(_(\"Updating storage service catalog information for backend \""},{"line_number":793,"context_line":"                   \"\u0027%s\u0027\") % self._backend_name)"},{"line_number":794,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":795,"context_line":"            self._update_ssc_disk_encryption(self._objects[\"disk_pool_refs\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_57ab1689","line":792,"in_reply_to":"da86d52c_d6a2f398","updated":"2015-02-20 00:38:26.000000000","message":"Ah yes, will do!","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1293c853e672a37412c98ceaed10fea40c47bbcc","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        \"\"\""},{"line_number":792,"context_line":"        LOG.info(_(\"Updating storage service catalog information for backend \""},{"line_number":793,"context_line":"                   \"\u0027%s\u0027\") % self._backend_name)"},{"line_number":794,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":795,"context_line":"            self._update_ssc_disk_encryption(self._objects[\"disk_pool_refs\"])"},{"line_number":796,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":797,"context_line":"            self._update_ssc_disk_types(self._objects[\"disk_pool_refs\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_426356b1","line":794,"updated":"2015-02-20 01:16:42.000000000","message":"()","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1293c853e672a37412c98ceaed10fea40c47bbcc","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                   \"\u0027%s\u0027\") % self._backend_name)"},{"line_number":794,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":795,"context_line":"            self._update_ssc_disk_encryption(self._objects[\"disk_pool_refs\"])"},{"line_number":796,"context_line":"        self._ssc_stats \u003d \\"},{"line_number":797,"context_line":"            self._update_ssc_disk_types(self._objects[\"disk_pool_refs\"])"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"    def _update_ssc_disk_types(self, volume_groups):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_62585afb","line":796,"updated":"2015-02-20 01:16:42.000000000","message":"()","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1293c853e672a37412c98ceaed10fea40c47bbcc","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                ssc_stats[current_vol_group][\u0027netapp_disk_type\u0027] \u003d \u0027SSD\u0027"},{"line_number":815,"context_line":"            else:"},{"line_number":816,"context_line":"                disk_type \u003d drive.get(\u0027interfaceType\u0027).get(\u0027driveType\u0027)"},{"line_number":817,"context_line":"                ssc_stats[current_vol_group][\u0027netapp_disk_type\u0027] \u003d \\"},{"line_number":818,"context_line":"                    self.SSC_DISK_TYPE_MAPPING.get(disk_type, \u0027unknown\u0027)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        return ssc_stats"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_c26e6696","line":817,"updated":"2015-02-20 01:16:42.000000000","message":"()","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1293c853e672a37412c98ceaed10fea40c47bbcc","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            if current_vol_group not in ssc_stats:"},{"line_number":834,"context_line":"                ssc_stats[current_vol_group] \u003d {}"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"            ssc_stats[current_vol_group][\u0027netapp_disk_encryption\u0027] \u003d \u0027true\u0027 \\"},{"line_number":837,"context_line":"                if pool[\u0027securityType\u0027] \u003d\u003d \u0027enabled\u0027 else \u0027false\u0027"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        return ssc_stats"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_222ca24a","line":836,"updated":"2015-02-20 01:16:42.000000000","message":"()","commit_id":"24d744355e9696743214cba8c42e21b6985596e4"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"3b8c2618c90c57a6690506ccbfbb198d8c4b2c4b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            system \u003d self._client.list_storage_system()"},{"line_number":192,"context_line":"        except exception.NetAppDriverException:"},{"line_number":193,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":194,"context_line":"                msg \u003d _LI(\"System with controller addresses [%s] is not\""},{"line_number":195,"context_line":"                          \" registered with web service.\")"},{"line_number":196,"context_line":"                LOG.info(msg % self.configuration.netapp_controller_ips)"},{"line_number":197,"context_line":"        password_not_in_sync \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_ce575001","line":194,"updated":"2015-02-20 19:34:51.000000000","message":"Can\u0027t we combine the msg to the LOG.info and pass _LI would help in code clarity.","commit_id":"2406d5fef94d6828d4b247114ce0583c896ff163"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5040850a56c2823e40479ff843fd67fcd2142ac7","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            system \u003d self._client.list_storage_system()"},{"line_number":192,"context_line":"        except exception.NetAppDriverException:"},{"line_number":193,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":194,"context_line":"                msg \u003d _LI(\"System with controller addresses [%s] is not\""},{"line_number":195,"context_line":"                          \" registered with web service.\")"},{"line_number":196,"context_line":"                LOG.info(msg % self.configuration.netapp_controller_ips)"},{"line_number":197,"context_line":"        password_not_in_sync \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b13189ee","line":194,"in_reply_to":"ba7be1f8_ce575001","updated":"2015-02-21 22:08:28.000000000","message":"Yes, this would be a good change but I don\u0027t think it we need to hold up the patch for it.","commit_id":"2406d5fef94d6828d4b247114ce0583c896ff163"}]}