)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"9ecb6be32cb65417ae2acc9a63fb9decb2ca66c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wanghao \u003cwanghao749@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-04 10:25:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"non-admin user to query volume filter by az"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limit non-admin user to query volume just filter by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard code in cinder-api. So improve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3acd31a7_0db96979","line":7,"updated":"2015-05-04 21:41:05.000000000","message":"Try to start the message with capital letters.","commit_id":"3d8af04f4d286d9e3ada492b0b92ebc6d30bbe3a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"84d35ea5f1cd0bd6d598e14e3a0778634356a45b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wanghao \u003cwanghao749@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-04 10:25:21 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"non-admin user to query volume filter by az"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limit non-admin user to query volume just filter by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard code in cinder-api. So improve"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1aca2d91_fc253dae","line":7,"in_reply_to":"3acd31a7_0db96979","updated":"2015-05-06 03:11:38.000000000","message":"Done","commit_id":"3d8af04f4d286d9e3ada492b0b92ebc6d30bbe3a"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"72f60a965f253d01f1e14fd523a2bda77401d3fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Non-admin user to query volume filter by az"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limit non-admin user to query volume just filter by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard code in cinder-api. So improve"},{"line_number":11,"context_line":"this using config option and allow non-admin to query volume filter by"},{"line_number":12,"context_line":"\u0027availability zone\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a016987_5a18291e","line":9,"updated":"2015-05-20 09:34:20.000000000","message":"limit \u003d\u003e limits. filter \u003d\u003e filtered.","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"72f60a965f253d01f1e14fd523a2bda77401d3fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Non-admin user to query volume filter by az"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limit non-admin user to query volume just filter by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard code in cinder-api. So improve"},{"line_number":11,"context_line":"this using config option and allow non-admin to query volume filter by"},{"line_number":12,"context_line":"\u0027availability zone\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a016987_dadad94a","line":10,"updated":"2015-05-20 09:34:20.000000000","message":"code \u003d\u003e coded","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"72f60a965f253d01f1e14fd523a2bda77401d3fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limit non-admin user to query volume just filter by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard code in cinder-api. So improve"},{"line_number":11,"context_line":"this using config option and allow non-admin to query volume filter by"},{"line_number":12,"context_line":"\u0027availability zone\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a016987_7ae64516","line":11,"updated":"2015-05-20 09:34:20.000000000","message":"filter \u003d\u003e filtered","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af63a1e91267ee56c66431825ed201505922fc5f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Non-admin user to query volume filter by az"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now cinder limits non-admin user to query volume just filtered by \u0027name\u0027,"},{"line_number":10,"context_line":"\u0027status\u0027, and \u0027metadata\u0027, those is hard coded in cinder-api. So improve"},{"line_number":11,"context_line":"this using config option and allow non-admin to query volume filtered by"},{"line_number":12,"context_line":"\u0027availability zone\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5afe65bd_cdbaab6e","line":10,"updated":"2015-06-02 03:17:08.000000000","message":"/those is/those are/","commit_id":"94ab610ad93690bffbb5634662266bc202307317"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"f67cb521548a563aacdb01c106a5a02e28d64dc3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"query_volume_filters_opt \u003d cfg.ListOpt(\u0027query_volume_filters\u0027,"},{"line_number":42,"context_line":"                                       default\u003d[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027],"},{"line_number":43,"context_line":"                                       help\u003d\u0027Volume filter options which\u0027"},{"line_number":44,"context_line":"                                            \u0027non-admin user could use to\u0027"},{"line_number":45,"context_line":"                                            \u0027query volume\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_a3005fab","line":43,"updated":"2015-03-05 09:20:13.000000000","message":"I think you should specify possible values in help","commit_id":"b11160d3239dba7a01683690cc6fcce3cab78b22"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e6612b5a6bfccb5e34a6bbddc07dd2c521e1e422","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"query_volume_filters_opt \u003d cfg.ListOpt(\u0027query_volume_filters\u0027,"},{"line_number":42,"context_line":"                                       default\u003d[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027],"},{"line_number":43,"context_line":"                                       help\u003d\u0027Volume filter options which\u0027"},{"line_number":44,"context_line":"                                            \u0027non-admin user could use to\u0027"},{"line_number":45,"context_line":"                                            \u0027query volume\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_9c837e55","line":43,"updated":"2015-03-06 06:59:59.000000000","message":"You need a space after \"which\" and \"use to\".","commit_id":"b11160d3239dba7a01683690cc6fcce3cab78b22"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c01512d76497361d7c23636138026a0a6dfe613f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"query_volume_filters_opt \u003d cfg.ListOpt(\u0027query_volume_filters\u0027,"},{"line_number":42,"context_line":"                                       default\u003d[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027],"},{"line_number":43,"context_line":"                                       help\u003d\u0027Volume filter options which\u0027"},{"line_number":44,"context_line":"                                            \u0027non-admin user could use to\u0027"},{"line_number":45,"context_line":"                                            \u0027query volume\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_3a3e0d29","line":43,"in_reply_to":"9a80dd14_9c837e55","updated":"2015-03-06 10:11:28.000000000","message":"Done","commit_id":"b11160d3239dba7a01683690cc6fcce3cab78b22"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c01512d76497361d7c23636138026a0a6dfe613f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"query_volume_filters_opt \u003d cfg.ListOpt(\u0027query_volume_filters\u0027,"},{"line_number":42,"context_line":"                                       default\u003d[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027],"},{"line_number":43,"context_line":"                                       help\u003d\u0027Volume filter options which\u0027"},{"line_number":44,"context_line":"                                            \u0027non-admin user could use to\u0027"},{"line_number":45,"context_line":"                                            \u0027query volume\u0027)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1173feb1","line":43,"in_reply_to":"9a80dd14_a3005fab","updated":"2015-03-06 10:11:28.000000000","message":"Sure.","commit_id":"b11160d3239dba7a01683690cc6fcce3cab78b22"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d4b5e67667aed02a73bea0167b4e9f20d0dc2881","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                            \"non-admin user could use to \""},{"line_number":45,"context_line":"                                            \"query volume. For example: \""},{"line_number":46,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \""},{"line_number":47,"context_line":"                                            \"\u0027availability_zone\u0027]\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opt(query_volume_filters_opt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab921fb_c31267b4","line":47,"updated":"2015-04-23 19:34:21.000000000","message":"Please, specify default value in a help message","commit_id":"0a68e3fe439e3d5cd27e01a309bfcee06fae4e04"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9dd481ad5e0d0d1b6c2290fb41b204f9a8d3a58e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                            \"non-admin user could use to \""},{"line_number":45,"context_line":"                                            \"query volume. For example: \""},{"line_number":46,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \""},{"line_number":47,"context_line":"                                            \"\u0027availability_zone\u0027]\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opt(query_volume_filters_opt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab921fb_fb5f403f","line":47,"in_reply_to":"bab921fb_c31267b4","updated":"2015-04-24 03:36:18.000000000","message":"Done","commit_id":"0a68e3fe439e3d5cd27e01a309bfcee06fae4e04"},{"author":{"_account_id":7111,"name":"hadi esiely","email":"hadi.esiely-barrera@jhuapl.edu","username":"HEsiely"},"change_message_id":"4d5a96feb5126ae22ff5a520f05de1904507ce6e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                            \"non-admin user could use to \""},{"line_number":45,"context_line":"                                            \"query volume. default value is: \""},{"line_number":46,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027]\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"CONF \u003d cfg.CONF"},{"line_number":49,"context_line":"CONF.register_opt(query_volume_filters_opt)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3acd31a7_dc2365a6","line":47,"updated":"2015-04-30 21:38:43.000000000","message":"availability zones are not being added to the volume query filters. I thought that was one of the goals for this feature?","commit_id":"36944f2ef9518897303e9cff56e4bbb573e32691"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"eeea51b29870643a0aad3384daf526a417e7f361","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                            \"non-admin user could use to \""},{"line_number":45,"context_line":"                                            \"query volume. default value is: \""},{"line_number":46,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027]\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"CONF \u003d cfg.CONF"},{"line_number":49,"context_line":"CONF.register_opt(query_volume_filters_opt)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3acd31a7_959d9a5b","line":47,"in_reply_to":"3acd31a7_dc2365a6","updated":"2015-05-04 02:22:29.000000000","message":"Emm, adding az to default filters is good idea, thanks.","commit_id":"36944f2ef9518897303e9cff56e4bbb573e32691"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"9ecb6be32cb65417ae2acc9a63fb9decb2ca66c3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                \u0027availability_zone\u0027],"},{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volume. default value is: \""},{"line_number":47,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027availability_zone\u0027]\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_6d7b3df6","line":46,"updated":"2015-05-04 21:41:05.000000000","message":"Default (Capital D)","commit_id":"3d8af04f4d286d9e3ada492b0b92ebc6d30bbe3a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"84d35ea5f1cd0bd6d598e14e3a0778634356a45b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                \u0027availability_zone\u0027],"},{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volume. default value is: \""},{"line_number":47,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027availability_zone\u0027]\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aca2d91_9c2409b0","line":46,"in_reply_to":"3acd31a7_6d7b3df6","updated":"2015-05-06 03:11:38.000000000","message":"Thanks :)","commit_id":"3d8af04f4d286d9e3ada492b0b92ebc6d30bbe3a"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"72f60a965f253d01f1e14fd523a2bda77401d3fc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                \u0027availability_zone\u0027],"},{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volume. Default value is: \""},{"line_number":47,"context_line":"                                            \"[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027availability_zone\u0027]\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_3aec4df2","line":46,"updated":"2015-05-20 09:34:20.000000000","message":"volume \u003d\u003e volumes. \"value is\" \u003d\u003e \"values are\"","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"a4f26ef7498f128b8e5d202f63af2f56546c4310","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                \u0027availability_zone\u0027],"},{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volumed. Default values \""},{"line_number":47,"context_line":"                                            \"are: [\u0027name\u0027, \u0027status\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027metadata\u0027, \u0027availability_zone\u0027]\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_6c109659","line":46,"updated":"2015-06-01 13:44:24.000000000","message":"nit: volumed -\u003e volumes","commit_id":"8182f122bd310ea4cfb4f5cf66dd9ff80a434bbd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7b1d659dc8bf45c5bb90f9c6e341456221192a72","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                       default\u003d[\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027,"},{"line_number":43,"context_line":"                                                \u0027availability_zone\u0027],"},{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volumes. Default values \""},{"line_number":47,"context_line":"                                            \"are: [\u0027name\u0027, \u0027status\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027metadata\u0027, \u0027availability_zone\u0027]\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_cfe023cf","line":45,"updated":"2015-06-03 10:40:35.000000000","message":"s/could/can","commit_id":"1d122d8152ac317ef976da6d446e8dd76a84adcd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7b1d659dc8bf45c5bb90f9c6e341456221192a72","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                       help\u003d\"Volume filter options which \""},{"line_number":45,"context_line":"                                            \"non-admin user could use to \""},{"line_number":46,"context_line":"                                            \"query volumes. Default values \""},{"line_number":47,"context_line":"                                            \"are: [\u0027name\u0027, \u0027status\u0027, \""},{"line_number":48,"context_line":"                                            \"\u0027metadata\u0027, \u0027availability_zone\u0027]\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_ef2bdfe9","line":47,"updated":"2015-06-03 10:40:35.000000000","message":"s/values are/value is\n or\ns/values are/fields are","commit_id":"1d122d8152ac317ef976da6d446e8dd76a84adcd"}],"cinder/tests/api/v2/test_volumes.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"1ae652f5bbc200c862c24c28dcf20e18a23e0f24","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"    def test_get_volume_filter_options(self):"},{"line_number":1582,"context_line":"        self.assertEqual([\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027],"},{"line_number":1583,"context_line":"                         self.controller._get_volume_filter_options())"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"class VolumeSerializerTest(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_92aade6e","line":1583,"updated":"2015-03-04 20:56:02.000000000","message":"Please, add tests which will verify that filters use value from a config","commit_id":"1e60ef2e457772c0b3fbb3baa159b1d0c0b56261"}],"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"72f60a965f253d01f1e14fd523a2bda77401d3fc","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"            sort_keys\u003d[\u0027created_at\u0027], sort_dirs\u003d[\u0027desc\u0027],"},{"line_number":1566,"context_line":"            filters\u003d{\u0027display_name\u0027: \u0027d-\u0027}, viewable_admin_meta\u003dTrue)"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    def test_get_volume_filter_options(self):"},{"line_number":1569,"context_line":"        self.assertEqual([\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \u0027availability_zone\u0027],"},{"line_number":1570,"context_line":"                         self.controller._get_volume_filter_options())"},{"line_number":1571,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_1a919147","line":1568,"updated":"2015-05-20 09:34:20.000000000","message":"I think you might need to add a test case using \u0027availability_zone\u0027 to filter volumes. So that it ensures actually \u0027availability_zone\u0027 filter works.","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"9d495981ec529320e49e38e8cd48c17c8f22368c","unresolved":false,"context_lines":[{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    def test_get_volume_filter_options(self):"},{"line_number":1569,"context_line":"        self.assertEqual([\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \u0027availability_zone\u0027],"},{"line_number":1570,"context_line":"                         self.controller._get_volume_filter_options())"},{"line_number":1571,"context_line":""},{"line_number":1572,"context_line":"    def test_get_volume_filter_options_using_config(self):"},{"line_number":1573,"context_line":"        self.override_config(\u0027query_volume_filters\u0027, [\u0027name\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_a8244c5f","line":1570,"updated":"2015-05-31 14:29:33.000000000","message":"I\u0027m not sure this unit test is testing anything useful... if we change that list, we\u0027ll have to change this test, but you aren\u0027t actually making any useful statement about the code.\n\nA better unit test would be something that tests all 4 filter behaviours, since what that test is stating is \u0027the api code needs to be able to filter by these things\u0027","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"37a7ba80ff31ad7a1d50a88588863ecffccc8d48","unresolved":false,"context_lines":[{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    def test_get_volume_filter_options(self):"},{"line_number":1569,"context_line":"        self.assertEqual([\u0027name\u0027, \u0027status\u0027, \u0027metadata\u0027, \u0027availability_zone\u0027],"},{"line_number":1570,"context_line":"                         self.controller._get_volume_filter_options())"},{"line_number":1571,"context_line":""},{"line_number":1572,"context_line":"    def test_get_volume_filter_options_using_config(self):"},{"line_number":1573,"context_line":"        self.override_config(\u0027query_volume_filters\u0027, [\u0027name\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_6a61a404","line":1570,"in_reply_to":"7a016987_a8244c5f","updated":"2015-06-01 06:56:27.000000000","message":"@Accela and Duncan, I got your point. Will update this test in next patch. Thanks.","commit_id":"3a1eb002f1a19f74d86bd217bed0e98fdadc02a1"}]}