)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-02-16 10:41:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD for NOVA."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"See also the spec at https://review.openstack.org/#/c/134153/;"},{"line_number":10,"context_line":"Nova changes are  at https://review.openstack.org/#/c/149244/."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_db30b3ea","line":8,"updated":"2015-02-23 21:09:33.000000000","message":"Please, add more detailed commit message.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"}],"cinder/brick/initiator/connector.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        LOG.error(\"connection_properties %s\" % connection_properties)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        # TODO: with consistency groups multiple minors in one res!"},{"line_number":652,"context_line":"        # volume 0 { device minor 10; "},{"line_number":653,"context_line":"        #re_match \u003d re.search(r\u0027volume \\d+ .* device minor (\\d+)\u0027,"},{"line_number":654,"context_line":"        #        connection_properties[\u0027res\u0027])"},{"line_number":655,"context_line":"        #if not re_match:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4046927d","line":652,"updated":"2015-02-23 21:09:33.000000000","message":"Please, remove trailing space and commented code","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"31f796f513b4762dcf01660e5d28440aab6d5ab7","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    def disconnect_volume(self, connection_properties, device_info):"},{"line_number":669,"context_line":"        LOG.error(\"connection_properties %s\" % (connection_properties))"},{"line_number":670,"context_line":"        LOG.error(\"device_info %s\" % device_info)"},{"line_number":671,"context_line":"\treturn"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class FibreChannelConnector(InitiatorConnector):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d46ea595","line":671,"updated":"2015-05-26 19:22:41.000000000","message":"Please remove some strange character here.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"}],"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # Copied from the LVM driver, see"},{"line_number":93,"context_line":"        # I43190d1dac33748fe55fa00f260f32ab209be656"},{"line_number":94,"context_line":"        LOG.error(\"iscsi_helper is %s\", self.configuration.safe_get(\u0027iscsi_helper\u0027))"},{"line_number":95,"context_line":"        target_driver \u003d \\"},{"line_number":96,"context_line":"            self.target_mapping[self.configuration.safe_get(\u0027iscsi_helper\u0027)]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a0210eb6","line":94,"updated":"2015-02-23 21:09:33.000000000","message":"Please, use  LOG.error(_LE(msg)) to make it localizable accourding to the Logging guidelines here and below","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":494,"context_line":"    # #######  Interface methods for DataPath (Target Driver) ########"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":497,"context_line":"        LOG.error(\"ensure: context %s, volume %s\" % (vars(context), vars(volume)))"},{"line_number":498,"context_line":"        volume_path \u003d self.local_path(volume)"},{"line_number":499,"context_line":"        return self.target_driver.ensure_export("},{"line_number":500,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a0082e2e","line":497,"updated":"2015-02-23 21:09:33.000000000","message":"Please, change % \u003d\u003e , here and below","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"31f796f513b4762dcf01660e5d28440aab6d5ab7","unresolved":false,"context_lines":[{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        volume_path \u003d self.local_path(volume)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        data \u003d { "},{"line_number":586,"context_line":"            # needs to match entry in \"nova volume-type-list\"?"},{"line_number":587,"context_line":"           \u0027driver_volume_type\u0027: \u0027drbdmanage\u0027,"},{"line_number":588,"context_line":"            \u0027data\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_142afd2c","line":585,"updated":"2015-05-26 19:22:41.000000000","message":"Please remove the extra space here.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT])"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        if len(data) \u003c 1:"},{"line_number":612,"context_line":"            # already removed?!"},{"line_number":613,"context_line":"            pass"},{"line_number":614,"context_line":"        elif len(data) \u003d\u003d 1:"},{"line_number":615,"context_line":"            _, _, props, _ \u003d data[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3b0b8f26","line":612,"updated":"2015-02-23 21:09:33.000000000","message":"Could it be 0?","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"31f796f513b4762dcf01660e5d28440aab6d5ab7","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            _, _, props, _ \u003d data[0]"},{"line_number":616,"context_line":"            # If diskless assigned,"},{"line_number":617,"context_line":"            if dm_const.BOOL_TRUE \u003d\u003d getattr(props,"},{"line_number":618,"context_line":"                    dm_const.FLAG_DISKLESS, "},{"line_number":619,"context_line":"                    dm_const.BOOL_FALSE):"},{"line_number":620,"context_line":"                # remove the assignment"},{"line_number":621,"context_line":"                # TODO(pm): does it make sense to relay \"force\" here?"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_74d25136","line":618,"updated":"2015-05-26 19:22:41.000000000","message":"Plesae remove the extra space here.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"31f796f513b4762dcf01660e5d28440aab6d5ab7","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT])"},{"line_number":626,"context_line":"        else:"},{"line_number":627,"context_line":"            # more than one assignment?"},{"line_number":628,"context_line":"            LOG.warn(_(\"DRBDmanage: too many assignments returned.\"))"},{"line_number":629,"context_line":"        return"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f4e64115","line":628,"updated":"2015-05-26 19:22:41.000000000","message":"LOG.warn has been depricated by LOG.warning.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT])"},{"line_number":626,"context_line":"        else:"},{"line_number":627,"context_line":"            # more than one assignment?"},{"line_number":628,"context_line":"            LOG.warn(_(\"DRBDmanage: too many assignments returned.\"))"},{"line_number":629,"context_line":"        return"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_db19937a","line":628,"updated":"2015-02-23 21:09:33.000000000","message":"Should be \nLOG.warn(_LW(\"DRBDmanage: too many assignments returned.\"))","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"}],"cinder/volume/targets/drbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"617be1c8b9a851bc88def41160ff264357b65617","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.protocol \u003d \u0027DRBD\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":31,"context_line":"        LOG.error(\"volume %s connector %s\" % (vars(volume), connector))"},{"line_number":32,"context_line":"        # connector {\u0027ip\u0027: \u002710.43.8.42\u0027, \u0027host\u0027: \u0027devstack-trusty-2\u0027, \u0027initiator\u0027: \u0027iqn.1993-08.org.debian:01:8355717e1829\u0027}"},{"line_number":33,"context_line":"        # where is that data from?"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_fb2737b4","line":31,"updated":"2015-02-23 21:09:33.000000000","message":"% \u003d\u003e ,","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"31f796f513b4762dcf01660e5d28440aab6d5ab7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t#   - get dbus "},{"line_number":50,"context_line":"\t#   - config (drbdmanage instance), ..."},{"line_number":51,"context_line":"\t#   - connection drop handling (dbus restart)"},{"line_number":52,"context_line":"\t#   - another drbdmanage API user? 2 things to change."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def ensure_export(self, context, volume, volume_path):"},{"line_number":55,"context_line":"\tpass"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f4cd2187","line":52,"updated":"2015-05-26 19:22:41.000000000","message":"Please remove extra spaces and strange characters.","commit_id":"afaaaedd923042ea41c2766216ed071b08a2dd98"}]}