)]}'
{"cinder/zonemanager/fc_zone_manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0b45711c638dc8811e29c1a2e7d71f2496dc9d98","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""},{"line_number":89,"context_line":"        super(ZoneManager, self).__init__(**kwargs)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027)"},{"line_number":92,"context_line":"        if self.configuration:"},{"line_number":93,"context_line":"            self.configuration.append_config_values(zone_manager_opts)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_67f5f3c9","line":91,"updated":"2015-02-19 16:31:22.000000000","message":"Why did you make this change?","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""},{"line_number":89,"context_line":"        super(ZoneManager, self).__init__(**kwargs)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027)"},{"line_number":92,"context_line":"        if self.configuration:"},{"line_number":93,"context_line":"            self.configuration.append_config_values(zone_manager_opts)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6708932d","line":91,"in_reply_to":"da86d52c_67f5f3c9","updated":"2015-02-19 16:42:44.000000000","message":"\", None\" is always redundant when retrieving anything from a dict.\n\ne.g., {}.get(\u0027foo\u0027) is None.  Specifying , None is generally discouraged.","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0b45711c638dc8811e29c1a2e7d71f2496dc9d98","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":132,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":133,"context_line":"                LOG.debug(\"Target List: %s\", {initiator: target_list})"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"                # get SAN context for the target list"},{"line_number":136,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_07a9978f","line":133,"updated":"2015-02-19 16:31:22.000000000","message":"Since you are changing this it seems you should use % (initiator)s here.","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":132,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":133,"context_line":"                LOG.debug(\"Target List: %s\", {initiator: target_list})"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"                # get SAN context for the target list"},{"line_number":136,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_8248155d","line":133,"in_reply_to":"da86d52c_07a9978f","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0b45711c638dc8811e29c1a2e7d71f2496dc9d98","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":175,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":176,"context_line":"                LOG.info(_LI(\"Delete connection Target List: %s\"),"},{"line_number":177,"context_line":"                         {initiator: target_list})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"                # get SAN context for the target list"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_47962f4d","line":176,"updated":"2015-02-19 16:31:22.000000000","message":"Same comment here.","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":175,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":176,"context_line":"                LOG.info(_LI(\"Delete connection Target List: %s\"),"},{"line_number":177,"context_line":"                         {initiator: target_list})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"                # get SAN context for the target list"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_626401e5","line":176,"in_reply_to":"da86d52c_47962f4d","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"70eb54f2460612bcc123e84f94532c2b86004a7e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""},{"line_number":89,"context_line":"        super(ZoneManager, self).__init__(**kwargs)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027)"},{"line_number":92,"context_line":"        if self.configuration:"},{"line_number":93,"context_line":"            self.configuration.append_config_values(zone_manager_opts)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_a22c3994","line":91,"updated":"2015-02-19 16:40:57.000000000","message":"why did you remove the None default ?","commit_id":"984a94993da088e74ead4ed4f0725ee2b168f547"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"e351d2deb152a44bc0dcf253fcacfd8c5047774e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""},{"line_number":89,"context_line":"        super(ZoneManager, self).__init__(**kwargs)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.configuration \u003d kwargs.get(\u0027configuration\u0027)"},{"line_number":92,"context_line":"        if self.configuration:"},{"line_number":93,"context_line":"            self.configuration.append_config_values(zone_manager_opts)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_62d96182","line":91,"in_reply_to":"da86d52c_a22c3994","updated":"2015-02-19 16:44:07.000000000","message":"Hi Walt - \u0027None\u0027 is implied as a default when retrieving from a dict and is generally discouraged.  We hit on that in nova all the time.  :-)","commit_id":"984a94993da088e74ead4ed4f0725ee2b168f547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c36204ccfd3a8b4a58d0f21c702a7f59a50bbe79","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":132,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":133,"context_line":"                LOG.debug(\"Target List: %(initiator)s\","},{"line_number":134,"context_line":"                          {initiator: target_list})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"                # get SAN context for the target list"},{"line_number":137,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_fdf094fe","line":134,"updated":"2015-02-19 17:06:24.000000000","message":"initiator needs to be in quotes\n\n{\"initiator\": target_list}","commit_id":"40d91266847179ebeffe9953bbeeb8856028cb6d"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"6f2da1abf03046a122e54861c58fdc8f50dd2d4a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":132,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":133,"context_line":"                LOG.debug(\"Target List: %(initiator)s\","},{"line_number":134,"context_line":"                          {initiator: target_list})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"                # get SAN context for the target list"},{"line_number":137,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_7de2e4a0","line":134,"in_reply_to":"da86d52c_fdf094fe","updated":"2015-02-19 17:19:10.000000000","message":"Removed dict style params since \u0027initiator\u0027 is actually a variable.","commit_id":"40d91266847179ebeffe9953bbeeb8856028cb6d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c36204ccfd3a8b4a58d0f21c702a7f59a50bbe79","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":176,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":177,"context_line":"                LOG.info(_LI(\"Delete connection Target List: %(initiator)s\"),"},{"line_number":178,"context_line":"                         {initiator: target_list})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"                # get SAN context for the target list"},{"line_number":181,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_3ddeac6d","line":178,"updated":"2015-02-19 17:06:24.000000000","message":"same","commit_id":"40d91266847179ebeffe9953bbeeb8856028cb6d"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"6f2da1abf03046a122e54861c58fdc8f50dd2d4a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            for initiator in initiator_target_map.keys():"},{"line_number":176,"context_line":"                target_list \u003d initiator_target_map[initiator]"},{"line_number":177,"context_line":"                LOG.info(_LI(\"Delete connection Target List: %(initiator)s\"),"},{"line_number":178,"context_line":"                         {initiator: target_list})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"                # get SAN context for the target list"},{"line_number":181,"context_line":"                fabric_map \u003d self.get_san_context(target_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_bdeffc85","line":178,"in_reply_to":"da86d52c_3ddeac6d","updated":"2015-02-19 17:19:10.000000000","message":"Ditto","commit_id":"40d91266847179ebeffe9953bbeeb8856028cb6d"}],"cinder/zonemanager/utils.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"d58364836f7a588042a8bbe7d7a96524d789b947","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b4c64947","line":53,"updated":"2015-02-19 10:20:18.000000000","message":"According to the Logging guidelines, please change % \u003d\u003e ,","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"775e3542e21c075809fec1acbd661e56b48e595a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2f792093","line":53,"in_reply_to":"da86d52c_34c179e4","updated":"2015-02-19 10:37:43.000000000","message":"Ok, thanks...got it.  This statement isn\u0027t translated since it\u0027s debug, so I don\u0027t believe that applies here.","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"956304df87c85692dccb03a6c1c38e0410b89c71","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_d44bbdae","line":53,"in_reply_to":"da86d52c_b4c64947","updated":"2015-02-19 10:26:28.000000000","message":"Sorry, I\u0027m not sure I follow you?","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"bc2140696270ee23825f48167b2519cac2bf1fc2","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_34c179e4","line":53,"in_reply_to":"da86d52c_d44bbdae","updated":"2015-02-19 10:30:17.000000000","message":"Please look at http://docs.openstack.org/developer/oslo.i18n/guidelines.html#examples","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"d58364836f7a588042a8bbe7d7a96524d789b947","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"},{"line_number":57,"context_line":"        LOG.info(_LI(\"Using FC lookup service %s\") % lookup.lookup_service)"},{"line_number":58,"context_line":"        return lookup"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        LOG.debug(\"FC Lookup Service not enabled in cinder.conf.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b4cd695f","line":57,"updated":"2015-02-19 10:20:18.000000000","message":"please change % \u003d\u003e ,","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"0400dfee74fa3978fdf280632bc27540d87824f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"},{"line_number":57,"context_line":"        LOG.info(_LI(\"Using FC lookup service %s\") % lookup.lookup_service)"},{"line_number":58,"context_line":"        return lookup"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        LOG.debug(\"FC Lookup Service not enabled in cinder.conf.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_afe35003","line":57,"in_reply_to":"da86d52c_2f876062","updated":"2015-02-19 10:43:17.000000000","message":"But, I fixed it anyway for good measure.  :)","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"0400dfee74fa3978fdf280632bc27540d87824f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"},{"line_number":57,"context_line":"        LOG.info(_LI(\"Using FC lookup service %s\") % lookup.lookup_service)"},{"line_number":58,"context_line":"        return lookup"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        LOG.debug(\"FC Lookup Service not enabled in cinder.conf.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_cfeec4ec","line":57,"in_reply_to":"da86d52c_b4cd695f","updated":"2015-02-19 10:43:17.000000000","message":"Done","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"775e3542e21c075809fec1acbd661e56b48e595a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"},{"line_number":57,"context_line":"        LOG.info(_LI(\"Using FC lookup service %s\") % lookup.lookup_service)"},{"line_number":58,"context_line":"        return lookup"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        LOG.debug(\"FC Lookup Service not enabled in cinder.conf.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2f876062","line":57,"in_reply_to":"da86d52c_b4cd695f","updated":"2015-02-19 10:37:43.000000000","message":"This isn\u0027t part of the patch.  I think the changes you\u0027re talking about are much more pervasive throughout cinder and would probably better fit in a path of its own dedicated to fixing the i18n issues.","commit_id":"3aa6ed0eda39f414bcf213f9893aedc4183fc2e8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05f1d7697137d82fe5a0faff13b167e0893a38f8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def create_zone_manager():"},{"line_number":34,"context_line":"    \"\"\"If zoning is enabled, build the Zone Manager.\"\"\""},{"line_number":35,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":36,"context_line":"    LOG.debug(\"zoning mode %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":37,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":38,"context_line":"        LOG.debug(\"FC Zone Manager enabled.\")"},{"line_number":39,"context_line":"        zm \u003d fc_zone_manager.ZoneManager(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_0458ba2f","line":36,"updated":"2015-02-19 14:21:19.000000000","message":"Please change % to ,","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def create_zone_manager():"},{"line_number":34,"context_line":"    \"\"\"If zoning is enabled, build the Zone Manager.\"\"\""},{"line_number":35,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":36,"context_line":"    LOG.debug(\"zoning mode %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":37,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":38,"context_line":"        LOG.debug(\"FC Zone Manager enabled.\")"},{"line_number":39,"context_line":"        zm \u003d fc_zone_manager.ZoneManager(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_079d170a","line":36,"in_reply_to":"da86d52c_0458ba2f","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05f1d7697137d82fe5a0faff13b167e0893a38f8","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6448965c","line":53,"updated":"2015-02-19 14:21:19.000000000","message":"% \u003d\u003e ,","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def create_lookup_service():"},{"line_number":52,"context_line":"    config \u003d Configuration(manager.volume_manager_opts)"},{"line_number":53,"context_line":"    LOG.debug(\"Zoning mode: %s\" % config.safe_get(\u0027zoning_mode\u0027))"},{"line_number":54,"context_line":"    if config.safe_get(\u0027zoning_mode\u0027) \u003d\u003d \u0027fabric\u0027:"},{"line_number":55,"context_line":"        LOG.debug(\"FC Lookup Service enabled.\")"},{"line_number":56,"context_line":"        lookup \u003d fc_san_lookup_service.FCSanLookupService(configuration\u003dconfig)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_6750935e","line":53,"in_reply_to":"da86d52c_6448965c","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05f1d7697137d82fe5a0faff13b167e0893a38f8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if \u0027initiator_target_map\u0027 in conn_info[\u0027data\u0027]:"},{"line_number":86,"context_line":"                init_target_map \u003d conn_info[\u0027data\u0027][\u0027initiator_target_map\u0027]"},{"line_number":87,"context_line":"                zm \u003d create_zone_manager()"},{"line_number":88,"context_line":"                if zm:"},{"line_number":89,"context_line":"                    LOG.debug(\"Add FC Zone for mapping \u0027%s\u0027.\" %"},{"line_number":90,"context_line":"                              init_target_map)"},{"line_number":91,"context_line":"                    zm.add_connection(init_target_map)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_446472e4","line":88,"updated":"2015-02-19 14:21:19.000000000","message":"% \u003d\u003e ,","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if \u0027initiator_target_map\u0027 in conn_info[\u0027data\u0027]:"},{"line_number":86,"context_line":"                init_target_map \u003d conn_info[\u0027data\u0027][\u0027initiator_target_map\u0027]"},{"line_number":87,"context_line":"                zm \u003d create_zone_manager()"},{"line_number":88,"context_line":"                if zm:"},{"line_number":89,"context_line":"                    LOG.debug(\"Add FC Zone for mapping \u0027%s\u0027.\" %"},{"line_number":90,"context_line":"                              init_target_map)"},{"line_number":91,"context_line":"                    zm.add_connection(init_target_map)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_27d21bd1","line":88,"in_reply_to":"da86d52c_446472e4","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"05f1d7697137d82fe5a0faff13b167e0893a38f8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            if \u0027initiator_target_map\u0027 in conn_info[\u0027data\u0027]:"},{"line_number":111,"context_line":"                init_target_map \u003d conn_info[\u0027data\u0027][\u0027initiator_target_map\u0027]"},{"line_number":112,"context_line":"                zm \u003d create_zone_manager()"},{"line_number":113,"context_line":"                if zm:"},{"line_number":114,"context_line":"                    LOG.debug(\"Remove FC Zone for mapping \u0027%s\u0027.\" %"},{"line_number":115,"context_line":"                              init_target_map)"},{"line_number":116,"context_line":"                    zm.delete_connection(init_target_map)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_845aea1b","line":113,"updated":"2015-02-19 14:21:19.000000000","message":"% \u003d\u003e ,","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"},{"author":{"_account_id":7664,"name":"Joe Cropper","email":"jwcroppe@us.ibm.com","username":"jwcroppe"},"change_message_id":"a26a0383b4a14a0a5920ae38afa2166dd2a26a99","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            if \u0027initiator_target_map\u0027 in conn_info[\u0027data\u0027]:"},{"line_number":111,"context_line":"                init_target_map \u003d conn_info[\u0027data\u0027][\u0027initiator_target_map\u0027]"},{"line_number":112,"context_line":"                zm \u003d create_zone_manager()"},{"line_number":113,"context_line":"                if zm:"},{"line_number":114,"context_line":"                    LOG.debug(\"Remove FC Zone for mapping \u0027%s\u0027.\" %"},{"line_number":115,"context_line":"                              init_target_map)"},{"line_number":116,"context_line":"                    zm.delete_connection(init_target_map)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_47dc6fe4","line":113,"in_reply_to":"da86d52c_845aea1b","updated":"2015-02-19 16:42:44.000000000","message":"Done","commit_id":"b9f1b1ca85d39997672ea97c217374d27ba7a22b"}]}