)]}'
{"cinder/tests/targets/test_scst_driver.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"bfa85849bd87d6279cb37b0a3e47d6b25eda9f8f","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            self.target.create_iscsi_target.assert_called_once_with("},{"line_number":239,"context_line":"                \u0027iqn.2010-10.org.openstack:testvol\u0027,"},{"line_number":240,"context_line":"                \u0027ed2c2222-5fc0-11e4-aa15-123b93f75cba\u0027,"},{"line_number":241,"context_line":"                0, 1, self.fake_volumes_dir, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b2c5e43d","line":241,"updated":"2015-02-23 19:55:31.000000000","message":"Unit test for chap auth !\u003dnone, so it can test the new code path?","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"}],"cinder/volume/targets/scst.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e545da7e61a73a82451f43c4bfa64cd9522cf91a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                error_message\u003d\"Failed to enable SCST Target driver.\")"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if self._get_target(name) is None:"},{"line_number":126,"context_line":"            chap_string \u003d None"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                (out, _err) \u003d self.scst_execute(\u0027-add_target\u0027, name,"},{"line_number":129,"context_line":"                                                \u0027-driver\u0027, self.target_driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e9728c7a","line":126,"updated":"2015-02-19 20:40:34.000000000","message":"chap_string \u003d None, doesn\u0027t seem like you need this variable intialized her. The scope if just within the if chap_auth below","commit_id":"0e53c0b93c0a8ecd019e8c15d9fbf956f9580b84"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cfa96033031edd47c7530c3672dd1142ee70c53e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                LOG.error(_LE(\"Failed to set attribute \u0027Incoming user\u0027 for \""},{"line_number":157,"context_line":"                              \"SCST target %s\"), e)"},{"line_number":158,"context_line":"                raise exception.ISCSITargetHelperCommandFailed("},{"line_number":159,"context_line":"                    error_mesage\u003d\"Failed to set \u0027IncomingUser\u0027 attribute \""},{"line_number":160,"context_line":"                                 \"for SCST Target.\")"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if self.target_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_cc5fa4e3","line":159,"updated":"2015-02-19 16:15:37.000000000","message":"Need _()","commit_id":"0e53c0b93c0a8ecd019e8c15d9fbf956f9580b84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaccd6a538685409be57531cce00ff0b27090925","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                              \"SCST target %s\"), e)"},{"line_number":158,"context_line":"                raise exception.ISCSITargetHelperCommandFailed("},{"line_number":159,"context_line":"                    error_mesage\u003d\"Failed to set \u0027IncomingUser\u0027 attribute \""},{"line_number":160,"context_line":"                                 \"for SCST Target.\")"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if self.target_name:"},{"line_number":163,"context_line":"            if self._get_group() is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_bd061ccc","line":160,"updated":"2015-02-19 17:09:56.000000000","message":"I would go a step further and ask that these be combined so there aren\u0027t too strings to be translated that are just a tiny bit different. Something like:\n\nmsg \u003d _(\u0027Failed to set attribute \u0027IncomingUser\u0027 for SCST target %s\u0027)\nLOG.exception(msg)\nraise exception.ISCSITargetHelpCommandFailed(\n    error_message\u003dmsg)","commit_id":"0e53c0b93c0a8ecd019e8c15d9fbf956f9580b84"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"e545da7e61a73a82451f43c4bfa64cd9522cf91a","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not chap_auth:"},{"line_number":276,"context_line":"            LOG.info(_LI(\"Skipping ensure_export. No iscsi_target \""},{"line_number":277,"context_line":"                         \"provision for volume: %s\"), volume[\u0027id\u0027])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.create_iscsi_target(iscsi_name, volume[\u0027id\u0027], iscsi_target,"},{"line_number":280,"context_line":"                                 lun, volume_path, chap_auth)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_a9adf485","line":277,"updated":"2015-02-19 20:40:34.000000000","message":"Missing an else case or return to skip? Where do you actually skip?","commit_id":"0e53c0b93c0a8ecd019e8c15d9fbf956f9580b84"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a8f1acb4511ba3a1909de961928269bf215df000","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_02ed94ef","side":"PARENT","line":12,"updated":"2015-02-23 11:57:17.000000000","message":"Why did you delete blank line?","commit_id":"8bda008dd0594f006e21d2745b616a97d7119065"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a8f1acb4511ba3a1909de961928269bf215df000","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                                \u0027-set_tgt_attr\u0027, name,"},{"line_number":149,"context_line":"                                                \u0027-driver\u0027, self.target_driver,"},{"line_number":150,"context_line":"                                                \u0027-attributes\u0027,"},{"line_number":151,"context_line":"                                                \u0027IncomingUser\u003d%s\u0027 %"},{"line_number":152,"context_line":"                                                chap_string)"},{"line_number":153,"context_line":"                LOG.debug(\"StdOut from scstadmin set target attribute: %s\","},{"line_number":154,"context_line":"                          out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_82afc493","line":151,"updated":"2015-02-23 11:57:17.000000000","message":"could we reuse iscsi_authentication function here to avoid code dublication and make code more clear?","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":14252,"name":"nikeshmahalka","email":"Nikesh.Mahalka@emulex.com","username":"nikeshmahalka"},"change_message_id":"881a0e6fec2a09ff01cb6a61e5b621ecd63df831","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                                \u0027-set_tgt_attr\u0027, name,"},{"line_number":149,"context_line":"                                                \u0027-driver\u0027, self.target_driver,"},{"line_number":150,"context_line":"                                                \u0027-attributes\u0027,"},{"line_number":151,"context_line":"                                                \u0027IncomingUser\u003d%s\u0027 %"},{"line_number":152,"context_line":"                                                chap_string)"},{"line_number":153,"context_line":"                LOG.debug(\"StdOut from scstadmin set target attribute: %s\","},{"line_number":154,"context_line":"                          out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_bb1cca78","line":151,"in_reply_to":"ba7be1f8_82afc493","updated":"2015-02-24 10:00:22.000000000","message":"Thanks for your comments. We will chang the code.","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a8f1acb4511ba3a1909de961928269bf215df000","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                                \u0027-attributes\u0027,"},{"line_number":151,"context_line":"                                                \u0027IncomingUser\u003d%s\u0027 %"},{"line_number":152,"context_line":"                                                chap_string)"},{"line_number":153,"context_line":"                LOG.debug(\"StdOut from scstadmin set target attribute: %s\","},{"line_number":154,"context_line":"                          out)"},{"line_number":155,"context_line":"            except putils.ProcessExecutionError:"},{"line_number":156,"context_line":"                msg \u003d _(\"Failed to set attribute \u0027Incoming user\u0027 for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_62273065","line":153,"updated":"2015-02-23 11:57:17.000000000","message":"Add period [ . ] at the end of a sentence in messanges please","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a8f1acb4511ba3a1909de961928269bf215df000","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                LOG.debug(\"StdOut from scstadmin set target attribute: %s\","},{"line_number":154,"context_line":"                          out)"},{"line_number":155,"context_line":"            except putils.ProcessExecutionError:"},{"line_number":156,"context_line":"                msg \u003d _(\"Failed to set attribute \u0027Incoming user\u0027 for \""},{"line_number":157,"context_line":"                        \"SCST target\")"},{"line_number":158,"context_line":"                LOG.exception(msg)"},{"line_number":159,"context_line":"                raise exception.ISCSITargetHelperCommandFailed("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e21a4016","line":156,"updated":"2015-02-23 11:57:17.000000000","message":"And here","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":14252,"name":"nikeshmahalka","email":"Nikesh.Mahalka@emulex.com","username":"nikeshmahalka"},"change_message_id":"881a0e6fec2a09ff01cb6a61e5b621ecd63df831","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                LOG.debug(\"StdOut from scstadmin set target attribute: %s\","},{"line_number":154,"context_line":"                          out)"},{"line_number":155,"context_line":"            except putils.ProcessExecutionError:"},{"line_number":156,"context_line":"                msg \u003d _(\"Failed to set attribute \u0027Incoming user\u0027 for \""},{"line_number":157,"context_line":"                        \"SCST target\")"},{"line_number":158,"context_line":"                LOG.exception(msg)"},{"line_number":159,"context_line":"                raise exception.ISCSITargetHelperCommandFailed("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_db3c1ee5","line":156,"in_reply_to":"ba7be1f8_e21a4016","updated":"2015-02-24 10:00:22.000000000","message":"We will do this.","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"bfa85849bd87d6279cb37b0a3e47d6b25eda9f8f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        if self.chap_username and self.chap_password:"},{"line_number":271,"context_line":"            chap_auth \u003d (self.chap_username, self.chap_password)"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            chap_auth \u003d self._get_target_chap_auth(context, iscsi_name)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        self.create_iscsi_target(iscsi_name, volume[\u0027id\u0027], iscsi_target,"},{"line_number":276,"context_line":"                                 lun, volume_path, chap_auth)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_1294f035","line":273,"updated":"2015-02-23 19:55:31.000000000","message":"There is possibility of get_target_cap_auth to return none. You had a check for that in Patch1, what happens to  the create_iscsi_target call in that case/","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"},{"author":{"_account_id":14252,"name":"nikeshmahalka","email":"Nikesh.Mahalka@emulex.com","username":"nikeshmahalka"},"change_message_id":"881a0e6fec2a09ff01cb6a61e5b621ecd63df831","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        if self.chap_username and self.chap_password:"},{"line_number":271,"context_line":"            chap_auth \u003d (self.chap_username, self.chap_password)"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            chap_auth \u003d self._get_target_chap_auth(context, iscsi_name)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        self.create_iscsi_target(iscsi_name, volume[\u0027id\u0027], iscsi_target,"},{"line_number":276,"context_line":"                                 lun, volume_path, chap_auth)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_7b541221","line":273,"in_reply_to":"ba7be1f8_1294f035","updated":"2015-02-24 10:00:22.000000000","message":"We had modified the way of using chap strings in method \"create_iscsi_target\".\nIf chap_auth is None, the command for set chap string will not be processed.","commit_id":"ab8a6baf5a3d75d4a4e8809a7f9aa0046a2de797"}]}