)]}'
{"cinder/scheduler/driver.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"df1d9638ec38725ba1d278c3b1f0e3566710c993","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    :returns: A Volume with the updated fields set properly."},{"line_number":50,"context_line":"    \u0027\u0027\u0027"},{"line_number":51,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":52,"context_line":"    values \u003d {\u0027host\u0027: None, \u0027scheduled_at\u0027: now}"},{"line_number":53,"context_line":"    return db.volume_update(context, volume_id, values)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Funs%3D","line":52,"updated":"2012-11-09 18:40:16.000000000","message":"It looks like the old code was setting the host, but it\u0027s being set to None here.  It looks like a bug to me.","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b99bec08d948a33d578e747b2eaeeb5611e1077c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    :returns: A Volume with the updated fields set properly."},{"line_number":50,"context_line":"    \u0027\u0027\u0027"},{"line_number":51,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":52,"context_line":"    values \u003d {\u0027host\u0027: None, \u0027scheduled_at\u0027: now}"},{"line_number":53,"context_line":"    return db.volume_update(context, volume_id, values)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fuiw%3D","line":52,"in_reply_to":"AAAALn%2F%2Funs%3D","updated":"2012-11-09 18:47:34.000000000","message":"Done","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"}],"cinder/volume/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"df1d9638ec38725ba1d278c3b1f0e3566710c993","unresolved":false,"context_lines":[{"line_number":81,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":82,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    RPC_API_VERSION \u003d \u00271.2\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, volume_driver\u003dNone, *args, **kwargs):"},{"line_number":87,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fumw%3D","line":84,"updated":"2012-11-09 18:40:16.000000000","message":"1.2?  Shouldn\u0027t this be 1.0?","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b99bec08d948a33d578e747b2eaeeb5611e1077c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":82,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    RPC_API_VERSION \u003d \u00271.2\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, volume_driver\u003dNone, *args, **kwargs):"},{"line_number":87,"context_line":"        \"\"\"Load the driver from the one specified in args, or from flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2FujA%3D","line":84,"in_reply_to":"AAAALn%2F%2Fumw%3D","updated":"2012-11-09 18:47:34.000000000","message":"...typo, will fix.","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"df1d9638ec38725ba1d278c3b1f0e3566710c993","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if not host:"},{"line_number":46,"context_line":"        raise exception.CinderException(_(\u0027Unable to find host for \u0027"},{"line_number":47,"context_line":"                                        \u0027volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":48,"context_line":"    return rpc.queue_get_for(ctxt, topic, host)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class VolumeAPI(cinder.openstack.common.rpc.proxy.RpcProxy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fum4%3D","line":48,"updated":"2012-11-09 18:40:16.000000000","message":"I don\u0027t think you need this function here.  I think you can simplify it by just using rpc.queue_get_for().  In every function you know that you either want to use the host argument or volume[\u0027host\u0027], so you can just plug that in directly.","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b99bec08d948a33d578e747b2eaeeb5611e1077c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if not host:"},{"line_number":46,"context_line":"        raise exception.CinderException(_(\u0027Unable to find host for \u0027"},{"line_number":47,"context_line":"                                        \u0027volume %s\u0027) % volume[\u0027id\u0027])"},{"line_number":48,"context_line":"    return rpc.queue_get_for(ctxt, topic, host)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class VolumeAPI(cinder.openstack.common.rpc.proxy.RpcProxy):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALn%2F%2Fui4%3D","line":48,"in_reply_to":"AAAALn%2F%2Fum4%3D","updated":"2012-11-09 18:47:34.000000000","message":"Done","commit_id":"30dd077e41a23ff552ab8bcda611d3fa3e9fc39f"}]}