)]}'
{"cinder/api/v1/volumes.py":[{"author":{"_account_id":14619,"name":"Victor Feitosa","email":"victor.feitosa@lsbd.ufc.br","username":"victorfeitosa"},"change_message_id":"2ff83c4e23842d598e1bda0511c0830c19f876c2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        attachment \u003d _translate_attachment_detail_view(context, vol)"},{"line_number":97,"context_line":"        d[\u0027attachments\u0027].append(attachment)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    if vol[\u0027display_name\u0027] \u003d\u003d None:"},{"line_number":100,"context_line":"        d[\u0027display_name\u0027] \u003d \"\""},{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        d[\u0027display_name\u0027] \u003d vol[\u0027display_name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c7365c03","line":99,"updated":"2015-02-20 16:42:49.000000000","message":"pep8 returns error here, it should be \u0027if condition is None\u0027...","commit_id":"c0c547613b5d97e234db38f803702df57d8e7ef2"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"dd52f353ab4a589ed0ce182b09db15dd1f779f8b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        attachment \u003d _translate_attachment_detail_view(context, vol)"},{"line_number":97,"context_line":"        d[\u0027attachments\u0027].append(attachment)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    if vol[\u0027display_name\u0027] is None:"},{"line_number":100,"context_line":"        d[\u0027display_name\u0027] \u003d \"\""},{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        d[\u0027display_name\u0027] \u003d vol[\u0027display_name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_eb93fbf7","line":99,"updated":"2015-02-23 13:57:19.000000000","message":"Why not just : d[\u0027display_name\u0027] \u003d vol.get(\u0027display_name\u0027, \u0027\u0027)","commit_id":"4accf91f1ea9ecd077af67c87fbbd7b4988680d0"}],"cinder/tests/api/v1/test_volumes.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7f66ab4ba76cb593f5727b73d4165775b1e84776","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.stubs.Set(volume_api.API, \"create\", stubs.stub_volume_create)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        vol \u003d {\"size\": 100,"},{"line_number":110,"context_line":"               \"display_name\": \"\","},{"line_number":111,"context_line":"               \"display_description\": \"Volume Test Desc\","},{"line_number":112,"context_line":"               \"availability_zone\": \"zone1:host1\"}"},{"line_number":113,"context_line":"        body \u003d {\"volume\": vol}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e99ee353","line":110,"updated":"2015-02-27 06:20:24.000000000","message":"If you specify display_name as \"\" and expect \"\", this will not test the functionality you added in volumes.py. \"display_name\" should be None in this case.","commit_id":"4accf91f1ea9ecd077af67c87fbbd7b4988680d0"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"dd52f353ab4a589ed0ce182b09db15dd1f779f8b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                                               1, 1, 1),"},{"line_number":134,"context_line":"                               \u0027size\u0027: 100,"},{"line_number":135,"context_line":"                               \u0027encrypted\u0027: False}}"},{"line_number":136,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_volume_create_with_type(self):"},{"line_number":139,"context_line":"        vol_type \u003d CONF.default_volume_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_2b4b5388","line":136,"updated":"2015-02-23 13:57:19.000000000","message":"The assertEqual is using incorrect argument order(observed, expected). Please change it to (expected, observed).","commit_id":"4accf91f1ea9ecd077af67c87fbbd7b4988680d0"}]}
