)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":2976,"context_line":"            driver\u003dhpfcdriver.HP3PARFCDriver)"},{"line_number":2977,"context_line":""},{"line_number":2978,"context_line":"        if wsapi_version:"},{"line_number":2979,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2980,"context_line":"                wsapi_version"},{"line_number":2981,"context_line":"        else:"},{"line_number":2982,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_dc756dfb","line":2979,"updated":"2015-02-26 21:05:30.000000000","message":"()","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":2976,"context_line":"            driver\u003dhpfcdriver.HP3PARFCDriver)"},{"line_number":2977,"context_line":""},{"line_number":2978,"context_line":"        if wsapi_version:"},{"line_number":2979,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2980,"context_line":"                wsapi_version"},{"line_number":2981,"context_line":"        else:"},{"line_number":2982,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_62b3fa0a","line":2979,"in_reply_to":"ba7be1f8_dc756dfb","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":2979,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2980,"context_line":"                wsapi_version"},{"line_number":2981,"context_line":"        else:"},{"line_number":2982,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2983,"context_line":"                self.wsapi_version_latest"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"        expected \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_fc723110","line":2982,"updated":"2015-02-26 21:05:30.000000000","message":"()","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":2979,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2980,"context_line":"                wsapi_version"},{"line_number":2981,"context_line":"        else:"},{"line_number":2982,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":2983,"context_line":"                self.wsapi_version_latest"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"        expected \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_82b8eee6","line":2982,"in_reply_to":"ba7be1f8_fc723110","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":3626,"context_line":"            driver\u003dhpdriver.HP3PARISCSIDriver)"},{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"        if wsapi_version:"},{"line_number":3629,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3630,"context_line":"                wsapi_version"},{"line_number":3631,"context_line":"        else:"},{"line_number":3632,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_7c8721d8","line":3629,"updated":"2015-02-26 21:05:30.000000000","message":"()","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":3626,"context_line":"            driver\u003dhpdriver.HP3PARISCSIDriver)"},{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"        if wsapi_version:"},{"line_number":3629,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3630,"context_line":"                wsapi_version"},{"line_number":3631,"context_line":"        else:"},{"line_number":3632,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_c2902651","line":3629,"in_reply_to":"ba7be1f8_7c8721d8","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":3629,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3630,"context_line":"                wsapi_version"},{"line_number":3631,"context_line":"        else:"},{"line_number":3632,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3633,"context_line":"                self.wsapi_version_latest"},{"line_number":3634,"context_line":""},{"line_number":3635,"context_line":"        expected_get_cpgs \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_9c6bf51e","line":3632,"updated":"2015-02-26 21:05:30.000000000","message":"()","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":3629,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3630,"context_line":"                wsapi_version"},{"line_number":3631,"context_line":"        else:"},{"line_number":3632,"context_line":"            mock_client.getWsApiVersion.return_value \u003d \\"},{"line_number":3633,"context_line":"                self.wsapi_version_latest"},{"line_number":3634,"context_line":""},{"line_number":3635,"context_line":"        expected_get_cpgs \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_029b1e73","line":3632,"in_reply_to":"ba7be1f8_9c6bf51e","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def get_flash_cache_policy(self, hp3par_keys):"},{"line_number":895,"context_line":"        if hp3par_keys is not None:"},{"line_number":896,"context_line":"            # first check list of extra spec keys"},{"line_number":897,"context_line":"            val \u003d self._get_key_value(hp3par_keys, \u0027flash_cache\u0027, None)"},{"line_number":898,"context_line":"            if val is not None:"},{"line_number":899,"context_line":"                # if requested, see if supported on back end"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_bcfd193e","line":896,"updated":"2015-02-26 21:05:30.000000000","message":"Can you start all your comments with a capital letter?","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def get_flash_cache_policy(self, hp3par_keys):"},{"line_number":895,"context_line":"        if hp3par_keys is not None:"},{"line_number":896,"context_line":"            # first check list of extra spec keys"},{"line_number":897,"context_line":"            val \u003d self._get_key_value(hp3par_keys, \u0027flash_cache\u0027, None)"},{"line_number":898,"context_line":"            if val is not None:"},{"line_number":899,"context_line":"                # if requested, see if supported on back end"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b7ab721d","line":896,"in_reply_to":"ba7be1f8_bcfd193e","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            try:"},{"line_number":920,"context_line":"                self.client.modifyVolumeSet(vvs_name,"},{"line_number":921,"context_line":"                                            flashCachePolicy\u003dflash_cache)"},{"line_number":922,"context_line":"                LOG.info(_(\"Flash Cache policy set to %s\"), flash_cache)"},{"line_number":923,"context_line":"            except Exception:"},{"line_number":924,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":925,"context_line":"                    LOG.error(_LE(\"Error setting Flash Cache policy \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_bccc3963","line":922,"updated":"2015-02-26 21:05:30.000000000","message":"Please use _LI.","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            try:"},{"line_number":920,"context_line":"                self.client.modifyVolumeSet(vvs_name,"},{"line_number":921,"context_line":"                                            flashCachePolicy\u003dflash_cache)"},{"line_number":922,"context_line":"                LOG.info(_(\"Flash Cache policy set to %s\"), flash_cache)"},{"line_number":923,"context_line":"            except Exception:"},{"line_number":924,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":925,"context_line":"                    LOG.error(_LE(\"Error setting Flash Cache policy \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_17627e16","line":922,"in_reply_to":"ba7be1f8_bccc3963","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30703f26c709f48056ff44ac3476a15673ca956a","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"                old_flash_cache, new_flash_cache):"},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"        if old_vvs !\u003d new_vvs or old_qos !\u003d new_qos or \\"},{"line_number":2169,"context_line":"                old_flash_cache !\u003d new_flash_cache:"},{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"            # Remove VV from old VV Set."},{"line_number":2172,"context_line":"            if old_vvs is not None and old_vvs !\u003d new_vvs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5c341d4a","line":2169,"updated":"2015-02-26 21:05:30.000000000","message":"Suggest using () instead of \\.","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"0611111da5f77ed6cd4eb51b0255cec91e233ffc","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"                old_flash_cache, new_flash_cache):"},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"        if old_vvs !\u003d new_vvs or old_qos !\u003d new_qos or \\"},{"line_number":2169,"context_line":"                old_flash_cache !\u003d new_flash_cache:"},{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"            # Remove VV from old VV Set."},{"line_number":2172,"context_line":"            if old_vvs is not None and old_vvs !\u003d new_vvs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_7771fadf","line":2169,"in_reply_to":"ba7be1f8_5c341d4a","updated":"2015-02-26 21:51:57.000000000","message":"Done","commit_id":"802fc642a2bf9ced38255e07dd8720b1045620e8"}]}