)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"83d744e874668f89fbddfa9780f488717bf25251","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the Windows SMBFS driver parses all the VHD/X images"},{"line_number":10,"context_line":"present on the configured share in order to retrieve the allocated"},{"line_number":11,"context_line":"size. Not only that this can be slow when having many volumes, but"},{"line_number":12,"context_line":"it can also fail in certain environements when the images are in use."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The Linux SMBFS driver uses \u0027du\u0027, which gives incorrect values in"},{"line_number":15,"context_line":"case of VHD/X images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_0e7a2588","line":12,"updated":"2015-08-07 14:32:40.000000000","message":"S/environements /environments","commit_id":"b5112fe0b4009608fc929f7677903650cb4c3ffb"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f6653bbccd30d0d672880e70b783af4cb54dc70e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the Windows SMBFS driver parses all the VHD/X images"},{"line_number":10,"context_line":"present on the configured share in order to retrieve the allocated"},{"line_number":11,"context_line":"size. Not only that this can be slow when having many volumes, but"},{"line_number":12,"context_line":"it can also fail in certain environements when the images are in use."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The Linux SMBFS driver uses \u0027du\u0027, which gives incorrect values in"},{"line_number":15,"context_line":"case of VHD/X images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_a53f8f85","line":12,"in_reply_to":"1a4dcd0f_0e7a2588","updated":"2015-08-07 15:01:42.000000000","message":"My bad, thanks.","commit_id":"b5112fe0b4009608fc929f7677903650cb4c3ffb"}],"cinder/tests/unit/test_smbfs.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a1692f462bf07e90c5ca86dd781037fa54e65206","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if allocation_data_exists:"},{"line_number":108,"context_line":"            fd \u003d mock_open.return_value.__enter__.return_value"},{"line_number":109,"context_line":"            mock_json_load.assert_called_once_with(fd)"},{"line_number":110,"context_line":"            self.assertEqual(self._smbfs_driver._allocation_data,"},{"line_number":111,"context_line":"                             mock_json_load.return_value)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            mock_ensure_tree.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_62ffd9aa","line":110,"updated":"2015-08-04 22:21:38.000000000","message":"Argument order should be expected, actual for all assertEqual calls.","commit_id":"85b0a3a5fdca4c6787ba3d6f42812a84a7fb2bd2"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"526787ce46bd79ce3bd00a084bc6b34b0f6a1bee","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if allocation_data_exists:"},{"line_number":108,"context_line":"            fd \u003d mock_open.return_value.__enter__.return_value"},{"line_number":109,"context_line":"            mock_json_load.assert_called_once_with(fd)"},{"line_number":110,"context_line":"            self.assertEqual(self._smbfs_driver._allocation_data,"},{"line_number":111,"context_line":"                             mock_json_load.return_value)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            mock_ensure_tree.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_8240e5a6","line":110,"in_reply_to":"1a4dcd0f_62ffd9aa","updated":"2015-08-04 22:26:46.000000000","message":"Good point. Updating it now, thanks!","commit_id":"85b0a3a5fdca4c6787ba3d6f42812a84a7fb2bd2"}],"cinder/volume/drivers/smbfs.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6db28f27dd4b8c80b4af182e7a3d068781813522","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027/etc/cinder/smbfs_shares\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027File with the list of available smbfs shares.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027smbfs_allocation_info_file_path\u0027,"},{"line_number":45,"context_line":"               default\u003dr\u0027$state_path/allocation_data\u0027,"},{"line_number":46,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":47,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027smbfs_default_volume_format\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_bda525a3","line":45,"updated":"2015-02-26 15:34:45.000000000","message":"Seems like if you are going to make this change you should also update the smbfs_shares_config default path above.","commit_id":"b4a8692f4ec43a72fbad80aa62e3c03b4456b379"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1ed7aac144f6e81c5b0971ec23ee84ec0574d934","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027/etc/cinder/smbfs_shares\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027File with the list of available smbfs shares.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027smbfs_allocation_info_file_path\u0027,"},{"line_number":45,"context_line":"               default\u003dr\u0027$state_path/allocation_data\u0027,"},{"line_number":46,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":47,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027smbfs_default_volume_format\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_88c901ae","line":45,"in_reply_to":"ba7be1f8_bda525a3","updated":"2015-02-26 15:49:39.000000000","message":"Considering the fact that this file is automatically generated and should not be modified by the user, I thought it should not reside among config files.\n\nThis is not the case for smbfs_shares_config, as the user is responsible of putting a list of shares and flags here that the driver will use.\n\nThis is just my opinion, please correct me if I\u0027m wrong.","commit_id":"b4a8692f4ec43a72fbad80aa62e3c03b4456b379"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c5dfa842ef423fbd274444bf703c1865c4d8a770","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               default\u003d\u0027/etc/cinder/smbfs_shares\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027File with the list of available smbfs shares.\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027smbfs_allocation_info_file_path\u0027,"},{"line_number":44,"context_line":"               default\u003dr\u0027$state_path/allocation_data\u0027,"},{"line_number":45,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":46,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027smbfs_default_volume_format\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_c58366cb","line":44,"updated":"2015-07-30 21:11:07.000000000","message":"Do we need raw string here?","commit_id":"85b0a3a5fdca4c6787ba3d6f42812a84a7fb2bd2"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9882ceca314e7e7bcbc5ca02431b4b5629edf594","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               default\u003d\u0027/etc/cinder/smbfs_shares\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027File with the list of available smbfs shares.\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027smbfs_allocation_info_file_path\u0027,"},{"line_number":44,"context_line":"               default\u003dr\u0027$state_path/allocation_data\u0027,"},{"line_number":45,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":46,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027smbfs_default_volume_format\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_9db5c8ce","line":44,"in_reply_to":"7a016987_c58366cb","updated":"2015-08-04 12:28:44.000000000","message":"Not really, I will update this in the following patch set. Thanks for pointing this out!","commit_id":"85b0a3a5fdca4c6787ba3d6f42812a84a7fb2bd2"}],"cinder/volume/drivers/windows/smbfs.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"aed3c3faa6d383237037ca99a5082d1e2965e697","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CONF.set_default(\u0027smbfs_default_volume_format\u0027, \u0027vhd\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"volume_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027allocation_info_file_path\u0027,"},{"line_number":44,"context_line":"               default\u003dr\u0027c:\\OpenStack\\allocation_info.info\u0027,"},{"line_number":45,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":46,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_a85a9727","line":43,"updated":"2015-02-25 01:36:10.000000000","message":"This config name is to general for it to be driver specific. It should be prefixed like other driver options are.","commit_id":"015a75ddfe2305faaf0ac62bf30606d765be2967"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a25695420b4dfbb8a705ae7d2eba78014521580a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CONF.set_default(\u0027smbfs_default_volume_format\u0027, \u0027vhd\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"volume_opts \u003d ["},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027allocation_info_file_path\u0027,"},{"line_number":44,"context_line":"               default\u003dr\u0027c:\\OpenStack\\allocation_info.info\u0027,"},{"line_number":45,"context_line":"               help\u003d(\u0027The path of the automatically generated file containing \u0027"},{"line_number":46,"context_line":"                     \u0027information about volume disk space allocation.\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b43f49b3","line":43,"in_reply_to":"ba7be1f8_a85a9727","updated":"2015-02-25 07:49:31.000000000","message":"I agree, will add a prefix in the next patch set.\n\nIMO, it might be a good idea to have config groups for that instead of using prefixes, this way we could remove some duplicated code (for example in case of common options, see cinder.brick.remotefs.remotefs), but that\u0027s a different story.","commit_id":"015a75ddfe2305faaf0ac62bf30606d765be2967"}]}