)]}'
{"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1110d3d2cb7c3f3927b1863c5761d88cb29bc91","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        :param vol_ref:  Driver-specific information used to identify a volume"},{"line_number":696,"context_line":"        :return:         A volume reference where share is in IP format."},{"line_number":697,"context_line":"        \"\"\""},{"line_number":698,"context_line":"        # First strip out share and convert to IP format."},{"line_number":699,"context_line":"        share_split \u003d vol_ref.split(\u0027:\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        vol_ref_share_ip \u003d na_utils.resolve_hostname(share_split[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_ddd5a4e5","line":698,"updated":"2015-02-25 18:55:35.000000000","message":"This is going to break if ever used with IPv6 addresses.  If that\u0027s an acceptable limitation for now it should at least be commented.\n\nBut I think you may want something like vol_ref.rsplit(\u0027:\u0027, 1) instead, for one fewer problem in the future.","commit_id":"92c8b977e5d1d49a9285e727c663132ce601e487"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1110d3d2cb7c3f3927b1863c5761d88cb29bc91","unresolved":false,"context_lines":[{"line_number":785,"context_line":"            src_vol \u003d os.path.join(nfs_mount, vol_path)"},{"line_number":786,"context_line":"            dst_vol \u003d os.path.join(nfs_mount, volume[\u0027name\u0027])"},{"line_number":787,"context_line":"            try:"},{"line_number":788,"context_line":"                self._execute(\"mv\", src_vol, dst_vol, run_as_root\u003dFalse,"},{"line_number":789,"context_line":"                              check_exit_code\u003dTrue)"},{"line_number":790,"context_line":"                LOG.debug(\"Setting newly managed Cinder volume name to %s\","},{"line_number":791,"context_line":"                          volume[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_1d0c9cec","line":788,"updated":"2015-02-25 18:55:35.000000000","message":"Since it\u0027s not running as root, this should just be a call to something like shutil.move instead of shelling out to mv.","commit_id":"92c8b977e5d1d49a9285e727c663132ce601e487"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1110d3d2cb7c3f3927b1863c5761d88cb29bc91","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return vol_size"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    def unmanage(self, volume):"},{"line_number":834,"context_line":"        \"\"\"Removes the specified volume from Cinder management."},{"line_number":835,"context_line":"           Does not delete the underlying backend storage object. A log entry"},{"line_number":836,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":837,"context_line":"           managed."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_7dde78de","line":834,"updated":"2015-02-25 18:55:35.000000000","message":"Add newline for standard header formatting.","commit_id":"92c8b977e5d1d49a9285e727c663132ce601e487"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"deb6858d5ff3a6c7ae0ad0c72de25db99b4f0ab3","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        :return:         A volume reference where share is in IP format."},{"line_number":698,"context_line":"        \"\"\""},{"line_number":699,"context_line":"        # First strip out share and convert to IP format."},{"line_number":700,"context_line":"        share_split \u003d vol_ref.split(\u0027:\u0027, 1)"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        vol_ref_share_ip \u003d na_utils.resolve_hostname(share_split[0])"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_c7d0ca55","line":700,"updated":"2015-03-02 15:38:31.000000000","message":"Need rsplit instead of split, or you will get:\n\n::1:/export    -\u003e  [\u0027\u0027, \u0027:1:/export\u0027]","commit_id":"e5667c585007a8bae73d0ce71761c20fed4a30bc"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"97b2c46fd3b7735db8ebc69b04d7e66d02bc9a8c","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        :return:         A volume reference where share is in IP format."},{"line_number":698,"context_line":"        \"\"\""},{"line_number":699,"context_line":"        # First strip out share and convert to IP format."},{"line_number":700,"context_line":"        share_split \u003d vol_ref.split(\u0027:\u0027, 1)"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        vol_ref_share_ip \u003d na_utils.resolve_hostname(share_split[0])"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_3b68da20","line":700,"in_reply_to":"ba7be1f8_c7d0ca55","updated":"2015-03-02 17:41:27.000000000","message":"Done","commit_id":"e5667c585007a8bae73d0ce71761c20fed4a30bc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"58b0fe649e7ee105b856b67e8c722fb4754fb80b","unresolved":false,"context_lines":[{"line_number":792,"context_line":"                self._set_rw_permissions_for_all(dst_vol)"},{"line_number":793,"context_line":"            except (OSError, IOError) as err:"},{"line_number":794,"context_line":"                exception_msg \u003d (_(\"Failed to manage existing volume %(name)s,\""},{"line_number":795,"context_line":"                                   \"because rename operation failed:\""},{"line_number":796,"context_line":"                                   \" Error msg: %(msg)s.\"),"},{"line_number":797,"context_line":"                                 {\u0027name\u0027: existing_vol_ref[\u0027source-name\u0027],"},{"line_number":798,"context_line":"                                  \u0027msg\u0027: err})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_0b02c609","line":795,"updated":"2015-03-06 19:25:34.000000000","message":"missing space at the beginning of the line.","commit_id":"1a78662d004d5502a4113569ba09a2f3a9df2521"}]}