)]}'
{"cinder/tests/api/contrib/test_qos_specs_manage.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                side_effect\u003dreturn_qos_specs_get_qos_specs)"},{"line_number":187,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.delete\u0027,"},{"line_number":188,"context_line":"                side_effect\u003dreturn_qos_specs_delete)"},{"line_number":189,"context_line":"    def test_qos_specs_delete(self, mock_qos_delete, mock_qos_create):"},{"line_number":190,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/qos-specs/1\u0027)"},{"line_number":191,"context_line":"        notifier \u003d fake_notifier.get_fake_notifier()"},{"line_number":192,"context_line":"        with mock.patch(\u0027cinder.rpc.get_notifier\u0027, return_value\u003dnotifier):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_d9d22dd0","line":189,"updated":"2015-03-19 18:55:05.000000000","message":"You have a number of places here where you have the mock as mock_qos_create but when you are mocking is get_qos_specs .  Seems like you should fix that.","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.delete\u0027,"},{"line_number":199,"context_line":"                side_effect\u003dreturn_qos_specs_delete)"},{"line_number":200,"context_line":"    def test_qos_specs_delete_not_found(self, mock_qos_delete,"},{"line_number":201,"context_line":"                                        mock_qos_create):"},{"line_number":202,"context_line":"        notifier \u003d fake_notifier.get_fake_notifier()"},{"line_number":203,"context_line":"        with mock.patch(\u0027cinder.rpc.get_notifier\u0027, return_value\u003dnotifier):"},{"line_number":204,"context_line":"            req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/qos-specs/777\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_59de3ddb","line":201,"updated":"2015-03-19 18:55:05.000000000","message":"Here","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.delete\u0027,"},{"line_number":212,"context_line":"                side_effect\u003dreturn_qos_specs_delete)"},{"line_number":213,"context_line":"    def test_qos_specs_delete_inuse(self, mock_qos_delete,"},{"line_number":214,"context_line":"                                    mock_qos_create):"},{"line_number":215,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/qos-specs/666\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        notifier \u003d fake_notifier.get_fake_notifier()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_b9e499a8","line":214,"updated":"2015-03-19 18:55:05.000000000","message":"Here","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.delete\u0027,"},{"line_number":226,"context_line":"                side_effect\u003dreturn_qos_specs_delete)"},{"line_number":227,"context_line":"    def test_qos_specs_delete_inuse_force(self, mock_qos_delete,"},{"line_number":228,"context_line":"                                          mock_qos_create):"},{"line_number":229,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/qos-specs/666?force\u003dTrue\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        notifier \u003d fake_notifier.get_fake_notifier()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_999a7512","line":228,"updated":"2015-03-19 18:55:05.000000000","message":"Here","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                side_effect\u003dreturn_qos_specs_create)"},{"line_number":277,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.get_qos_specs_by_name\u0027,"},{"line_number":278,"context_line":"                side_effect\u003dreturn_qos_specs_get_by_name)"},{"line_number":279,"context_line":"    def test_create(self, mock_qos_get_specs, mock_qos_spec_create):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        body \u003d {\"qos_specs\": {\"name\": \"qos_specs_1\","},{"line_number":282,"context_line":"                              \"key1\": \"value1\"}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_d9b78d83","line":279,"updated":"2015-03-19 18:55:05.000000000","message":"Here you have get specs but create is mocked.","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"ec3922cd9dd6935bd78fea4cf8aee1be1d197ff1","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                side_effect\u003dreturn_qos_specs_create)"},{"line_number":277,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.get_qos_specs_by_name\u0027,"},{"line_number":278,"context_line":"                side_effect\u003dreturn_qos_specs_get_by_name)"},{"line_number":279,"context_line":"    def test_create(self, mock_qos_get_specs, mock_qos_spec_create):"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        body \u003d {\"qos_specs\": {\"name\": \"qos_specs_1\","},{"line_number":282,"context_line":"                              \"key1\": \"value1\"}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_77b133df","line":279,"in_reply_to":"9a80dd14_d9b78d83","updated":"2015-03-20 09:18:13.000000000","message":"Don\u0027t see problem here, patched get_qos_specs_by_name -\u003e mock_qos_get_specs, qos_specs.create -\u003e mock_qos_spec_create","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f01493176fd444af67ae11fbf71f4c2f45c8588","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    @mock.patch(\u0027cinder.volume.qos_specs.get_associations\u0027,"},{"line_number":438,"context_line":"                side_effect\u003dreturn_get_qos_associations)"},{"line_number":439,"context_line":"    def test_get_associations_xml_response(self, mock_get_assciations):"},{"line_number":440,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/qos-specs/1/associations\u0027)"},{"line_number":441,"context_line":"        res \u003d self.controller.associations(req, \u00271\u0027)"},{"line_number":442,"context_line":"        req.method \u003d \u0027GET\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_9930b557","line":439,"updated":"2015-03-19 18:55:05.000000000","message":"Typo -\u003e  assciations","commit_id":"8da9fc30ae26ea927ef9cd3c008e29aa3a5b1d15"}]}