)]}'
{"cinder/scheduler/filter_scheduler.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"c20f99fd7c2bed4809d2fc09392ffdce20cb0f16","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            # If multiattach is enabled on a volume, we need to add"},{"line_number":355,"context_line":"            # multiattach to extra specs, so that the capability"},{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            LOG.warn(\"Volume properties %s\" % volume_properties)"},{"line_number":358,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":359,"context_line":"            LOG.warn(\"extra specs %s\" % resource_type.get(\u0027extra_specs\u0027, None))"},{"line_number":360,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_a0d66ec1","line":357,"updated":"2015-03-02 10:38:23.000000000","message":"Maybe better use _LW()","commit_id":"23d8a87b26340cf4946c2727f23f5d8f46a0e97f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f52ad994be2b105f7a00e09c23d6598d2ed28f56","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            # If multiattach is enabled on a volume, we need to add"},{"line_number":355,"context_line":"            # multiattach to extra specs, so that the capability"},{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            LOG.warn(\"Volume properties %s\" % volume_properties)"},{"line_number":358,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":359,"context_line":"            LOG.warn(\"extra specs %s\" % resource_type.get(\u0027extra_specs\u0027, None))"},{"line_number":360,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f2f3ca07","line":357,"in_reply_to":"ba7be1f8_a0d66ec1","updated":"2015-03-02 15:59:30.000000000","message":"Done","commit_id":"23d8a87b26340cf4946c2727f23f5d8f46a0e97f"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"c20f99fd7c2bed4809d2fc09392ffdce20cb0f16","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            LOG.warn(\"Volume properties %s\" % volume_properties)"},{"line_number":358,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":359,"context_line":"            LOG.warn(\"extra specs %s\" % resource_type.get(\u0027extra_specs\u0027, None))"},{"line_number":360,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":361,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":362,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_80b08a8c","line":359,"updated":"2015-03-02 10:38:23.000000000","message":"The same: _LW() and msg should starts in upper-case","commit_id":"23d8a87b26340cf4946c2727f23f5d8f46a0e97f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f52ad994be2b105f7a00e09c23d6598d2ed28f56","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            LOG.warn(\"Volume properties %s\" % volume_properties)"},{"line_number":358,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":359,"context_line":"            LOG.warn(\"extra specs %s\" % resource_type.get(\u0027extra_specs\u0027, None))"},{"line_number":360,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":361,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":362,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_12f77ef6","line":359,"in_reply_to":"ba7be1f8_417cca20","updated":"2015-03-02 15:59:30.000000000","message":"Done","commit_id":"23d8a87b26340cf4946c2727f23f5d8f46a0e97f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d5f6f88f1f99e1833dae971dbceeb33b87c849b3","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            LOG.warn(\"Volume properties %s\" % volume_properties)"},{"line_number":358,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":359,"context_line":"            LOG.warn(\"extra specs %s\" % resource_type.get(\u0027extra_specs\u0027, None))"},{"line_number":360,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":361,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":362,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_417cca20","line":359,"in_reply_to":"ba7be1f8_80b08a8c","updated":"2015-03-02 15:07:48.000000000","message":"And in both of these log statements change LOG.warn(\"...\" % val) to LOG.warn(\"...\", val).","commit_id":"23d8a87b26340cf4946c2727f23f5d8f46a0e97f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b8efd06510c5a699c9999c10ce5f898faa533051","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            # If multiattach is enabled on a volume, we need to add"},{"line_number":355,"context_line":"            # multiattach to extra specs, so that the capability"},{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":358,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":359,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":360,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_7b73a7b1","line":357,"updated":"2015-03-04 07:38:57.000000000","message":"This doesn\u0027t look like necessary, because for consistency group, there is no place other than type extra specs that is able to carry this multiattach flag.  Xing can chime in and confirm.","commit_id":"1b22821530ef8a15ab5e9eebeee228c79b23a265"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ae5548f42bb07166ddc4bc96e5fca82c47480c0c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            # If multiattach is enabled on a volume, we need to add"},{"line_number":355,"context_line":"            # multiattach to extra specs, so that the capability"},{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":358,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":359,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":360,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_d9f811c7","line":357,"in_reply_to":"9a80dd14_7b73a7b1","updated":"2015-03-04 13:36:56.000000000","message":"Hi Winston, I think this is still needed for CG. The scheduler uses all the volume types supplied by the user in the create CG request and finds one backend that can support all volume types. So if multiattach is enabled, we want to make sure the backend chosen by the scheduler can support multiattach. Otherwise, the scheduler could choose a backend that doesn\u0027t have multiattach support.  What do you think?","commit_id":"1b22821530ef8a15ab5e9eebeee228c79b23a265"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bdec3b34d5e4ae9bffa9c0e90ee44d2309e36ac2","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            # If multiattach is enabled on a volume, we need to add"},{"line_number":355,"context_line":"            # multiattach to extra specs, so that the capability"},{"line_number":356,"context_line":"            # filtering is enabled."},{"line_number":357,"context_line":"            multiattach \u003d volume_properties.get(\u0027multiattach\u0027, False)"},{"line_number":358,"context_line":"            if multiattach and \u0027multiattach\u0027 not in resource_type.get("},{"line_number":359,"context_line":"                    \u0027extra_specs\u0027, {}):"},{"line_number":360,"context_line":"                resource_type[\u0027extra_specs\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_56c5c359","line":357,"in_reply_to":"9a80dd14_d9f811c7","updated":"2015-03-04 17:27:45.000000000","message":"as discussed in IRC, winston thinks this still isn\u0027t needed for creating a CG.  the multiattach flag is on a volume itself.","commit_id":"1b22821530ef8a15ab5e9eebeee228c79b23a265"}],"cinder/scheduler/host_manager.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"27fc72e44f86221004c8499305d776e14fa3d94a","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            self.thin_provisioning_support \u003d capability.get("},{"line_number":334,"context_line":"                \u0027thin_provisioning_support\u0027, False)"},{"line_number":335,"context_line":"            self.thick_provisioning_support \u003d capability.get("},{"line_number":336,"context_line":"                \u0027thick_provisioning_support\u0027, False)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def update_pools(self, capability):"},{"line_number":339,"context_line":"        # Do nothing, since we don\u0027t have pools within pool, yet"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_30769307","line":336,"updated":"2015-02-27 09:57:45.000000000","message":"need to fetch the \u0027multiattach\u0027 flag from capability here.","commit_id":"a1c1e433f08d35098213154a9c5daf06d5996233"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"155ad6a19015ba3f6eea40954d6c4de136f3dcba","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            self.thin_provisioning_support \u003d capability.get("},{"line_number":334,"context_line":"                \u0027thin_provisioning_support\u0027, False)"},{"line_number":335,"context_line":"            self.thick_provisioning_support \u003d capability.get("},{"line_number":336,"context_line":"                \u0027thick_provisioning_support\u0027, False)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def update_pools(self, capability):"},{"line_number":339,"context_line":"        # Do nothing, since we don\u0027t have pools within pool, yet"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_8a47f91c","line":336,"in_reply_to":"ba7be1f8_30769307","updated":"2015-02-27 17:40:03.000000000","message":"Done","commit_id":"a1c1e433f08d35098213154a9c5daf06d5996233"}]}