)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"57b98a0f2719ec03127e6bd33802dfab8379645b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def get_qemu_img_version():"},{"line_number":68,"context_line":"    info \u003d utils.execute(\u0027qemu-img\u0027, check_exit_code\u003dFalse)[0]"},{"line_number":69,"context_line":"    pattern \u003d r\"qemu-img version ([0-9\\.]*)\""},{"line_number":70,"context_line":"    version \u003d re.match(pattern, info)"},{"line_number":71,"context_line":"    if not version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_c19e4107","line":68,"updated":"2015-02-27 14:51:55.000000000","message":"I don\u0027t think this works for some versions of qemu-img, since the version number isn\u0027t printed when no args are passed.\n\n$ qemu-img\n\nqemu-img: Not enough arguments\n\nTry \u0027qemu-img --help\u0027 for more information\n\n\n\n\n\n$ qemu-img --help | head -n 1\n\nqemu-img version 2.1.3, Copyright (c) 2004-2008 Fabrice Bellard","commit_id":"c5d22b5cd79a45450afebbca4d24f83f593b9ead"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d595921eb49feb98546429a81dce94d569854309","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def get_qemu_img_version():"},{"line_number":68,"context_line":"    info \u003d utils.execute(\u0027qemu-img\u0027, check_exit_code\u003dFalse)[0]"},{"line_number":69,"context_line":"    pattern \u003d r\"qemu-img version ([0-9\\.]*)\""},{"line_number":70,"context_line":"    version \u003d re.match(pattern, info)"},{"line_number":71,"context_line":"    if not version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_046787eb","line":68,"in_reply_to":"ba7be1f8_c19e4107","updated":"2015-02-27 14:57:30.000000000","message":"Good point! Well, \u0027qemu-img --help\u0027 should do the job. I\u0027m updating the patch now.","commit_id":"c5d22b5cd79a45450afebbca4d24f83f593b9ead"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5ddff28a0a77de5242189dd09208945d89f3ef3d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def check_qemu_img_version(minimum_version):"},{"line_number":82,"context_line":"    qemu_version \u003d get_qemu_img_version()"},{"line_number":83,"context_line":"    if qemu_version \u003c _get_version_from_string(minimum_version):"},{"line_number":84,"context_line":"        current_version \u003d \u0027.\u0027.join((str(element) for element in qemu_version))"},{"line_number":85,"context_line":"        _msg \u003d _(\u0027qemu-img %(minimum_version)s or later is required by \u0027"},{"line_number":86,"context_line":"                 \u0027this volume driver. Current qemu-img version: \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_8f8699b7","line":83,"updated":"2015-03-03 23:32:52.000000000","message":"Will it work if qemu is not installed and  qemu_version is None? Please add unit test for such case","commit_id":"680f68a4ccc918b15d09ddf3c0f6e1a84a98ed2b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"abcf58ffabddac8158a3b47e2be5a2823f8c74a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def check_qemu_img_version(minimum_version):"},{"line_number":82,"context_line":"    qemu_version \u003d get_qemu_img_version()"},{"line_number":83,"context_line":"    if qemu_version \u003c _get_version_from_string(minimum_version):"},{"line_number":84,"context_line":"        current_version \u003d \u0027.\u0027.join((str(element) for element in qemu_version))"},{"line_number":85,"context_line":"        _msg \u003d _(\u0027qemu-img %(minimum_version)s or later is required by \u0027"},{"line_number":86,"context_line":"                 \u0027this volume driver. Current qemu-img version: \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c4958f89","line":83,"in_reply_to":"ba7be1f8_8f8699b7","updated":"2015-03-04 11:32:05.000000000","message":"Yes, the condition will evaluate as false in that case as well. I\u0027ll add an unit test for this, thanks for pointing this out!","commit_id":"680f68a4ccc918b15d09ddf3c0f6e1a84a98ed2b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"115ea3e8c085a679aaf36954d1d3cc7e63a00e5d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    return [int(x) for x in version_string.split(\u0027.\u0027)]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def check_qemu_img_version(minimum_version):"},{"line_number":82,"context_line":"    qemu_version \u003d get_qemu_img_version()"},{"line_number":83,"context_line":"    if qemu_version \u003c _get_version_from_string(minimum_version):"},{"line_number":84,"context_line":"        if qemu_version:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f8abf986","line":81,"updated":"2015-03-04 21:37:50.000000000","message":"Shouldn\u0027t this be called from somewhere?","commit_id":"b4f297f1b80e47f172548e033c2c3abde8fa966b"}]}