)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7c2e46e75b3cdfe9c80bd9bb408506614c2f7d7b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"a single server.  While this would certainly initialize"},{"line_number":17,"context_line":"the volume it would create a lot of extra work on a busy"},{"line_number":18,"context_line":"system.  We now break after the first map/unmap."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I89f3967144d7effbb67d1498fc3b4a7a23042a59"},{"line_number":21,"context_line":"Closes-Bug: 1426463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_cb549323","line":19,"updated":"2015-02-27 19:02:04.000000000","message":"Can you add a note that you are also updating copyrights?\n\nThanks!","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d855cf8febe7fca9b50ebc06aca0fda03664fc38","unresolved":false,"context_lines":[{"line_number":16,"context_line":"a single server.  While this would certainly initialize"},{"line_number":17,"context_line":"the volume it would create a lot of extra work on a busy"},{"line_number":18,"context_line":"system.  We now break after the first map/unmap."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I89f3967144d7effbb67d1498fc3b4a7a23042a59"},{"line_number":21,"context_line":"Closes-Bug: 1426463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_3df812e5","line":19,"in_reply_to":"ba7be1f8_cb549323","updated":"2015-02-27 19:13:43.000000000","message":"Added:  Changed copyright to 2015 to match when it will actually\nbe released.","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"}],"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7c2e46e75b3cdfe9c80bd9bb408506614c2f7d7b","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                     {\u0027instanceId\u0027: scvolume[\u0027instanceId\u0027],"},{"line_number":414,"context_line":"                      \u0027name\u0027: scvolume[\u0027name\u0027]})"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            # In theory it is there since success was returned."},{"line_number":418,"context_line":"            # Try one last time to find it before returning."},{"line_number":419,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_0b4f8b93","line":416,"updated":"2015-02-27 19:02:04.000000000","message":"I think it would be good to add a note that you are retrying here.","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d855cf8febe7fca9b50ebc06aca0fda03664fc38","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                     {\u0027instanceId\u0027: scvolume[\u0027instanceId\u0027],"},{"line_number":414,"context_line":"                      \u0027name\u0027: scvolume[\u0027name\u0027]})"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            # In theory it is there since success was returned."},{"line_number":418,"context_line":"            # Try one last time to find it before returning."},{"line_number":419,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_ddcff6b1","line":416,"in_reply_to":"ba7be1f8_0b4f8b93","updated":"2015-02-27 19:13:43.000000000","message":"Added:             LOG.error(_LE(\u0027Attempting to relocate volume\u0027))","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7c2e46e75b3cdfe9c80bd9bb408506614c2f7d7b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            # In theory it is there since success was returned."},{"line_number":418,"context_line":"            # Try one last time to find it before returning."},{"line_number":419,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return scvolume"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_8b737be6","line":419,"updated":"2015-02-27 19:02:04.000000000","message":"What happens if it is still empty at this point?","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d855cf8febe7fca9b50ebc06aca0fda03664fc38","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            # In theory it is there since success was returned."},{"line_number":418,"context_line":"            # Try one last time to find it before returning."},{"line_number":419,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return scvolume"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_9d6bbe84","line":419,"in_reply_to":"ba7be1f8_8b737be6","updated":"2015-02-27 19:13:43.000000000","message":"Well, the system is clearly in a bad way so all bets are off.  But a volume you can\u0027t find is effectively the same as a volume that doesn\u0027t exist so returning None back up to the calling routine is appropriate.  find_volume will return None if it can\u0027t locate the volume.","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"beaa374d36b0e094b5c9d3024e2bae72be55e4a6","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            # In theory it is there since success was returned."},{"line_number":418,"context_line":"            # Try one last time to find it before returning."},{"line_number":419,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return scvolume"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f0069820","line":419,"in_reply_to":"ba7be1f8_9d6bbe84","updated":"2015-02-27 23:26:53.000000000","message":"Ok.  That was what I figured but wanted to make sure that was the intended behavior.","commit_id":"ef61bb72fa79a1e5e23a8dc31f0998ebdc908663"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"dfc409c567576eb71dcbcb7c3e6e41996af90297","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                      \u0027name\u0027: scvolume[\u0027name\u0027]})"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            LOG.error(_LE(\u0027Attempting to relocate volume\u0027))"},{"line_number":418,"context_line":"            # In theory it is there since success was returned."},{"line_number":419,"context_line":"            # Try one last time to find it before returning."},{"line_number":420,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_d367dee8","line":417,"updated":"2015-02-27 23:26:45.000000000","message":"Ok, this message is confusing me further.  You are trying to create a volume.  the object comes back empty.  So you retry.  Do you mean \u0027Attempting to locate volume.\u0027 ?  That would make more sense.  If so, can you change it accordingly, and make it one LOG.error message:\n\nLOG.error(_LE(\u0027ScVolume returned success with empty payload.  Attempting to locate volume.\u0027))\n\nThanks!","commit_id":"d282e1c33b82a3346a33120656f92b70cabcb699"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"448bf4fa50b64c68ccc4cc7bb6644a530b52b4ee","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                      \u0027name\u0027: scvolume[\u0027name\u0027]})"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            LOG.error(_LE(\u0027ScVolume returned success with empty payload.\u0027))"},{"line_number":417,"context_line":"            LOG.error(_LE(\u0027Attempting to relocate volume\u0027))"},{"line_number":418,"context_line":"            # In theory it is there since success was returned."},{"line_number":419,"context_line":"            # Try one last time to find it before returning."},{"line_number":420,"context_line":"            scvolume \u003d self.find_volume(ssn, name, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c4e0f6fc","line":417,"in_reply_to":"ba7be1f8_d367dee8","updated":"2015-02-28 02:05:09.000000000","message":"Done","commit_id":"d282e1c33b82a3346a33120656f92b70cabcb699"}]}