)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c09b236b825815a3878445e2b967894fdfc977f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gfm \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-27 19:36:23 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: 1422903"},{"line_number":8,"context_line":"Add quotes around pool name so name with imbedded spaces is a single argument."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Quotes aournd the name make it a single argumen to the SVC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_57e744e4","line":7,"updated":"2015-03-01 23:11:04.000000000","message":"Please, move this line to the end of a commit message","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"583214f38903db56f30a0c2e9fc986c61995e695","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gfm \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-27 19:36:23 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: 1422903"},{"line_number":8,"context_line":"Add quotes around pool name so name with imbedded spaces is a single argument."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Quotes aournd the name make it a single argumen to the SVC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_38ce2384","line":7,"in_reply_to":"ba7be1f8_57e744e4","updated":"2015-03-02 16:33:21.000000000","message":"Also, the title should be at maximum of 50 characters and cannot have a dot in the end.\nSee https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7c252f964d0ce752563705df0b0b6a20316a8f0b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Closes-Bug: 1422903"},{"line_number":8,"context_line":"Add quotes around pool name so name with imbedded spaces is a single argument."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Quotes aournd the name make it a single argumen to the SVC."},{"line_number":11,"context_line":"This chane will prevent the SVC from returning a usage error and failing the requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic96304b907913dd8b11a583f03d169f314d851de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_9367f0b6","line":10,"updated":"2015-03-02 16:47:30.000000000","message":"argumen -\u003e argument","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c09b236b825815a3878445e2b967894fdfc977f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Closes-Bug: 1422903"},{"line_number":8,"context_line":"Add quotes around pool name so name with imbedded spaces is a single argument."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Quotes aournd the name make it a single argumen to the SVC."},{"line_number":11,"context_line":"This chane will prevent the SVC from returning a usage error and failing the requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic96304b907913dd8b11a583f03d169f314d851de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_77ea88ad","line":10,"updated":"2015-03-01 23:11:04.000000000","message":"around","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7c252f964d0ce752563705df0b0b6a20316a8f0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add quotes around pool name so name with imbedded spaces is a single argument."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Quotes aournd the name make it a single argumen to the SVC."},{"line_number":11,"context_line":"This chane will prevent the SVC from returning a usage error and failing the requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic96304b907913dd8b11a583f03d169f314d851de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_1313000e","line":11,"updated":"2015-03-02 16:47:30.000000000","message":"Please wrap your lines a little earlier.","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"34d78adf469e6a85419c0c0c2edf10bebea47726","unresolved":false,"context_lines":[{"line_number":13,"context_line":"What is happening today is SVC returns a usage"},{"line_number":14,"context_line":"error and fails the request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Update unit tests to verify quotes where added."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1422903"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_494fbd34","line":16,"updated":"2015-03-17 20:38:20.000000000","message":"where / were","commit_id":"1c06d57ea6adad929b08d810405f6480e5752296"}],"cinder/volume/drivers/ibm/storwize_svc/ssh.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"521f1a01f4f91e52cdabd51861a027506e5839d6","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def lsmdiskgrp(self, pool):"},{"line_number":92,"context_line":"        ssh_cmd \u003d [\u0027svcinfo\u0027, \u0027lsmdiskgrp\u0027, \u0027-bytes\u0027, \u0027-delim\u0027, \u0027!\u0027,"},{"line_number":93,"context_line":"                   \"%s\" % pool]"},{"line_number":94,"context_line":"        return self.run_ssh_info(ssh_cmd)[0]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def lsiogrp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f1fda8b2","line":93,"updated":"2015-03-01 16:58:25.000000000","message":"This will not add quotes around the command in ssh, indeed if pool is a string then it is functionally identical. We don\u0027t pass any of our args through a shell, so there should be no splitting of parameters going on. If the IBM controller requires explicit quotes, then you probably want: \n\u0027\"%s\"\u0027 % pool","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"521f1a01f4f91e52cdabd51861a027506e5839d6","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def mkvdisk(self, name, size, units, pool, opts, params):"},{"line_number":195,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027mkvdisk\u0027, \u0027-name\u0027, name, \u0027-mdiskgrp\u0027,"},{"line_number":196,"context_line":"                   \"%s\" % pool, \u0027-iogrp\u0027, str(opts[\u0027iogrp\u0027]), \u0027-size\u0027,"},{"line_number":197,"context_line":"                   size, \u0027-unit\u0027, units] + params"},{"line_number":198,"context_line":"        return self.run_ssh_check_created(ssh_cmd)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def rmvdisk(self, vdisk, force\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_112cfc49","line":197,"updated":"2015-03-01 16:58:25.000000000","message":"As above","commit_id":"d2743c562ecad311190a700d44c2a93f28055d9b"}]}