)]}'
{"cinder/volume/drivers/datera.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"535d225f043c2f47fa622366ae0d4dbabe4fa599","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Ensure the driver is authenticated to make a request."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        In do_setup() we fetch an auth token and store it. If that expires when"},{"line_number":59,"context_line":"        we do API request, we\u0027ll fetch a new one. If that fails, we\u0027ll log the"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        def func_wrapper(self, *args, **kwargs):"},{"line_number":62,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_4d8789b5","line":59,"updated":"2015-03-02 22:38:21.000000000","message":"did part of the comment get cut off? \"we\u0027ll log the\"","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7b9c3c9fc086d36921dd08e5374bc264d4d59503","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\"Ensure the driver is authenticated to make a request."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        In do_setup() we fetch an auth token and store it. If that expires when"},{"line_number":59,"context_line":"        we do API request, we\u0027ll fetch a new one. If that fails, we\u0027ll log the"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        def func_wrapper(self, *args, **kwargs):"},{"line_number":62,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_38552e50","line":59,"in_reply_to":"ba7be1f8_4d8789b5","updated":"2015-03-03 00:40:49.000000000","message":"Done","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2f83eb5070994e2b245eca387f3350a8a854e1de","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                # resource_type arg from _issue_api_request(). If attempt to"},{"line_number":67,"context_line":"                # login failed, we should just give up."},{"line_number":68,"context_line":"                if args[0] \u003d\u003d \u0027login\u0027:"},{"line_number":69,"context_line":"                    raise ex"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"                # Token might\u0027ve expired, get a new one, try again."},{"line_number":72,"context_line":"                self._login()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_df7a3c87","line":69,"updated":"2015-03-02 22:44:48.000000000","message":"Should just be \"raise\" not \"raise ex\".","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7b9c3c9fc086d36921dd08e5374bc264d4d59503","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                # resource_type arg from _issue_api_request(). If attempt to"},{"line_number":67,"context_line":"                # login failed, we should just give up."},{"line_number":68,"context_line":"                if args[0] \u003d\u003d \u0027login\u0027:"},{"line_number":69,"context_line":"                    raise ex"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"                # Token might\u0027ve expired, get a new one, try again."},{"line_number":72,"context_line":"                self._login()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_5852e267","line":69,"in_reply_to":"ba7be1f8_df7a3c87","updated":"2015-03-03 00:40:49.000000000","message":"Done","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2f83eb5070994e2b245eca387f3350a8a854e1de","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        self.cluster_stats \u003d stats"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _login(self):"},{"line_number":253,"context_line":"        \"Use the san_login and san_password to set self.auth_token\""},{"line_number":254,"context_line":"        data \u003d {"},{"line_number":255,"context_line":"            \u0027name\u0027: self.username,"},{"line_number":256,"context_line":"            \u0027password\u0027: self.password"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_5fad6ce8","line":253,"updated":"2015-03-02 22:44:48.000000000","message":"Is this supposed to be a doc comment?","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7b9c3c9fc086d36921dd08e5374bc264d4d59503","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        self.cluster_stats \u003d stats"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _login(self):"},{"line_number":253,"context_line":"        \"Use the san_login and san_password to set self.auth_token\""},{"line_number":254,"context_line":"        data \u003d {"},{"line_number":255,"context_line":"            \u0027name\u0027: self.username,"},{"line_number":256,"context_line":"            \u0027password\u0027: self.password"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b8c83e23","line":253,"in_reply_to":"ba7be1f8_5fad6ce8","updated":"2015-03-03 00:40:49.000000000","message":"Done","commit_id":"f765e2dc130609dba401adbe735708946d2f628e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"49ff93c2a7704bde211a2b271d292588e98c7d22","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        ]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if any(DEPRECATED_OPTS):"},{"line_number":104,"context_line":"            LOG.warn(_LW(\"Client cert verification is deprecated in the \""},{"line_number":105,"context_line":"                         \"Datera Driver, and will be removed in the Liberty \""},{"line_number":106,"context_line":"                         \"release. Please set the san_login and san_password \""},{"line_number":107,"context_line":"                         \"in your cinder.conf instead.\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_afe51d39","line":104,"updated":"2015-03-03 23:28:13.000000000","message":"Please, use versionutils.report_deprecated_feature from oslo-incubator [1]\n\nWe\u0027ve got LOG.deprecated method in oslo-incubator/log module but it will be replaced with [1] after switching to oslo.log\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/openstack/common/versionutils.py#L220","commit_id":"36bf3aa7fb55f26e3f989d70fec4445b79abda09"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"f4de6728df5e1511865d570b9fd78352bac1c0c5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        ]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if any(DEPRECATED_OPTS):"},{"line_number":104,"context_line":"            LOG.warn(_LW(\"Client cert verification is deprecated in the \""},{"line_number":105,"context_line":"                         \"Datera Driver, and will be removed in the Liberty \""},{"line_number":106,"context_line":"                         \"release. Please set the san_login and san_password \""},{"line_number":107,"context_line":"                         \"in your cinder.conf instead.\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_71039f0f","line":104,"in_reply_to":"ba7be1f8_afe51d39","updated":"2015-03-05 01:41:04.000000000","message":"Done","commit_id":"36bf3aa7fb55f26e3f989d70fec4445b79abda09"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"49ff93c2a7704bde211a2b271d292588e98c7d22","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        payload.encode(\u0027utf-8\u0027)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if not sensitive:"},{"line_number":292,"context_line":"            LOG.debug(\"Payload for Datera API call: %s\", payload)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        header \u003d {"},{"line_number":295,"context_line":"            \u0027Content-Type\u0027: \u0027application/json; charset\u003dutf-8\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_4f282133","line":292,"updated":"2015-03-03 23:28:13.000000000","message":"Won\u0027t block patch for it, just a proposal: it could be useful to not log only sensitive data(username, password, etc) but it makes code more complicated","commit_id":"36bf3aa7fb55f26e3f989d70fec4445b79abda09"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"f4de6728df5e1511865d570b9fd78352bac1c0c5","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        payload.encode(\u0027utf-8\u0027)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if not sensitive:"},{"line_number":292,"context_line":"            LOG.debug(\"Payload for Datera API call: %s\", payload)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        header \u003d {"},{"line_number":295,"context_line":"            \u0027Content-Type\u0027: \u0027application/json; charset\u003dutf-8\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_d85f0b0d","line":292,"in_reply_to":"ba7be1f8_4f282133","updated":"2015-03-05 01:41:04.000000000","message":"cfg.config secret option might help with this. I\u0027ll test this next and post another patch if it does.","commit_id":"36bf3aa7fb55f26e3f989d70fec4445b79abda09"}]}