)]}'
{"cinder/test.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2c601671edb58557df3562bab12aaad8c65e9d07","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                os.path.join(CONF.state_path, self.sqlite_db))"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _patch_mock_to_raise_for_invalid_assert_calls():"},{"line_number":104,"context_line":"    def raise_for_invalid_assert_calls(wrapped):"},{"line_number":105,"context_line":"        def wrapper(_self, name):"},{"line_number":106,"context_line":"            valid_asserts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_bafc8773","line":103,"updated":"2015-03-08 23:02:06.000000000","message":"Looks like a good candidate to move it to oslotest","commit_id":"c5c43c8db3dfbf6cdc8d7da42b2be88705170771"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e31d795582f9f948477ee82964cee11816331653","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                \u0027assert_any_calls\u0027]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            if name.startswith(\u0027assert\u0027) and name not in valid_asserts:"},{"line_number":113,"context_line":"                raise AttributeError(\u0027%s is not a valid mock assert method\u0027"},{"line_number":114,"context_line":"                                     % name)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"            return wrapped(_self, name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_617a7178","line":113,"updated":"2015-03-07 20:00:59.000000000","message":"If you do another update, I think our general practice has been to end with a period.","commit_id":"c5c43c8db3dfbf6cdc8d7da42b2be88705170771"}],"cinder/tests/test_test.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"75838785f6911d69aa8096017f7b9a44809766c7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mock_call.assert_called_once_with(1, \u0027foobar\u0027, a\u003d\u0027123\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_invalid_assert_calls(self):"},{"line_number":76,"context_line":"        mock_call \u003d mock.MagicMock()"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_2ec69c68","line":76,"updated":"2015-03-09 00:39:53.000000000","message":"Should be:\nself.assertRaises(AttributeError, mock_call.assert_called)","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"85771eb62bd9b3bde0dc231e86c36e9773722b59","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mock_call.assert_called_once_with(1, \u0027foobar\u0027, a\u003d\u0027123\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_invalid_assert_calls(self):"},{"line_number":76,"context_line":"        mock_call \u003d mock.MagicMock()"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_dcfbe444","line":76,"in_reply_to":"9a80dd14_2ec69c68","updated":"2015-03-09 14:45:53.000000000","message":"After a little googling, found out all I needed was a lambda function :P","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"b5c27bd08dace5fae75dcc3759b44dbe369f329e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mock_call.assert_called_once_with(1, \u0027foobar\u0027, a\u003d\u0027123\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_invalid_assert_calls(self):"},{"line_number":76,"context_line":"        mock_call \u003d mock.MagicMock()"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_ee8ac4bd","line":76,"in_reply_to":"9a80dd14_2ec69c68","updated":"2015-03-09 01:16:10.000000000","message":"I tried it that way, and it did not work.  The method enters raise_for_invalid_assert_calls and raises AttributeError and just does not enter self.assertRaises.  Hence, I had to do it this way.","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"535766f4e9a73af60d63379932a76ab7cc9e01b5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mock_call.assert_called_once_with(1, \u0027foobar\u0027, a\u003d\u0027123\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_invalid_assert_calls(self):"},{"line_number":76,"context_line":"        mock_call \u003d mock.MagicMock()"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_ae17c843","line":76,"in_reply_to":"9a80dd14_dcfbe444","updated":"2015-03-09 21:10:16.000000000","message":"Interesting... I\u0027ll take a look closer on it tomorrow before I\u0027ll +2 on it","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"e01ceff5bdd211379db2c69f46f4dc097358b9f7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mock_call.assert_called_once_with(1, \u0027foobar\u0027, a\u003d\u0027123\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_invalid_assert_calls(self):"},{"line_number":76,"context_line":"        mock_call \u003d mock.MagicMock()"},{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_2e7f7cac","line":76,"in_reply_to":"9a80dd14_ee8ac4bd","updated":"2015-03-09 01:21:31.000000000","message":"This is what I get:\n\n    Traceback (most recent call last):\n      File \"/opt/stack/cinder/cinder/tests/test_test.py\", line 77, in test_invalid_assert_calls\n        self.assertRaises(AttributeError, mock_call.assert_called)\n      File \"/opt/stack/cinder/cinder/test.py\", line 114, in wrapper\n        % name)\n    AttributeError: assert_called is not a valid mock assert method\n\nIf I have:\n\n    def test_invalid_assert_calls(self):\n        mock_call \u003d mock.MagicMock()\n        self.assertRaises(AttributeError, mock_call.assert_called)","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"9546d015b9785d883406044a01ef6bca6047090b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            mock_call.assert_called()"},{"line_number":79,"context_line":"        except AttributeError:"},{"line_number":80,"context_line":"            assert True"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_5801ce03","line":80,"updated":"2015-03-09 06:58:11.000000000","message":"Missing an assert false after the try catch block?","commit_id":"e2251dcc1c6345f3a7912ecaa4d637f1852dd8dc"}]}