)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cefae869c9428dde5c6173494e066e6afb08753c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-03 11:17:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: remove useless variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ieb0871e0da707d34338c0aa7b2bafccf9267b3d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_0795f6e3","line":7,"updated":"2015-03-04 05:30:47.000000000","message":"Please provide a better description of what this patch does and why it\u0027s needed.","commit_id":"46637a782520790799a18b9f9bc93cf920f23eee"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"af5ba21e0bc717354ec28893d194a6a54bd8f877","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julien Danjou \u003cjulien@danjou.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-03 11:17:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: remove useless variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ieb0871e0da707d34338c0aa7b2bafccf9267b3d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_5e0f8330","line":7,"in_reply_to":"9a80dd14_0795f6e3","updated":"2015-03-05 03:01:17.000000000","message":"Are you seriously refusing a patch (-1 vote) because of this changelog? IMO the changelog is obvious and doesn\u0027t need to be longer.\n\nThe change removes a variable in tests, because the variable is not used. That\u0027s all folks!","commit_id":"46637a782520790799a18b9f9bc93cf920f23eee"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"7f81a54d488bc4a2760af62e3f210780dd350014","unresolved":false,"context_lines":[{"line_number":76,"context_line":"CONF \u003d cfg.CONF"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENCRYPTION_PROVIDER \u003d \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027"},{"line_number":79,"context_line":"PLATFORM \u003d sys.platform"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaa\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_3b88ac70","side":"PARENT","line":79,"updated":"2015-03-03 14:14:11.000000000","message":"The \"sys.platform\" is used, why not use PLATFORM instead \"sys.platform\"?","commit_id":"4adb20773ff5c506aed904b002610c3293cbf964"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"af5ba21e0bc717354ec28893d194a6a54bd8f877","unresolved":false,"context_lines":[{"line_number":76,"context_line":"CONF \u003d cfg.CONF"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENCRYPTION_PROVIDER \u003d \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027"},{"line_number":79,"context_line":"PLATFORM \u003d sys.platform"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaa\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fb184986","side":"PARENT","line":79,"in_reply_to":"9a80dd14_24174bef","updated":"2015-03-05 03:01:17.000000000","message":"\u003e No, I gave -1, because at line #2466 \"sys.platform\" is used and as we have a variable which has this value, it was good if the variable was used.\n\nThe whole purpose of the patch is to remove the variable because it\u0027s not used currently. Why do you want to use this variable?\n\nWhy do you consider that it\u0027s a good thing to use a custom alias PLATFORM instead of using directly the well known and well documented sys.platform?","commit_id":"4adb20773ff5c506aed904b002610c3293cbf964"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"f9842f2ce47e6967cbf74d4fed0753999f088400","unresolved":false,"context_lines":[{"line_number":76,"context_line":"CONF \u003d cfg.CONF"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENCRYPTION_PROVIDER \u003d \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027"},{"line_number":79,"context_line":"PLATFORM \u003d sys.platform"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaa\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0e94cf35","side":"PARENT","line":79,"in_reply_to":"9a80dd14_fb184986","updated":"2015-03-05 19:23:29.000000000","message":"Ok, I accept your point, even being different from my point..","commit_id":"4adb20773ff5c506aed904b002610c3293cbf964"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3d14e07d9a3f9b906f99dcd7f4dd11ee74a6c4a7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"CONF \u003d cfg.CONF"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENCRYPTION_PROVIDER \u003d \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027"},{"line_number":79,"context_line":"PLATFORM \u003d sys.platform"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaa\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_9e41863b","side":"PARENT","line":79,"in_reply_to":"ba7be1f8_3b88ac70","updated":"2015-03-03 14:27:16.000000000","message":"because it\u0027s useless?\n\nDid you really -1 this patch for a question?","commit_id":"4adb20773ff5c506aed904b002610c3293cbf964"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"36ddc6e9a979a5f4b323d2faa99a03a2c95349a1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"CONF \u003d cfg.CONF"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENCRYPTION_PROVIDER \u003d \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027"},{"line_number":79,"context_line":"PLATFORM \u003d sys.platform"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"FAKE_UUID \u003d \u0027aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaa\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_24174bef","side":"PARENT","line":79,"in_reply_to":"ba7be1f8_9e41863b","updated":"2015-03-04 11:40:20.000000000","message":"No, I gave -1, because at line #2466 \"sys.platform\" is used and as we have a variable which has this value, it was good if the variable was used.","commit_id":"4adb20773ff5c506aed904b002610c3293cbf964"}]}
