)]}'
{"cinder/volume/targets/cxt.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5e587c5bb96837f9b99b418fa29f938155673eac","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iscsi_target \u003d 1"},{"line_number":89,"context_line":"        return iscsi_target, lun"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _ensure_iscsi_targets(self, context, host):"},{"line_number":92,"context_line":"        \"\"\"Ensure that target ids have been created in datastore.\"\"\""},{"line_number":93,"context_line":"        # NOTE : This is probably not required for chiscsi"},{"line_number":94,"context_line":"        # TODO(jdg): In the future move all of the dependent stuff into the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_e7281999","side":"PARENT","line":91,"updated":"2015-03-04 01:01:19.000000000","message":"It doesn\u0027t look like this is used anywhere so it should be safe to remove, but you don\u0027t mention it in your commit so I wasn\u0027t sure if it was intentional.  Can you update the commit message if this was an intentional removal?  Thanks!","commit_id":"2f5eab9ed7548e04869cc4823817480a1cf51f06"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d71f8912f1ea3300fde2571ef9f3b54a123c42d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iscsi_target \u003d 1"},{"line_number":89,"context_line":"        return iscsi_target, lun"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _ensure_iscsi_targets(self, context, host):"},{"line_number":92,"context_line":"        \"\"\"Ensure that target ids have been created in datastore.\"\"\""},{"line_number":93,"context_line":"        # NOTE : This is probably not required for chiscsi"},{"line_number":94,"context_line":"        # TODO(jdg): In the future move all of the dependent stuff into the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_ea6f005e","side":"PARENT","line":91,"in_reply_to":"ba7be1f8_6accf0bb","updated":"2015-03-04 01:13:42.000000000","message":"Thanks for confirming.  If we can update the commit message accordingly, then I think this is ready to go.","commit_id":"2f5eab9ed7548e04869cc4823817480a1cf51f06"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"26238f2a5f4c5ec021b1e534fcae818c4983e256","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iscsi_target \u003d 1"},{"line_number":89,"context_line":"        return iscsi_target, lun"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _ensure_iscsi_targets(self, context, host):"},{"line_number":92,"context_line":"        \"\"\"Ensure that target ids have been created in datastore.\"\"\""},{"line_number":93,"context_line":"        # NOTE : This is probably not required for chiscsi"},{"line_number":94,"context_line":"        # TODO(jdg): In the future move all of the dependent stuff into the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6accf0bb","side":"PARENT","line":91,"in_reply_to":"ba7be1f8_e7281999","updated":"2015-03-04 01:06:47.000000000","message":"Can confirm this code is unused (I wrote this code). It was originally present in the tgt driver(and others) which I used as a template, but was removed in the timeframe between uploading my code for review and it being committed and slipped through.","commit_id":"2f5eab9ed7548e04869cc4823817480a1cf51f06"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"9645e75def41ecd2a21c6b57f5424d2d5d55685c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        iscsi_target \u003d 1"},{"line_number":89,"context_line":"        return iscsi_target, lun"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _ensure_iscsi_targets(self, context, host):"},{"line_number":92,"context_line":"        \"\"\"Ensure that target ids have been created in datastore.\"\"\""},{"line_number":93,"context_line":"        # NOTE : This is probably not required for chiscsi"},{"line_number":94,"context_line":"        # TODO(jdg): In the future move all of the dependent stuff into the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4ad00cc9","side":"PARENT","line":91,"in_reply_to":"ba7be1f8_ea6f005e","updated":"2015-03-04 01:20:16.000000000","message":"I\u0027ll leave that for Mitsuhiro, since he\u0027s the actual author of this patchset","commit_id":"2f5eab9ed7548e04869cc4823817480a1cf51f06"}],"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"61c4a5459d56da12f6c9bd1767eaa6b2b770f049","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.protocol \u003d \u0027iSCSI\u0027"},{"line_number":43,"context_line":"        self.volumes_dir \u003d self.configuration.safe_get(\u0027volumes_dir\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if self.configuration.safe_get(\u0027iscsi_num_targets\u0027) is not None:"},{"line_number":46,"context_line":"            LOG.warning(_LW(\"The iscsi_num_targets option has been \""},{"line_number":47,"context_line":"                            \"deprecated and no longer has any effect.\"))"},{"line_number":48,"context_line":"        if self.configuration.safe_get(\u0027iser_num_targets\u0027) is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_5a5d4b14","line":45,"updated":"2015-03-08 22:01:08.000000000","message":"Please, use versionutils.report_deprecated_feature from oslo-incubator instead of LOG.warning","commit_id":"579b8a4a56f12fb4078590e15a73caa8de72e4b1"}]}