)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"91e6c0d29fd07644710a577617969b4da29d3d2c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch will assign default value of gpfs_images_share_mode"},{"line_number":10,"context_line":"option used in gpfs.py to None instead of \u0027copy_on_write\u0027."},{"line_number":11,"context_line":"Initializing it with \u0027copy_on_write\u0027 breaks the setup. It is"},{"line_number":12,"context_line":"needed only if the user configures gpfs_images_dir option."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I73e91f7d41fa97a8b2f05dac55c665d1f6dedf07"},{"line_number":15,"context_line":"Closes-Bug: #1427713"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_c08d5b33","line":12,"updated":"2015-03-04 23:38:07.000000000","message":"Are you saying that setting this value to \u0027copy_on_write\u0027 is broken if gpfs_images_dir isn\u0027t set?\n\nIf so, shouldn\u0027t we bet testing for this in the code and adding unit tests?","commit_id":"5ce01f4bf8d5efdc41a4e23c0474825d0773917c"},{"author":{"_account_id":9067,"name":"Nilesh Bhosale","email":"nilesh.bhosale@in.ibm.com","username":"nileshbhosale"},"change_message_id":"cefb2287097876da9b5d3ed33e0d784e26adc76d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch will assign default value of gpfs_images_share_mode"},{"line_number":10,"context_line":"option used in gpfs.py to None instead of \u0027copy_on_write\u0027."},{"line_number":11,"context_line":"Initializing it with \u0027copy_on_write\u0027 breaks the setup. It is"},{"line_number":12,"context_line":"needed only if the user configures gpfs_images_dir option."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I73e91f7d41fa97a8b2f05dac55c665d1f6dedf07"},{"line_number":15,"context_line":"Closes-Bug: #1427713"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_240e42e6","line":12,"in_reply_to":"9a80dd14_48b9fb77","updated":"2015-03-17 15:32:05.000000000","message":"OK, looks good then.","commit_id":"5ce01f4bf8d5efdc41a4e23c0474825d0773917c"},{"author":{"_account_id":9067,"name":"Nilesh Bhosale","email":"nilesh.bhosale@in.ibm.com","username":"nileshbhosale"},"change_message_id":"283c00ce9c17d1a2dbe6aafbfdceac3bd0f9c062","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch will assign default value of gpfs_images_share_mode"},{"line_number":10,"context_line":"option used in gpfs.py to None instead of \u0027copy_on_write\u0027."},{"line_number":11,"context_line":"Initializing it with \u0027copy_on_write\u0027 breaks the setup. It is"},{"line_number":12,"context_line":"needed only if the user configures gpfs_images_dir option."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I73e91f7d41fa97a8b2f05dac55c665d1f6dedf07"},{"line_number":15,"context_line":"Closes-Bug: #1427713"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_4f126fb2","line":12,"in_reply_to":"9a80dd14_c08d5b33","updated":"2015-03-05 05:17:12.000000000","message":"+1. Sasi, please make sure this scenario is covered in the unit tests.","commit_id":"5ce01f4bf8d5efdc41a4e23c0474825d0773917c"},{"author":{"_account_id":9204,"name":"Sasikanth Eda","email":"sasikanth.eda@in.ibm.com","username":"Sasikanth"},"change_message_id":"eb0785f9cc15bf1950c60e66e37ca033186a999b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch will assign default value of gpfs_images_share_mode"},{"line_number":10,"context_line":"option used in gpfs.py to None instead of \u0027copy_on_write\u0027."},{"line_number":11,"context_line":"Initializing it with \u0027copy_on_write\u0027 breaks the setup. It is"},{"line_number":12,"context_line":"needed only if the user configures gpfs_images_dir option."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I73e91f7d41fa97a8b2f05dac55c665d1f6dedf07"},{"line_number":15,"context_line":"Closes-Bug: #1427713"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_48b9fb77","line":12,"in_reply_to":"9a80dd14_c08d5b33","updated":"2015-03-09 10:28:09.000000000","message":"Hi Hemna, this negative case is already covered in\n(test_check_for_setup_error_fail_conf) line - 518.\nThe check_for_setup_error fails if gpfs_images_share_mode is set to either \u0027copy\u0027 or \u0027copy_on_write\u0027 and gpfs_images_dir is None.","commit_id":"5ce01f4bf8d5efdc41a4e23c0474825d0773917c"}]}