)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2fcc98d7f8fac50075410e36a279b85e73504387","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Choices for iscsi_helper does not contain scstadmin."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the code merged by the following review link, scstadmin was"},{"line_number":10,"context_line":"missing from the choices for iscsi_helper. This will cause"},{"line_number":11,"context_line":"SCST target helper functionality to not work properly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_19f1c9cd","line":9,"updated":"2015-03-04 13:37:48.000000000","message":"The review link is missing.  Can you please add?  Thanks!","commit_id":"0cca976ea7db1c51531f9da81e616ca61b8ef560"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae7b2d523403b34b28eae092f25959c21a57064e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to not work properly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"https://review.openstack.org/#/c/158580/5/cinder/volume/driver.py"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cfg.StrOpt(\u0027iscsi_helper\u0027,"},{"line_number":17,"context_line":"           default\u003d\u0027tgtadm\u0027,"},{"line_number":18,"context_line":"           choices\u003d[\u0027tgtadm\u0027, \u0027lioadm\u0027, \u0027iseradm\u0027, \u0027iscsictl\u0027, \u0027fake\u0027],"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_f8269967","line":15,"updated":"2015-03-04 21:36:46.000000000","message":"The link to gerrit and old code don\u0027t really need to be in the commit message... description and the patch itself are sufficient.","commit_id":"1e83a41daf9574028292b43711c4b1a505119f16"},{"author":{"_account_id":14863,"name":"Diego Zamboni Latance","email":"dzambonil@gmail.com","username":"DiegoZamboni"},"change_message_id":"ff55c9ec753d7ca1e50b55fc27c31ce323bba5d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nikeshmahalka \u003cNikesh.Mahalka@emulex.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-05 09:41:17 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Two choices for iscsi_helper is missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the cinder/volume/driver.py, scstadmin and ietadm were missing from"},{"line_number":10,"context_line":"the choices for iscsi_helper. This will cause SCST and IET target helper"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_a293eb4d","line":7,"updated":"2015-03-05 14:03:41.000000000","message":"Two choices for iscsi_helper ARE missing. Don\u0027t know how relevant this is, just thought it would be good to report.","commit_id":"ed346a6939896ef0e9dc32fec011a992c33fbb74"}],"cinder/volume/driver.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"6fb7158dada439824c365fa228a87023ba6520f3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    \u0027for example \"-c3\" for idle only priority.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027iscsi_helper\u0027,"},{"line_number":97,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":98,"context_line":"               choices\u003d[\u0027tgtadm\u0027, \u0027lioadm\u0027, \u0027scstadmin\u0027, \u0027iseradm\u0027, \u0027iscsictl\u0027,"},{"line_number":99,"context_line":"                        \u0027fake\u0027],"},{"line_number":100,"context_line":"               help\u003d\u0027iSCSI target user-land tool to use. tgtadm is default, \u0027"},{"line_number":101,"context_line":"                    \u0027use lioadm for LIO iSCSI support, scstadmin for SCST \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e7cd2388","line":98,"updated":"2015-03-04 18:33:48.000000000","message":"Also missing is \u0027ietadm\u0027\n\nHere\u0027s the full list:\n\n        self.target_mapping \u003d {\n            \u0027fake\u0027: \u0027cinder.volume.targets.fake.FakeTarget\u0027,\n            \u0027ietadm\u0027: \u0027cinder.volume.targets.iet.IetAdm\u0027,\n            \u0027iseradm\u0027: \u0027cinder.volume.targets.iser.ISERTgtAdm\u0027,\n            \u0027lioadm\u0027: \u0027cinder.volume.targets.lio.LioAdm\u0027,\n            \u0027tgtadm\u0027: \u0027cinder.volume.targets.tgt.TgtAdm\u0027,\n            \u0027scstadmin\u0027: \u0027cinder.volume.targets.scst.SCSTAdm\u0027,\n            \u0027iscsictl\u0027: \u0027cinder.volume.targets.cxt.CxtAdm\u0027}","commit_id":"b1e365063f55a7a745331151ae065fc2bfabf508"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4b8528b194d364b2d2dd3215dd780e78560d2ebd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \u0027use lioadm for LIO iSCSI support, scstadmin for SCST \u0027"},{"line_number":102,"context_line":"                    \u0027target support, iseradm for the ISER protocol, \u0027"},{"line_number":103,"context_line":"                    \u0027ietadm for iSCSI Enterprise Target, \u0027"},{"line_number":104,"context_line":"                    \u0027iscsictl for Chelsio iSCSI Target or fake for testing.\u0027),"},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027volumes_dir\u0027,"},{"line_number":106,"context_line":"               default\u003d\u0027$state_path/volumes\u0027,"},{"line_number":107,"context_line":"               help\u003d\u0027Volume configuration file storage \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_c9303159","line":104,"updated":"2015-03-04 19:50:04.000000000","message":"Nit, but you can move a few words from this line up to the previous line.","commit_id":"ee558b2bd5d1be27e5bd8bf733ce0b6bf0f161bb"}]}