)]}'
{"cinder/tests/test_eqlx.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"2b07cb5ff9dc9fdf6a79f950f379d30fee186b72","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        chan.invoke_shell()"},{"line_number":314,"context_line":"        mock_get_output.return_value \u003d expected_output"},{"line_number":315,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":316,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":317,"context_line":"        chan.send(\u0027stty columns 255\u0027 + \u0027\\r\u0027)"},{"line_number":318,"context_line":"        mock_get_output.return_value \u003d expected_output"},{"line_number":319,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_deba8ee0","line":316,"updated":"2015-03-05 06:19:16.000000000","message":"Repeated twice","commit_id":"5db5cad37d68db19cff0928efa1f9b6df30bc576"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"2b07cb5ff9dc9fdf6a79f950f379d30fee186b72","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":320,"context_line":"        chan.send(cmd + \u0027\\r\u0027)"},{"line_number":321,"context_line":"        mock_get_output.return_value \u003d expected_output"},{"line_number":322,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":323,"context_line":"        chan.close()"},{"line_number":324,"context_line":"        self.assertRaises(processutils.ProcessExecutionError,"},{"line_number":325,"context_line":"                          self.driver._ssh_execute, ssh, cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fea672c0","line":322,"updated":"2015-03-05 06:19:16.000000000","message":"Unless I\u0027m missing something here, this needs to be only assigned once since the value of cmd is not changing","commit_id":"5db5cad37d68db19cff0928efa1f9b6df30bc576"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"79882d648bb6fcb36a2453a84524c4431775b6ad","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":320,"context_line":"        chan.send(cmd + \u0027\\r\u0027)"},{"line_number":321,"context_line":"        mock_get_output.return_value \u003d expected_output"},{"line_number":322,"context_line":"        cmd \u003d \u0027this is dummy command\u0027"},{"line_number":323,"context_line":"        chan.close()"},{"line_number":324,"context_line":"        self.assertRaises(processutils.ProcessExecutionError,"},{"line_number":325,"context_line":"                          self.driver._ssh_execute, ssh, cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_4abddc67","line":322,"in_reply_to":"9a80dd14_fea672c0","updated":"2015-03-05 16:44:41.000000000","message":"This is used in multiple tests. Maybe just make it a constant?","commit_id":"5db5cad37d68db19cff0928efa1f9b6df30bc576"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            mock_eql_execute.configure_mock(**mock_attrs)"},{"line_number":104,"context_line":"            mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":105,"context_line":"            model_update \u003d self.driver.create_volume(volume)"},{"line_number":106,"context_line":"            self.assertEqual(model_update, self._model_update)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_delete_volume(self):"},{"line_number":109,"context_line":"        volume \u003d {\u0027name\u0027: self.volume_name, \u0027size\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1465be44","line":106,"updated":"2015-03-05 20:15:18.000000000","message":"Method signature is assertEqual(expected, observed).\nI believe this should be:\nself.assertEqual(self.model_update, model_update)\n\nNote: other mock tests had to also reverse the expected \u0026 observed values so any error messages would be correct.","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":157,"context_line":"            model_update \u003d self.driver.create_volume_from_snapshot(volume,"},{"line_number":158,"context_line":"                                                                   snapshot)"},{"line_number":159,"context_line":"            self.assertEqual(model_update, self._model_update)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":162,"context_line":"        src_vref \u003d {\u0027name\u0027: \u0027fake_uuid\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_34d3a2d7","line":159,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed.","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            mock_eql_execute.configure_mock(**mock_attrs)"},{"line_number":169,"context_line":"            mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":170,"context_line":"            model_update \u003d self.driver.create_cloned_volume(volume, src_vref)"},{"line_number":171,"context_line":"            self.assertEqual(model_update, self._model_update)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_delete_snapshot(self):"},{"line_number":174,"context_line":"        snapshot \u003d {\u0027name\u0027: \u0027fakesnap\u0027, \u0027volume_name\u0027: \u0027fakevolume_name\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_14f3fe73","line":171,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                mock_iscsi.return_value \u003d self.properties"},{"line_number":206,"context_line":"                iscsi_properties \u003d self.driver.initialize_connection("},{"line_number":207,"context_line":"                    volume, self.connector)"},{"line_number":208,"context_line":"                self.assertEqual(iscsi_properties[\u0027data\u0027],"},{"line_number":209,"context_line":"                                 self._fake_get_iscsi_properties(volume))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_terminate_connection(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f4966aef","line":208,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed.","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                             \u0027FreeSpace: 11GB\u0027]"},{"line_number":246,"context_line":"            self.driver._update_volume_stats()"},{"line_number":247,"context_line":"            self.assertEqual(self.driver._stats[\u0027total_capacity_gb\u0027], 111.0)"},{"line_number":248,"context_line":"            self.assertEqual(self.driver._stats[\u0027free_capacity_gb\u0027], 11.0)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_get_volume_stats(self):"},{"line_number":251,"context_line":"        mock_attrs \u003d {\u0027args\u0027: [\u0027pool\u0027, \u0027select\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1f04f713","line":248,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":259,"context_line":"            self.assertEqual(stats[\u0027total_capacity_gb\u0027], float(\u0027111.0\u0027))"},{"line_number":260,"context_line":"            self.assertEqual(stats[\u0027free_capacity_gb\u0027], float(\u002711.0\u0027))"},{"line_number":261,"context_line":"            self.assertEqual(stats[\u0027vendor_name\u0027], \u0027Dell\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_get_space_in_gb(self):"},{"line_number":264,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u0027123.0GB\u0027), 123.0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7f141344","line":261,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def test_get_space_in_gb(self):"},{"line_number":264,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u0027123.0GB\u0027), 123.0)"},{"line_number":265,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u0027123.0TB\u0027), 123.0 * 1024)"},{"line_number":266,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u00271024.0MB\u0027), 1.0)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def test_get_output(self):"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ff2723b4","line":266,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        chan \u003d mock.Mock(paramiko.Channel)"},{"line_number":274,"context_line":"        mock_recv \u003d self.mock_object(chan, \u0027recv\u0027)"},{"line_number":275,"context_line":"        mock_recv.return_value \u003d \u0027%s\u003e \u0027 % self.configuration.eqlx_group_name"},{"line_number":276,"context_line":"        self.assertEqual(self.driver._get_output(chan), [_fake_recv(None)])"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_get_prefixed_value(self):"},{"line_number":279,"context_line":"        lines \u003d [\u0027Line1 passed\u0027, \u0027Line1 failed\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7f42533f","line":276,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        self.assertEqual(self.driver._get_prefixed_value(lines, prefix[0]),"},{"line_number":283,"context_line":"                         expected_output[0])"},{"line_number":284,"context_line":"        self.assertEqual(self.driver._get_prefixed_value(lines, prefix[1]),"},{"line_number":285,"context_line":"                         expected_output[1])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_ssh_execute(self):"},{"line_number":288,"context_line":"        ssh \u003d mock.Mock(paramiko.SSHClient)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_df47bf49","line":285,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed.","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"90c510067c50b03c7f612291d5a3d155d297471a","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        chan.send(self.cmd + \u0027\\r\u0027)"},{"line_number":300,"context_line":"        chan.close()"},{"line_number":301,"context_line":"        self.assertEqual(self.driver._ssh_execute(ssh, self.cmd),"},{"line_number":302,"context_line":"                         expected_output)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_ssh_execute_error(self):"},{"line_number":305,"context_line":"        ssh \u003d mock.Mock(paramiko.SSHClient)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7f6973bd","line":302,"updated":"2015-03-05 20:15:18.000000000","message":"expected, observed reversed?","commit_id":"8fbae208febb2ec94e1bb08c04d8e0a4db81ef30"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"a015089a3582a505cb5fdecf7f7d4e29efc83080","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":157,"context_line":"            model_update \u003d self.driver.create_volume_from_snapshot(volume,"},{"line_number":158,"context_line":"                                                                   snapshot)"},{"line_number":159,"context_line":"            self.assertEqual(model_update, self._model_update)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":162,"context_line":"        src_vref \u003d {\u0027name\u0027: \u0027fake_uuid\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e8ea060e","line":159,"updated":"2015-03-05 22:57:29.000000000","message":"Shouldn\u0027t this be swapped, too?","commit_id":"fb5089f82cb294f0fea4f42122cc92e2a88afbfe"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"a015089a3582a505cb5fdecf7f7d4e29efc83080","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            mock_eql_execute.configure_mock(**mock_attrs)"},{"line_number":169,"context_line":"            mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":170,"context_line":"            model_update \u003d self.driver.create_cloned_volume(volume, src_vref)"},{"line_number":171,"context_line":"            self.assertEqual(model_update, self._model_update)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_delete_snapshot(self):"},{"line_number":174,"context_line":"        snapshot \u003d {\u0027name\u0027: \u0027fakesnap\u0027, \u0027volume_name\u0027: \u0027fakevolume_name\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_88d98a85","line":171,"updated":"2015-03-05 22:57:29.000000000","message":"And here?","commit_id":"fb5089f82cb294f0fea4f42122cc92e2a88afbfe"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"a015089a3582a505cb5fdecf7f7d4e29efc83080","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def test_get_space_in_gb(self):"},{"line_number":264,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u0027123.0GB\u0027), 123.0)"},{"line_number":265,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u0027123.0TB\u0027), 123.0 * 1024)"},{"line_number":266,"context_line":"        self.assertEqual(self.driver._get_space_in_gb(\u00271024.0MB\u0027), 1.0)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def test_get_output(self):"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_48cf92b0","line":266,"updated":"2015-03-05 22:57:29.000000000","message":"still reversed?","commit_id":"fb5089f82cb294f0fea4f42122cc92e2a88afbfe"}]}