)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"952c623281be0c61850d285f433f80d7bba906e2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Patch #133566 partially changed Volumes and Volume Snapshots to objects. This"},{"line_number":10,"context_line":"change broke HBSD driver. The intended fix was to update driver to use the new"},{"line_number":11,"context_line":"objects, but at this moment, \"snapshot\" object type received from manager"},{"line_number":12,"context_line":"differs in \"create_snapshot\" and \"create_volume_from_snapshot\" methods, so the"},{"line_number":13,"context_line":"new objects cannot be used across the driver. This is a temporary fix to keep"},{"line_number":14,"context_line":"Driver and CI running. A subsequent patch is mentioned in #133566 that will"},{"line_number":15,"context_line":"update the remaining parameters sent from API, and then the HBSD driver will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_8ee35f04","line":12,"updated":"2015-03-05 19:20:55.000000000","message":"Which fields are missing?  Could you show a sample of the object from create_snapshot vs. the dict from create_volume_from_snapshot?","commit_id":"238794191317358185c85a3068818c8b4a0f70ff"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"0789d2a8b73bd7c6d43f581ef08cd78a2b2342c3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Patch #133566 partially changed Volumes and Volume Snapshots to objects. This"},{"line_number":10,"context_line":"change broke HBSD driver. The intended fix was to update driver to use the new"},{"line_number":11,"context_line":"objects, but at this moment, \"snapshot\" object type received from manager"},{"line_number":12,"context_line":"differs in \"create_snapshot\" and \"create_volume_from_snapshot\" methods, so the"},{"line_number":13,"context_line":"new objects cannot be used across the driver. This is a temporary fix to keep"},{"line_number":14,"context_line":"Driver and CI running. A subsequent patch is mentioned in #133566 that will"},{"line_number":15,"context_line":"update the remaining parameters sent from API, and then the HBSD driver will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_f1067ccd","line":12,"in_reply_to":"9a80dd14_8ee35f04","updated":"2015-03-05 19:39:21.000000000","message":"Actually the problem is https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L411.  We just need to use objects.Snapshot.get_by_id(context, snapshot_id) there.  I will spin up a patch for it shortly.  This should make the return for \"create_snapshot\" and \"create_volume_from_snapshot\" be a snapshot object.","commit_id":"238794191317358185c85a3068818c8b4a0f70ff"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"b68ab545749cde20fb5ae88c1fcee79ef56f426a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Patch #133566 partially changed Volumes and Volume Snapshots to objects. This"},{"line_number":10,"context_line":"change broke HBSD driver. The intended fix was to update driver to use the new"},{"line_number":11,"context_line":"objects, but at this moment, \"snapshot\" object type received from manager"},{"line_number":12,"context_line":"differs in \"create_snapshot\" and \"create_volume_from_snapshot\" methods, so the"},{"line_number":13,"context_line":"new objects cannot be used across the driver. This is a temporary fix to keep"},{"line_number":14,"context_line":"Driver and CI running. A subsequent patch is mentioned in #133566 that will"},{"line_number":15,"context_line":"update the remaining parameters sent from API, and then the HBSD driver will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_51d668c6","line":12,"in_reply_to":"9a80dd14_f1067ccd","updated":"2015-03-05 19:47:38.000000000","message":"Nice, I think it will fix most part of our problem!","commit_id":"238794191317358185c85a3068818c8b4a0f70ff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"54d698a6eb7913c3e37b70f516a4488579d1283b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Error trying to delete snapshots on Hitachi driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch #133566 partially changed Volumes and Volume Snapshots to objects"},{"line_number":10,"context_line":"and modified their attributes. This change broke HBSD driver, once the"},{"line_number":11,"context_line":"\u0027snapshot_metadata\u0027 attribute was replaced to \u0027metadata\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_9270750c","line":9,"updated":"2015-03-09 15:28:42.000000000","message":"It\u0027s generally more useful to refer to patches by git commit sha or change-id, since review numbers don\u0027t really have a meaning in git history.","commit_id":"6d6bcb4bfcaa56e4c8e2a9a838a1e3339e88db19"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"8560eda8da41413bf7b05a45c6d65d41ae6fec7a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Error trying to delete snapshots on Hitachi driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch #133566 partially changed Volumes and Volume Snapshots to objects"},{"line_number":10,"context_line":"and modified their attributes. This change broke HBSD driver, once the"},{"line_number":11,"context_line":"\u0027snapshot_metadata\u0027 attribute was replaced to \u0027metadata\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_9985d0d0","line":9,"in_reply_to":"9a80dd14_9270750c","updated":"2015-03-10 11:57:20.000000000","message":"Ok. Should I have to post another patch with git commit sha? Or you commented just to make me aware to do it in future patches?","commit_id":"6d6bcb4bfcaa56e4c8e2a9a838a1e3339e88db19"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"952c623281be0c61850d285f433f80d7bba906e2","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_volume_is_vvol(self, volume):"},{"line_number":186,"context_line":"        return self.get_is_vvol(volume, \u0027volume_metadata\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_snapshot_is_vvol(self, snapshot):"},{"line_number":189,"context_line":"        return self.get_is_vvol(snapshot, \u0027snapshot_metadata\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def get_copy_method(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0e0a0fd2","side":"PARENT","line":188,"updated":"2015-03-05 19:20:55.000000000","message":"I am assuming the snapshot that gets passed in here is an object.  You can access the snapshot metadata via - snapshot.metadata.  I do not believe it is necessary to use the workaround you wrote here.","commit_id":"8b38fecab8f36bd4a226b8af790fd6db6f0b3ce5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f37a6fa04b133caa7100f0a309f22db1f5c31c37","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_volume_is_vvol(self, volume):"},{"line_number":186,"context_line":"        return self.get_is_vvol(volume, \u0027volume_metadata\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_snapshot_is_vvol(self, snapshot):"},{"line_number":189,"context_line":"        return self.get_is_vvol(snapshot, \u0027snapshot_metadata\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def get_copy_method(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d7ba36bf","side":"PARENT","line":188,"in_reply_to":"9a80dd14_0e0a0fd2","updated":"2015-03-06 04:30:09.000000000","message":"Can you try Thang\u0027s suggestion?","commit_id":"8b38fecab8f36bd4a226b8af790fd6db6f0b3ce5"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"90b9e402f71f0d1592debe26f4b2d4e321677724","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_volume_is_vvol(self, volume):"},{"line_number":186,"context_line":"        return self.get_is_vvol(volume, \u0027volume_metadata\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_snapshot_is_vvol(self, snapshot):"},{"line_number":189,"context_line":"        return self.get_is_vvol(snapshot, \u0027snapshot_metadata\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def get_copy_method(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cb51a537","side":"PARENT","line":188,"in_reply_to":"9a80dd14_d7ba36bf","updated":"2015-03-06 11:25:41.000000000","message":"Yes, I will do that. I\u0027m waiting to the Thang\u0027s patch get merged (https://review.openstack.org/#/c/161945/) to  then resubmit the patch with all changes needed using the Thang\u0027s approach.","commit_id":"8b38fecab8f36bd4a226b8af790fd6db6f0b3ce5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f37a6fa04b133caa7100f0a309f22db1f5c31c37","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        return self.db.volume_get(self.context, volume_id)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def get_snapshot(self, snapshot_id):"},{"line_number":151,"context_line":"        return self.db.snapshot_get(self.context, snapshot_id)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def get_volume_metadata(self, volume_id):"},{"line_number":154,"context_line":"        return self.db.volume_metadata_get(self.context, volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b7906244","line":151,"updated":"2015-03-06 04:30:09.000000000","message":"We should be using object now instead of getting it directly from the db.","commit_id":"238794191317358185c85a3068818c8b4a0f70ff"}]}