)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8996a5b4bff801b957834db12fe297558cea248c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix retype return value in volume driver base class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of raising an exception, the expected behaviour is to return"},{"line_number":10,"context_line":"a tuple indicating that the driver does not support retype operation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I395dfc3213bb560767ac3fc95e5d68c4a87a7640"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_73cfb429","line":9,"updated":"2015-03-06 21:56:35.000000000","message":"Expected in that this is what happened before the abc driver changes were introduced, and presumably accidentally changed this.","commit_id":"d138b06a49a750a577a016166d04a518dec40b57"}],"cinder/volume/driver.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a95ba627911873a3485df604cf099b26e5cd3da8","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"        raise NotImplementedError(msg)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    def retype(self, context, volume, new_type, diff, host):"},{"line_number":1104,"context_line":"        return False, None"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    def reenable_replication(self, context, volume):"},{"line_number":1107,"context_line":"        msg \u003d _(\"sync_replica not implemented.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_3fb95f79","line":1104,"updated":"2015-03-09 08:57:45.000000000","message":"Why is it a good idea for retype()  to behave differently to all the other methods in this file?","commit_id":"d138b06a49a750a577a016166d04a518dec40b57"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"db9865ce09b1eadf83ae350994555c357eaf8878","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"        raise NotImplementedError(msg)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    def retype(self, context, volume, new_type, diff, host):"},{"line_number":1104,"context_line":"        return False, None"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    def reenable_replication(self, context, volume):"},{"line_number":1107,"context_line":"        msg \u003d _(\"sync_replica not implemented.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a4809b47","line":1104,"in_reply_to":"9a80dd14_3fb95f79","updated":"2015-03-10 17:26:20.000000000","message":"The retype path has drivers return (False, None) to indicate a no-op and that the manager should use the generic retype path.\n\nThat path was being used here until this was accidentally changed by the abc patch:\nhttps://review.openstack.org/#/c/127455/","commit_id":"d138b06a49a750a577a016166d04a518dec40b57"}]}