)]}'
{"cinder/tests/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"75f48aa86fcd6a07b310fc5071c5ae9d52c4cb8a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            fake.FC_FORMATTED_INITIATORS, \u0027fcp\u0027, \u0027linux\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        self.assertEqual(igroup_name, fake.IGROUP1_NAME)"},{"line_number":219,"context_line":"        self.assertEqual(host_os, \u0027linux\u0027)"},{"line_number":220,"context_line":"        self.assertEqual(ig_type, \u0027fcp\u0027)"},{"line_number":221,"context_line":"        self.zapi_client.get_igroup_by_initiators.assert_called_once_with("},{"line_number":222,"context_line":"            fake.FC_FORMATTED_INITIATORS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_11368b03","line":219,"updated":"2015-04-01 19:12:53.000000000","message":"Should be:\n\nself.assertEqual(expected, actual)","commit_id":"27fb72e9bd24b948567beeefee938bf9f0589765"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"75f48aa86fcd6a07b310fc5071c5ae9d52c4cb8a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual(ig_type, \u0027fcp\u0027)"},{"line_number":221,"context_line":"        self.zapi_client.get_igroup_by_initiators.assert_called_once_with("},{"line_number":222,"context_line":"            fake.FC_FORMATTED_INITIATORS)"},{"line_number":223,"context_line":"        self.assertEqual("},{"line_number":224,"context_line":"            self.library._create_igroup_add_initiators.call_count, 0)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @mock.patch.object(uuid, \u0027uuid4\u0027, mock.Mock(return_value\u003dfake.UUID1))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_91229bb8","line":223,"updated":"2015-04-01 19:12:53.000000000","message":"Should be:\n\nself.assertEqual(expected, actual)","commit_id":"27fb72e9bd24b948567beeefee938bf9f0589765"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"75f48aa86fcd6a07b310fc5071c5ae9d52c4cb8a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            igroup_name, \u0027fcp\u0027, \u0027linux\u0027)"},{"line_number":237,"context_line":"        self.assertEqual(len(fake.FC_FORMATTED_INITIATORS),"},{"line_number":238,"context_line":"                         self.zapi_client.add_igroup_initiator.call_count)"},{"line_number":239,"context_line":"        self.assertEqual(os, \u0027linux\u0027)"},{"line_number":240,"context_line":"        self.assertEqual(ig_type, \u0027fcp\u0027)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_get_fc_target_wwpns(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_712f17a2","line":239,"updated":"2015-04-01 19:12:53.000000000","message":"Should be:\n\nself.assertEqual(expected, actual)","commit_id":"27fb72e9bd24b948567beeefee938bf9f0589765"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3e608f472b8e89a67f8fca4defb5d8d44304cbab","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            self.library.host_type)"},{"line_number":136,"context_line":"        self.zapi_client.map_lun.assert_called_once_with("},{"line_number":137,"context_line":"            fake.LUN1, fake.IGROUP1_NAME, lun_id\u003dNone)"},{"line_number":138,"context_line":"        block_base.LOG.warning.assert_called_once_with(_LW("},{"line_number":139,"context_line":"            \"LUN misalignment may occur for current\""},{"line_number":140,"context_line":"            \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":141,"context_line":"            \" %(ig_os)s. Please configure initiator group\""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a669cb8d","line":138,"updated":"2015-04-02 11:46:16.000000000","message":"Validating log messages in UTs doesn\u0027t seem right to me. Are you sure this is a good practice?","commit_id":"42fc2c27232ca1421ea02dc21595a5dddb5ad5e6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73df1c3310316c92796473e16cc90e1119af5866","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            self.library.host_type)"},{"line_number":137,"context_line":"        self.zapi_client.map_lun.assert_called_once_with("},{"line_number":138,"context_line":"            fake.LUN1, fake.IGROUP1_NAME, lun_id\u003dNone)"},{"line_number":139,"context_line":"        block_base.LOG.warning.assert_called_once_with(_LW("},{"line_number":140,"context_line":"            \"LUN misalignment may occur for current\""},{"line_number":141,"context_line":"            \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":142,"context_line":"            \" %(ig_os)s. Please configure initiator group\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_7ac9fd77","line":139,"updated":"2015-04-07 18:02:52.000000000","message":"I still have an objection to validating log message strings in the unit tests. Based on conversation in IRC there are others that also agree.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"82ae4ba833dfd8a9b9c39573740fa75e88da2cc5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            self.library.host_type)"},{"line_number":137,"context_line":"        self.zapi_client.map_lun.assert_called_once_with("},{"line_number":138,"context_line":"            fake.LUN1, fake.IGROUP1_NAME, lun_id\u003dNone)"},{"line_number":139,"context_line":"        block_base.LOG.warning.assert_called_once_with(_LW("},{"line_number":140,"context_line":"            \"LUN misalignment may occur for current\""},{"line_number":141,"context_line":"            \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":142,"context_line":"            \" %(ig_os)s. Please configure initiator group\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_fd9b5964","line":139,"in_reply_to":"9aa53dc9_2598ccbf","updated":"2015-04-10 03:29:01.000000000","message":"I agree that it should make sure a message is logged. The part I object to is the unit test validating specifically what the log text is. Just have it make sure LOG.warning is called without checking the text that was passed in to it.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"3c5a29423dc51c9a2da2342c1850e3508791b58d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            self.library.host_type)"},{"line_number":137,"context_line":"        self.zapi_client.map_lun.assert_called_once_with("},{"line_number":138,"context_line":"            fake.LUN1, fake.IGROUP1_NAME, lun_id\u003dNone)"},{"line_number":139,"context_line":"        block_base.LOG.warning.assert_called_once_with(_LW("},{"line_number":140,"context_line":"            \"LUN misalignment may occur for current\""},{"line_number":141,"context_line":"            \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":142,"context_line":"            \" %(ig_os)s. Please configure initiator group\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_2598ccbf","line":139,"in_reply_to":"9aa53dc9_7ac9fd77","updated":"2015-04-08 16:37:26.000000000","message":"I\u0027m not really sure what the harm is - a test case that forces an error path arguably should make sure that a user-facing message is logged. Perhaps you could elaborate your thinking on this?","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f7026b77eb9e5b3966fe33c71010fd496cb74c14","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def do_setup(self, context):"},{"line_number":109,"context_line":"        na_utils.check_flags(self.REQUIRED_FLAGS, self.configuration)"},{"line_number":110,"context_line":"        self.lun_ostype \u003d self.configuration.netapp_lun_ostype\\"},{"line_number":111,"context_line":"            or self.DEFAULT_LUN_OS"},{"line_number":112,"context_line":"        self.host_type \u003d self.configuration.netapp_host_type\\"},{"line_number":113,"context_line":"            or self.DEFAULT_HOST_TYPE"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e238bed6","line":110,"updated":"2015-03-10 19:56:05.000000000","message":"Please, replace \\ with () here and below","commit_id":"c2a0de07529e771d9359571a6518289806701ca1"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f7026b77eb9e5b3966fe33c71010fd496cb74c14","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        igroup_name, ig_host_os, ig_type \u003d self._get_or_create_igroup("},{"line_number":286,"context_line":"            initiator_list, initiator_type, self.host_type)"},{"line_number":287,"context_line":"        if ig_host_os !\u003d self.host_type:"},{"line_number":288,"context_line":"            LOG.warning(_(\"LUN misalignment may occur for current\""},{"line_number":289,"context_line":"                          \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":290,"context_line":"                          \" %(ig_os)s. Please configure initiator group\""},{"line_number":291,"context_line":"                          \" manually according to the type of the\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_c272daac","line":288,"updated":"2015-03-10 19:56:05.000000000","message":"_LW marker should be used","commit_id":"c2a0de07529e771d9359571a6518289806701ca1"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f7026b77eb9e5b3966fe33c71010fd496cb74c14","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                          \" %(ig_os)s. Please configure initiator group\""},{"line_number":291,"context_line":"                          \" manually according to the type of the\""},{"line_number":292,"context_line":"                          \" host OS.\")"},{"line_number":293,"context_line":"                        % {\u0027ig_nm\u0027: igroup_name, \u0027ig_os\u0027: ig_host_os})"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            return self.zapi_client.map_lun(path, igroup_name, lun_id\u003dlun_id)"},{"line_number":296,"context_line":"        except na_api.NaApiError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_2261f6d3","line":293,"updated":"2015-03-10 19:56:05.000000000","message":"Please, replace % with ,","commit_id":"c2a0de07529e771d9359571a6518289806701ca1"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2dae7bc3202a2f79e380a7629d91a36358f0bce9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        igroup_name, ig_host_os, ig_type \u003d self._get_or_create_igroup("},{"line_number":286,"context_line":"            initiator_list, initiator_type, self.host_type)"},{"line_number":287,"context_line":"        if ig_host_os !\u003d self.host_type:"},{"line_number":288,"context_line":"            LOG.warning((_LW(\"LUN misalignment may occur for current\""},{"line_number":289,"context_line":"                             \" initiator group %(ig_nm)s) with host OS type\""},{"line_number":290,"context_line":"                             \" %(ig_os)s. Please configure initiator group\""},{"line_number":291,"context_line":"                             \" manually according to the type of the\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c618ce86","line":288,"updated":"2015-03-12 14:54:12.000000000","message":"Too many \u0027(\u0027","commit_id":"035f8dcd673831b1a17caa6f5f4c4e20307ac07f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"75f48aa86fcd6a07b310fc5071c5ae9d52c4cb8a","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        igroups \u003d self.zapi_client.get_igroup_by_initiators(initiator_list)"},{"line_number":327,"context_line":"        igroup_name \u003d None"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        for igroup in igroups:"},{"line_number":330,"context_line":"            igroup_name \u003d igroup[\u0027initiator-group-name\u0027]"},{"line_number":331,"context_line":"            host_os_type \u003d igroup[\u0027initiator-group-os-type\u0027]"},{"line_number":332,"context_line":"            initiator_group_type \u003d igroup[\u0027initiator-group-type\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_b1891fcd","line":329,"updated":"2015-04-01 19:12:53.000000000","message":"Do we really need loop here?","commit_id":"27fb72e9bd24b948567beeefee938bf9f0589765"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"49e599a88c22da9c84e8cfd0eb06a2437ab5758f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        Discovers the LUNs on the NetApp server."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        if self.lun_ostype not in self.ALLOWED_LUN_OS_TYPES:"},{"line_number":121,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":122,"context_line":"                    \" option netapp_lun_ostype.\")"},{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_bec1d930","line":121,"updated":"2015-04-07 07:11:48.000000000","message":"Could you localize the error message by adding _LE in front of this message?","commit_id":"3ba1245ae0e3ad12f6e0572f070abcb6188462da"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"49e599a88c22da9c84e8cfd0eb06a2437ab5758f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"},{"line_number":125,"context_line":"        if self.host_type not in self.ALLOWED_IGROUP_HOST_TYPES:"},{"line_number":126,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":127,"context_line":"                    \" option netapp_host_type.\")"},{"line_number":128,"context_line":"            LOG.error(msg)"},{"line_number":129,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_9eddf516","line":126,"updated":"2015-04-07 07:11:48.000000000","message":"Could you localize the error message by adding _LE in front of this message?","commit_id":"3ba1245ae0e3ad12f6e0572f070abcb6188462da"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73df1c3310316c92796473e16cc90e1119af5866","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        Discovers the LUNs on the NetApp server."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        if self.lun_ostype not in self.ALLOWED_LUN_OS_TYPES:"},{"line_number":121,"context_line":"            msg \u003d _LE(\"Invalid value for NetApp configuration\""},{"line_number":122,"context_line":"                      \" option netapp_lun_ostype.\")"},{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_9a916155","line":121,"updated":"2015-04-07 18:02:52.000000000","message":"This needs to be _() since it is used for both logging and the exception.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"3c5a29423dc51c9a2da2342c1850e3508791b58d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        Discovers the LUNs on the NetApp server."},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        if self.lun_ostype not in self.ALLOWED_LUN_OS_TYPES:"},{"line_number":121,"context_line":"            msg \u003d _LE(\"Invalid value for NetApp configuration\""},{"line_number":122,"context_line":"                      \" option netapp_lun_ostype.\")"},{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_05da6878","line":121,"in_reply_to":"9aa53dc9_9a916155","updated":"2015-04-08 16:37:26.000000000","message":"Done","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73df1c3310316c92796473e16cc90e1119af5866","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"},{"line_number":125,"context_line":"        if self.host_type not in self.ALLOWED_IGROUP_HOST_TYPES:"},{"line_number":126,"context_line":"            msg \u003d _LE(\"Invalid value for NetApp configuration\""},{"line_number":127,"context_line":"                      \" option netapp_host_type.\")"},{"line_number":128,"context_line":"            LOG.error(msg)"},{"line_number":129,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_7aa0dd9f","line":126,"updated":"2015-04-07 18:02:52.000000000","message":"Same.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"3c5a29423dc51c9a2da2342c1850e3508791b58d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"},{"line_number":125,"context_line":"        if self.host_type not in self.ALLOWED_IGROUP_HOST_TYPES:"},{"line_number":126,"context_line":"            msg \u003d _LE(\"Invalid value for NetApp configuration\""},{"line_number":127,"context_line":"                      \" option netapp_host_type.\")"},{"line_number":128,"context_line":"            LOG.error(msg)"},{"line_number":129,"context_line":"            raise exception.NetAppDriverException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_e5e8a412","line":126,"in_reply_to":"9aa53dc9_7aa0dd9f","updated":"2015-04-08 16:37:26.000000000","message":"Done","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73df1c3310316c92796473e16cc90e1119af5866","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        name \u003d volume[\u0027name\u0027]"},{"line_number":634,"context_line":"        lun_id \u003d self._map_lun(name, [initiator_name], \u0027iscsi\u0027, None)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        msg \u003d _(\"Mapped LUN %(name)s to the initiator %(initiator_name)s\")"},{"line_number":637,"context_line":"        msg_fmt \u003d {\u0027name\u0027: name, \u0027initiator_name\u0027: initiator_name}"},{"line_number":638,"context_line":"        LOG.debug(msg % msg_fmt)"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_ba7d451e","line":636,"updated":"2015-04-07 18:02:52.000000000","message":"Debug strings should not be localized.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"3c5a29423dc51c9a2da2342c1850e3508791b58d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        name \u003d volume[\u0027name\u0027]"},{"line_number":634,"context_line":"        lun_id \u003d self._map_lun(name, [initiator_name], \u0027iscsi\u0027, None)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        msg \u003d _(\"Mapped LUN %(name)s to the initiator %(initiator_name)s\")"},{"line_number":637,"context_line":"        msg_fmt \u003d {\u0027name\u0027: name, \u0027initiator_name\u0027: initiator_name}"},{"line_number":638,"context_line":"        LOG.debug(msg % msg_fmt)"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_85ed5827","line":636,"in_reply_to":"9aa53dc9_ba7d451e","updated":"2015-04-08 16:37:26.000000000","message":"Done","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"73df1c3310316c92796473e16cc90e1119af5866","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            msg \u003d _(\u0027Failed to get LUN target list for the LUN %s\u0027)"},{"line_number":643,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % name)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        msg \u003d _(\"Successfully fetched target list for LUN %(name)s and \""},{"line_number":646,"context_line":"                \"initiator %(initiator_name)s\")"},{"line_number":647,"context_line":"        msg_fmt \u003d {\u0027name\u0027: name, \u0027initiator_name\u0027: initiator_name}"},{"line_number":648,"context_line":"        LOG.debug(msg % msg_fmt)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_3a901543","line":645,"updated":"2015-04-07 18:02:52.000000000","message":"Should not be localized.","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"3c5a29423dc51c9a2da2342c1850e3508791b58d","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            msg \u003d _(\u0027Failed to get LUN target list for the LUN %s\u0027)"},{"line_number":643,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg % name)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        msg \u003d _(\"Successfully fetched target list for LUN %(name)s and \""},{"line_number":646,"context_line":"                \"initiator %(initiator_name)s\")"},{"line_number":647,"context_line":"        msg_fmt \u003d {\u0027name\u0027: name, \u0027initiator_name\u0027: initiator_name}"},{"line_number":648,"context_line":"        LOG.debug(msg % msg_fmt)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_65f494f1","line":645,"in_reply_to":"9aa53dc9_3a901543","updated":"2015-04-08 16:37:26.000000000","message":"Done","commit_id":"726a48311c1ccd7679aefc3f9fad642cdabc15a9"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"50fd8e8046703d0ab2d676145fef535e52aff520","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":122,"context_line":"                    \" option netapp_lun_ostype.\")"},{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"},{"line_number":125,"context_line":"        if self.host_type not in self.ALLOWED_IGROUP_HOST_TYPES:"},{"line_number":126,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":127,"context_line":"                    \" option netapp_host_type.\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ab451fb_e4ceb582","line":124,"updated":"2015-04-17 13:33:50.000000000","message":"Should we add ALLOWED_LUN_OS_TYPES to error message? It will make troubleshooting more easy","commit_id":"614c82fe160d8e776cd6acc6f6f1b12c63ddfb0f"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"14c3c3ba4bcfdf050d8286954889475111786f74","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":122,"context_line":"                    \" option netapp_lun_ostype.\")"},{"line_number":123,"context_line":"            LOG.error(msg)"},{"line_number":124,"context_line":"            raise exception.NetAppDriverException(msg)"},{"line_number":125,"context_line":"        if self.host_type not in self.ALLOWED_IGROUP_HOST_TYPES:"},{"line_number":126,"context_line":"            msg \u003d _(\"Invalid value for NetApp configuration\""},{"line_number":127,"context_line":"                    \" option netapp_host_type.\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ab451fb_83092498","line":124,"in_reply_to":"3ab451fb_e4ceb582","updated":"2015-04-17 14:59:53.000000000","message":"I think documentation is probably sufficient for this.","commit_id":"614c82fe160d8e776cd6acc6f6f1b12c63ddfb0f"}],"cinder/volume/drivers/netapp/eseries/iscsi.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f7026b77eb9e5b3966fe33c71010fd496cb74c14","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self._start_periodic_tasks()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _check_host_type(self):"},{"line_number":150,"context_line":"        host_type \u003d self.configuration.netapp_host_type\\"},{"line_number":151,"context_line":"            or self.DEFAULT_HOST_TYPE"},{"line_number":152,"context_line":"        self.host_type \u003d self.HOST_TYPES.get(host_type)"},{"line_number":153,"context_line":"        if not self.host_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_62812e4d","line":150,"updated":"2015-03-10 19:56:05.000000000","message":"\\ \u003d\u003e ()","commit_id":"c2a0de07529e771d9359571a6518289806701ca1"}]}